Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add long error explanation for E0625 #87715

Merged
merged 3 commits into from
Aug 6, 2021
Merged

Add long error explanation for E0625 #87715

merged 3 commits into from
Aug 6, 2021

Conversation

bhgomes
Copy link
Contributor

@bhgomes bhgomes commented Aug 3, 2021

For #61137.

@rust-highfive
Copy link
Collaborator

Some changes occurred in diagnostic error codes

cc @GuillaumeGomez

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @petrochenkov (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 3, 2021
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@petrochenkov
Copy link
Contributor

tidy error: /checkout/compiler/rustc_error_codes/src/error_codes/E0625.md: too many trailing newlines (2)

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 3, 2021
GuillaumeGomez
GuillaumeGomez requested changes Aug 3, 2021
View reviewed changes
Copy link
Member

@GuillaumeGomez GuillaumeGomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move the explanation after the failing example but otherwise looks good to me.

compiler/rustc_error_codes/src/error_codes/E0625.md Outdated Show resolved Hide resolved
@petrochenkov
Copy link
Contributor

r? @GuillaumeGomez

@GuillaumeGomez
Copy link
Member

Thanks! r=me once CI pass

@GuillaumeGomez
Copy link
Member

@bors: r+ rollup squash

@bors
Copy link
Contributor

bors commented Aug 4, 2021

📌 Commit dc5f6d2 has been approved by GuillaumeGomez

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 4, 2021
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Aug 6, 2021
@JohnTitor
Rollup merge of rust-lang#87715 - bhgomes:long-explanation-E0625, r=G…
f13c61d 
…uillaumeGomez

Add long error explanation for E0625

For rust-lang#61137.
@JohnTitor JohnTitor mentioned this pull request Aug 6, 2021
Closed
@JohnTitor JohnTitor mentioned this pull request Aug 6, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 6, 2021
@bors
Auto merge of rust-lang#87808 - JohnTitor:rollup-qqp79xs, r=JohnTitor
1f94abc 
Rollup of 9 pull requests

Successful merges:

 - rust-lang#87561 (thread set_name haiku implementation.)
 - rust-lang#87715 (Add long error explanation for E0625)
 - rust-lang#87727 (explicit_generic_args_with_impl_trait: fix min expected number of generics)
 - rust-lang#87742 (Validate FFI-safety warnings on naked functions)
 - rust-lang#87756 (Add back -Zno-profiler-runtime)
 - rust-lang#87759 (Re-use std::sealed::Sealed in os/linux/process.)
 - rust-lang#87760 (Promote `aarch64-apple-ios-sim` to Tier 2)
 - rust-lang#87770 (permit drop impls with generic constants in where clauses)
 - rust-lang#87780 (alloc: Use intra doc links for the reserve function)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 772db06 into rust-lang:master Aug 6, 2021
@rustbot rustbot added this to the 1.56.0 milestone Aug 6, 2021
@bhgomes bhgomes deleted the long-explanation-E0625 branch September 14, 2021 00:33
@GuillaumeGomez GuillaumeGomez mentioned this pull request Oct 14, 2021
Closed
100 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@GuillaumeGomez GuillaumeGomez

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.56.0
Development

Successfully merging this pull request may close these issues.
7 participants
@bhgomes @rust-highfive @rust-log-analyzer @petrochenkov @GuillaumeGomez @bors @rustbot