Enable debug info tests on Windows #8757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…latforms. Otherwise it'll choose some "appropriate" platform-specific default (e.g. CP1252 on Windows).
|
@michaelwoerister - FYI |
| @@ -8,7 +8,7 @@ | |||
| // option. This file may not be copied, modified, or distributed | |||
| // except according to those terms. | |||
|
|
|||
| // xfail-win32 Broken because of LLVM bug: http://llvm.org/bugs/show_bug.cgi?id=16249 | |||
| // xfail-win32 | |||
There was a problem hiding this comment.
Do you know why these are broken? (Either way, could you pre-emptively file an issue and reference it here?)
|
That's great! Thanks Vadim! |
bors
added a commit
that referenced
this pull request
Aug 27, 2013
Now that new LLVM has landed, the debug info works on Windows as well. Most existing tests pass, except for the following four, which I left disabled for now: lexical-scope-in-for-loop lexical-scope-in-if lexical-scope-in-match lexical-scopes-in-block-expression Also, fixed a small problem with the debug info test runner.
Jarcho
pushed a commit
to Jarcho/rust
that referenced
this pull request
Aug 29, 2022
- only compare where predicates to trait bounds when generating where clause specific message to fix rust-lang#9151 - use comparable_trait_ref to account for trait bound generics to fix rust-lang#8757
Jarcho
pushed a commit
to Jarcho/rust
that referenced
this pull request
Aug 29, 2022
Jarcho
pushed a commit
to Jarcho/rust
that referenced
this pull request
Aug 29, 2022
…, r=flip1995 Fixes [`trait_duplication_in_bounds`] false positives Fixes rust-lang#9076 rust-lang#9151 rust-lang#8757. Partially fixes rust-lang#8771. changelog: [`trait_duplication_in_bounds`]: Reduce number of false positives.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that new LLVM has landed, the debug info works on Windows as well. Most existing tests pass, except for the following four, which I left disabled for now:
lexical-scope-in-for-loop
lexical-scope-in-if
lexical-scope-in-match
lexical-scopes-in-block-expression
Also, fixed a small problem with the debug info test runner.