Merge libterm into libtest #87247
Merged
Merge libterm into libtest #87247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @yaahc (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
crlf0710
force-pushed
the
merge-libterm-into-libtest
branch
from
275b5ae
to
bcecf2c
Compare
crlf0710
added
A-libtest
This comment has been minimized.
This comment has been minimized.
crlf0710
force-pushed
the
merge-libterm-into-libtest
branch
from
bcecf2c
to
56a63c4
Compare
This comment has been minimized.
This comment has been minimized.
nagisa
reviewed
Jul 18, 2021
crlf0710
force-pushed
the
merge-libterm-into-libtest
branch
from
56a63c4
to
4486795
Compare
|
@bors r+ LGTM! |
|
📌 Commit 4486795 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it's quite clear at this point that rust won't stablize the current libterm APIs to the outside world. And its only user is libtest. The compiler doesn't use this api at all. So I'm merging the crate into libtest as a module.
This also allows me to remove 15% of the libterm code, since these APIs are dead-code now.