Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache expansion hash globally #87044

Merged
merged 2 commits into from
Jul 14, 2021
Merged

Cache expansion hash globally #87044

merged 2 commits into from
Jul 14, 2021

Conversation

cjgillot
Copy link
Contributor

... instead of computing it multiple times.

Split from #86676
r? @petrochenkov

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 10, 2021
@cjgillot cjgillot mentioned this pull request Jul 10, 2021
Merged
@petrochenkov
Copy link
Contributor

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 11, 2021
@bors
Copy link
Contributor

bors commented Jul 11, 2021

⌛ Trying commit 5b0308c7296209d4632a80282e6e1c8d9609ce1e with merge 67224bcd833f32325793fec7ff8d021b84edd6d5...

@petrochenkov petrochenkov removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 11, 2021
@bors
Copy link
Contributor

bors commented Jul 11, 2021

☀️ Try build successful - checks-actions
Build commit: 67224bcd833f32325793fec7ff8d021b84edd6d5 (67224bcd833f32325793fec7ff8d021b84edd6d5)

@rust-timer
Copy link
Collaborator

Queued 67224bcd833f32325793fec7ff8d021b84edd6d5 with parent 432e145, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (67224bcd833f32325793fec7ff8d021b84edd6d5): comparison url.

Summary: This change led to significant mixed results 🤷 in compiler performance.

  • Moderate regression in instruction counts (up to 1.9% on full builds of deeply-nested-async-check)
  • Moderate improvement in instruction counts (up to -1.4% on incr-unchanged builds of inflate-check)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

@rustbot rustbot added perf-regression Performance regression. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jul 11, 2021
petrochenkov
petrochenkov reviewed Jul 11, 2021
View reviewed changes
compiler/rustc_span/src/lib.rs Outdated Show resolved Hide resolved
compiler/rustc_span/src/hygiene.rs Outdated Show resolved Hide resolved
compiler/rustc_span/src/hygiene.rs Outdated Show resolved Hide resolved
compiler/rustc_span/src/hygiene.rs Outdated Show resolved Hide resolved
compiler/rustc_span/src/hygiene.rs Outdated Show resolved Hide resolved
compiler/rustc_span/src/hygiene.rs Outdated Show resolved Hide resolved
compiler/rustc_span/src/hygiene.rs Outdated Show resolved Hide resolved
compiler/rustc_span/src/hygiene.rs Outdated Show resolved Hide resolved
compiler/rustc_metadata/src/rmeta/mod.rs Outdated Show resolved Hide resolved
compiler/rustc_resolve/src/lib.rs Show resolved Hide resolved
@petrochenkov
Copy link
Contributor

LGTM, left some comments, mostly about readability/searchability.

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 11, 2021
@cjgillot cjgillot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 11, 2021
@petrochenkov
Copy link
Contributor

Three remaining questions about passing heavy structures by value - #87044 (comment), #87044 (comment), #87044 (comment).

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 11, 2021
@petrochenkov
Copy link
Contributor

r=me with commits starting from c683196 squashed.

@cjgillot
Copy link
Contributor Author

@bors r=petrochenkov

@bors
Copy link
Contributor

bors commented Jul 13, 2021

📌 Commit 616ce3c has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 13, 2021
@cjgillot
Copy link
Contributor Author

The perf results are globally green with ~1% improvements, except an isolated regression on deeply-nested-async.

@cjgillot cjgillot removed the perf-regression Performance regression. label Jul 13, 2021
@bors
Copy link
Contributor

bors commented Jul 13, 2021

⌛ Testing commit 616ce3c with merge c7d6bcc...

@bors
Copy link
Contributor

bors commented Jul 14, 2021

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing c7d6bcc to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 14, 2021
@bors bors merged commit c7d6bcc into rust-lang:master Jul 14, 2021
@rustbot rustbot added this to the 1.55.0 milestone Jul 14, 2021
This was referenced Jul 14, 2021
Merged
Merged
Merged
@cjgillot cjgillot deleted the expnhash branch July 14, 2021 09:42
@albertlarsan68 albertlarsan68 mentioned this pull request Dec 13, 2022
Closed
@petrochenkov petrochenkov mentioned this pull request Jun 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrochenkov petrochenkov petrochenkov left review comments

Assignees

@petrochenkov petrochenkov

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.55.0
Development

Successfully merging this pull request may close these issues.
6 participants
@cjgillot @petrochenkov @rust-timer @bors @rust-highfive @rustbot