Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derive Copy for VarianceDiagInfo #86670

Merged
merged 1 commit into from
Jun 29, 2021
Merged

Conversation

Aaron1011
Copy link
Member

No description provided.

@rust-highfive
Copy link
Collaborator

r? @davidtwco

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 27, 2021
@Aaron1011
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 27, 2021
@bors
Copy link
Contributor

bors commented Jun 27, 2021

⌛ Trying commit 4be38d2 with merge 242d9f0318ecad35ad4e410f82bae32fb62fe3d0...

@Aaron1011 Aaron1011 changed the title Derive Copy for `VarianceDiagInfo1 Derive Copy for VarianceDiagInfo Jun 27, 2021
@bors
Copy link
Contributor

bors commented Jun 27, 2021

☀️ Try build successful - checks-actions
Build commit: 242d9f0318ecad35ad4e410f82bae32fb62fe3d0 (242d9f0318ecad35ad4e410f82bae32fb62fe3d0)

@rust-timer
Copy link
Collaborator

Queued 242d9f0318ecad35ad4e410f82bae32fb62fe3d0 with parent 543ab99, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (242d9f0318ecad35ad4e410f82bae32fb62fe3d0): comparison url.

Summary: This change led to significant improvements 🎉 in compiler performance.

  • Moderate improvement in instruction counts (up to -4.8% on full builds of wg-grammar-check)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbot
Copy link
Collaborator

rustbot commented Jun 27, 2021

Error: Label perf-regression can only be set by Rust team members

Please let @rust-lang/release know if you're having trouble with this bot.

@Aaron1011
Copy link
Member Author

The performance improvements suggest that it might be worth trying to revive #72409 in some form - the compiler shouldn't need a #[derive(Copy)] to perform these kinds of optimizations.

@klensy
Copy link
Contributor

klensy commented Jun 27, 2021

Improvement in one test, but max-rss is red in most cases (given that max-rss bench results accuracy not high and can be scattered up and down).

Copy link
Member

@davidtwco davidtwco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, r=me if this is something you wanted to land and not just an experiment to check #72409's viability.

@Aaron1011
Copy link
Member Author

This is intended to fix the performance regression caused by adding the variance diag info.

@bors r=davidtwco

@bors
Copy link
Contributor

bors commented Jun 28, 2021

📌 Commit 4be38d2 has been approved by davidtwco

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 28, 2021
@bors
Copy link
Contributor

bors commented Jun 28, 2021

⌛ Testing commit 4be38d2 with merge 71a97b28ab15a7ff758e748e9518088f6adfa076...

@bors
Copy link
Contributor

bors commented Jun 28, 2021

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 28, 2021
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@Aaron1011
Copy link
Member Author

@bors retry

@bors bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 28, 2021
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jun 28, 2021
@JohnTitor JohnTitor removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 28, 2021
@bors
Copy link
Contributor

bors commented Jun 29, 2021

⌛ Testing commit 4be38d2 with merge 47b2f15...

@bors
Copy link
Contributor

bors commented Jun 29, 2021

☀️ Test successful - checks-actions
Approved by: davidtwco
Pushing 47b2f15 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 29, 2021
@bors bors merged commit 47b2f15 into rust-lang:master Jun 29, 2021
@rustbot rustbot added this to the 1.55.0 milestone Jun 29, 2021
@pnkfelix
Copy link
Member

pnkfelix commented Jun 30, 2021

Thanks @Aaron1011 ! End results look good to me. (Original regressing results here for reference.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants