Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Miri #86323

Merged
merged 1 commit into from Jun 15, 2021
Merged

Update Miri #86323

merged 1 commit into from Jun 15, 2021

Conversation

ghost
Copy link

@ghost ghost commented Jun 15, 2021 •
edited by ghost
Loading

Fixes #86316
Fixes #86261

r? @RalfJung

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 15, 2021
@ghost
Copy link
Author

ghost commented Jun 15, 2021

Should I wait for rust-lang/miri#1833 to land and include that PR? That way maybe we can also close #86261 with this PR.

@RalfJung
Copy link
Member

Yeah, including that PR makes sense.

@RalfJung
Copy link
Member

@bors r+ p=1

@bors
Copy link
Contributor

bors commented Jun 15, 2021

📌 Commit 2ee693c has been approved by RalfJung

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 15, 2021
@bors
Copy link
Contributor

bors commented Jun 15, 2021

⌛ Testing commit 2ee693c with merge 246571a...

@bors
Copy link
Contributor

bors commented Jun 15, 2021

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing 246571a to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 15, 2021
@bors bors merged commit 246571a into rust-lang:master Jun 15, 2021
@rustbot rustbot added this to the 1.55.0 milestone Jun 15, 2021
@rust-highfive
Copy link
Collaborator

📣 Toolstate changed by #86323!

Tested on commit 246571a.
Direct link to PR: #86323

🎉 miri on windows: test-fail → test-pass (cc @eddyb @RalfJung @oli-obk).
🎉 miri on linux: test-fail → test-pass (cc @eddyb @RalfJung @oli-obk).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Jun 15, 2021
@rust-highfive
📣 Toolstate changed by rust-lang/rust#86323!
ae7c926 
Tested on commit rust-lang/rust@246571a.
Direct link to PR: <rust-lang/rust#86323>

🎉 miri on windows: test-fail → test-pass (cc @eddyb @RalfJung @oli-obk).
🎉 miri on linux: test-fail → test-pass (cc @eddyb @RalfJung @oli-obk).
@ghost ghost deleted the miri branch June 16, 2021 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@RalfJung RalfJung

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.55.0
Development

Successfully merging this pull request may close these issues.

miri no longer builds after rust-lang/rust#86275 Nightly with MIRI and FFI
4 participants
@rust-highfive @RalfJung @bors @rustbot