Diagnose use sanitizers with crt-static #85559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @lcnr (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
I am not able to review any PRs in the near future. r? @nagisa |
nagisa
reviewed
May 26, 2021
| @@ -1512,6 +1512,17 @@ fn validate_commandline_args_with_session_available(sess: &Session) { | |||
| if let (Some(first), Some(second)) = (sanitizer_iter.next(), sanitizer_iter.next()) { | |||
| sess.err(&format!("`-Zsanitizer={}` is incompatible with `-Zsanitizer={}`", first, second)); | |||
| } | |||
|
|
|||
| // Cannot enable crt-static with sanitizers on Linux | |||
| for sanitizer in sess.opts.debugging_opts.sanitizer.into_iter() { | |||
There was a problem hiding this comment.
Instead of emitting an error message for each of the enabled sanitizers, could we emit a single message that covered all of the enabled sanitizers in a single diagnostic?
12101111
force-pushed
the
sanitizer-crt-static
branch
from
80b6083
to
4376484
Compare
|
@bors r+ |
|
📌 Commit 4376484 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #85459