-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 13 pull requests #85325
Rollup of 13 pull requests #85325
Commits on May 4, 2021
-
New rustdoc lint to respect -Dwarnings correctly
This adds a new lint to `rustc` that is used in rustdoc when a code block is empty or cannot be parsed as valid Rust code. Previously this was unconditionally a warning. As such some documentation comments were (unknowingly) abusing this to pass despite the `-Dwarnings` used when compiling `rustc`, this should not be the case anymore.
Configuration menu - View commit details
-
Copy full SHA for 2c13c68 - Browse repository at this point
Copy the full SHA 2c13c68View commit details -
Add back missing help for ignore blocks
This also gives a better error message when a span is missing.
Configuration menu - View commit details
-
Copy full SHA for 04de637 - Browse repository at this point
Copy the full SHA 04de637View commit details -
Configuration menu - View commit details
-
Copy full SHA for b92723b - Browse repository at this point
Copy the full SHA b92723bView commit details -
- Simplify boolean expression - Give an example of invalid syntax - Remove explanation of why code block is text
Configuration menu - View commit details
-
Copy full SHA for 0511ba4 - Browse repository at this point
Copy the full SHA 0511ba4View commit details
Commits on May 5, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 0aa2844 - Browse repository at this point
Copy the full SHA 0aa2844View commit details
Commits on May 8, 2021
-
Configuration menu - View commit details
-
Copy full SHA for a8b49ff - Browse repository at this point
Copy the full SHA a8b49ffView commit details
Commits on May 12, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 3c06f00 - Browse repository at this point
Copy the full SHA 3c06f00View commit details -
dbg macro: Discuss use in tests, and slightly clarify
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Configuration menu - View commit details
-
Copy full SHA for a173518 - Browse repository at this point
Copy the full SHA a173518View commit details
Commits on May 13, 2021
-
Spanview needs the relevant body_span used for coverage
The coverage body_span doesn't always match the function body_span.
Configuration menu - View commit details
-
Copy full SHA for e354cca - Browse repository at this point
Copy the full SHA e354ccaView commit details -
Simplified body_span and filtered span code
Some code cleanup extracted from future (but unfinished) commit to fix coverage in attr macro functions.
Configuration menu - View commit details
-
Copy full SHA for 31f523f - Browse repository at this point
Copy the full SHA 31f523fView commit details -
coverageinfo
query needs to use the same MIR as codegenI ran into an error trying to fix dead block coverage and realized the `coverageinfo` query is getting a different MIR compared to the codegenned MIR, which can sometimes be a problem during mapgen. I changed that query to use the `InstandeDef` (which includes the generic parameter substitutions, prosibly specific to const params) instead of the `DefId` (without unknown/default const substitutions).
Configuration menu - View commit details
-
Copy full SHA for aed8ef5 - Browse repository at this point
Copy the full SHA aed8ef5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0cee527 - Browse repository at this point
Copy the full SHA 0cee527View commit details -
Configuration menu - View commit details
-
Copy full SHA for 267450a - Browse repository at this point
Copy the full SHA 267450aView commit details -
swap function order for better read flow
When having the order ``` foo.bar(); // we can now use this method since i32 implements the Foo trait [...] impl Foo for i32 ``` the `// we can now use this method` comment is less clear to me.
Configuration menu - View commit details
-
Copy full SHA for a56d0e2 - Browse repository at this point
Copy the full SHA a56d0e2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 812994e - Browse repository at this point
Copy the full SHA 812994eView commit details -
Change "etc." to "and similar"
Co-authored-by: Josh Triplett <josh@joshtriplett.org>
Configuration menu - View commit details
-
Copy full SHA for b36a316 - Browse repository at this point
Copy the full SHA b36a316View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4672520 - Browse repository at this point
Copy the full SHA 4672520View commit details
Commits on May 14, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 34055a9 - Browse repository at this point
Copy the full SHA 34055a9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 27defcd - Browse repository at this point
Copy the full SHA 27defcdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 766de3a - Browse repository at this point
Copy the full SHA 766de3aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0c02338 - Browse repository at this point
Copy the full SHA 0c02338View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7eb95cd - Browse repository at this point
Copy the full SHA 7eb95cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for dfc8b60 - Browse repository at this point
Copy the full SHA dfc8b60View commit details
Commits on May 15, 2021
-
Configuration menu - View commit details
-
Copy full SHA for ccabd4e - Browse repository at this point
Copy the full SHA ccabd4eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 18b7c0a - Browse repository at this point
Copy the full SHA 18b7c0aView commit details -
Rollup merge of rust-lang#84461 - jyn514:remove-strip-item, r=Guillau…
…meGomez rustdoc: Remove unnecessary `StripItem` wrapper
Configuration menu - View commit details
-
Copy full SHA for b567b20 - Browse repository at this point
Copy the full SHA b567b20View commit details -
Rollup merge of rust-lang#84587 - jyn514:rustdoc-lint-block, r=CraftS…
…pider rustdoc: Make "rust code block is empty" and "could not parse code block" warnings a lint (`INVALID_RUST_CODEBLOCKS`) Fixes rust-lang#79792. This already went through FCP in rust-lang#79816, so it only needs final review. This is mostly a rebase of rust-lang#79816 - thank you `@poliorcetics` for doing most of the work!
Configuration menu - View commit details
-
Copy full SHA for 3c9ea47 - Browse repository at this point
Copy the full SHA 3c9ea47View commit details -
Rollup merge of rust-lang#85067 - Stupremee:minimize-amount-of-fake-d…
…efids, r=jyn514,GuillaumeGomez Minimize amount of fake `DefId`s used in rustdoc Follow up from rust-lang#84707, which minimizes the amount of fake defids to the smallest amount possible. Every `FakeDefId` that is now used in the rustdoc library must be preserved and can not be replaced with a normal `DefId`.
Configuration menu - View commit details
-
Copy full SHA for a94e23e - Browse repository at this point
Copy the full SHA a94e23eView commit details -
Rollup merge of rust-lang#85207 - andrewhalle:typo-rootseparator, r=k…
…ennytm Fix typo in comment missing space in "rootseparator"
Configuration menu - View commit details
-
Copy full SHA for 4b90d82 - Browse repository at this point
Copy the full SHA 4b90d82View commit details -
Rollup merge of rust-lang#85215 - richkadel:ice-fixes-minus-dead-bloc…
…ks, r=tmandry coverage bug fixes and some refactoring This replaces the relevant commits (2 and 3) from PR rust-lang#85082, and also corrects an error querying for coverageinfo. 1. `coverageinfo` query needs to use the same MIR as codegen I ran into an error trying to fix dead block coverage and realized the `coverageinfo` query is getting a different MIR compared to the codegenned MIR, which can sometimes be a problem during mapgen. I changed that query to use the `InstandeDef` (which includes the generic parameter substitutions, prosibly specific to const params) instead of the `DefId` (without unknown/default const substitutions). 2. Simplified body_span and filtered span code Some code cleanup extracted from future (but unfinished) commit to fix coverage in attr macro functions. 3. Spanview needs the relevant body_span used for coverage The coverage body_span doesn't always match the function body_span. r? `@tmandry`
Configuration menu - View commit details
-
Copy full SHA for 8c381df - Browse repository at this point
Copy the full SHA 8c381dfView commit details -
Rollup merge of rust-lang#85221 - ijackson:dbg-doc-re-tests, r=joshtr…
…iplett dbg macro: Discuss use in tests, and slightly clarify As discussed in a tangent in rust-lang#82778. I chose to use [semantic newlines](https://rhodesmill.org/brandon/2012/one-sentence-per-line/) in the source text but I don't mind reformatting it.
Configuration menu - View commit details
-
Copy full SHA for f805b2e - Browse repository at this point
Copy the full SHA f805b2eView commit details -
Rollup merge of rust-lang#85246 - ayushmishra2005:minor-reactoring, r…
…=petrochenkov Miner code formatting
Configuration menu - View commit details
-
Copy full SHA for 7d3cbfa - Browse repository at this point
Copy the full SHA 7d3cbfaView commit details -
Rollup merge of rust-lang#85253 - RafaelKr:patch-1, r=varkor
swap function order for better read flow I was reading this error message for the first time. I was a little bit confused when reading that part: ``` foo.bar(); // we can now use this method since i32 implements the Foo trait ``` At the time I was reading `// we can now use this method` I wasn't sure why. It only made sense when reading on. So swapping these parts results in a better read flow.
Configuration menu - View commit details
-
Copy full SHA for b9b2b12 - Browse repository at this point
Copy the full SHA b9b2b12View commit details -
Rollup merge of rust-lang#85256 - GuillaumeGomez:fix-implementors-dis…
…play, r=notriddle Fix display for "implementors" section Just saw this problem when going through docs: ![Screenshot from 2021-05-13 15-20-52](https://user-images.githubusercontent.com/3050060/118131978-766fc180-b3ff-11eb-86a8-7f6d22afa675.png) This fix puts it back to normal: ![Screenshot from 2021-05-13 15-23-29](https://user-images.githubusercontent.com/3050060/118132006-7e2f6600-b3ff-11eb-9985-025a7b7c5216.png) You can see it on the `TryFrom` page for example. r? `@Nemo157`
Configuration menu - View commit details
-
Copy full SHA for 85d71a8 - Browse repository at this point
Copy the full SHA 85d71a8View commit details -
Rollup merge of rust-lang#85268 - camelid:real-name, r=Mark-Simulacrum
Use my real name
Configuration menu - View commit details
-
Copy full SHA for 3d4ca49 - Browse repository at this point
Copy the full SHA 3d4ca49View commit details -
Rollup merge of rust-lang#85278 - ayushmishra2005:code-refactoring, r…
…=jackh726 Improve match statements
Configuration menu - View commit details
-
Copy full SHA for 88b372e - Browse repository at this point
Copy the full SHA 88b372eView commit details -
Rollup merge of rust-lang#85289 - GuillaumeGomez:fix-toggle-position-…
…mobile, r=jsha Fix toggle position on mobile Before: ![Screenshot from 2021-05-14 14-21-27](https://user-images.githubusercontent.com/3050060/118276475-fe210300-b4c7-11eb-94f8-4e2a4e10d91e.png) ![Screenshot from 2021-05-14 14-21-30](https://user-images.githubusercontent.com/3050060/118276479-feb99980-b4c7-11eb-85db-40e9df6e9abd.png) After: ![Screenshot from 2021-05-14 15-16-54](https://user-images.githubusercontent.com/3050060/118276494-0416e400-b4c8-11eb-9479-d447928cfa62.png) ![Screenshot from 2021-05-14 15-16-59](https://user-images.githubusercontent.com/3050060/118276498-0416e400-b4c8-11eb-99f6-894276c62dfc.png) r? `@jsha`
Configuration menu - View commit details
-
Copy full SHA for 8f0ea10 - Browse repository at this point
Copy the full SHA 8f0ea10View commit details -
Rollup merge of rust-lang#85323 - GuillaumeGomez:fix-eslint-errors, r…
…=jsha Fix eslint errors I cherry-picked the two non-CI commits from rust-lang#85285. r? `@jsha`
Configuration menu - View commit details
-
Copy full SHA for 53c9f91 - Browse repository at this point
Copy the full SHA 53c9f91View commit details