Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coverage bug fixes and some refactoring #85215

Merged
merged 3 commits into from
May 15, 2021
Merged

coverage bug fixes and some refactoring #85215

merged 3 commits into from
May 15, 2021

Commits on May 13, 2021

  1. Spanview needs the relevant body_span used for coverage 

    The coverage body_span doesn't always match the function body_span.
    @richkadel
    richkadel committed May 13, 2021
    Configuration menu
    Copy the full SHA
    e354cca View commit details
    Browse the repository at this point in the history

  2. Simplified body_span and filtered span code 

    Some code cleanup extracted from future (but unfinished) commit to fix
coverage in attr macro functions.
    @richkadel
    richkadel committed May 13, 2021
    Configuration menu
    Copy the full SHA
    31f523f View commit details
    Browse the repository at this point in the history

  3. coverageinfo query needs to use the same MIR as codegen 

    I ran into an error trying to fix dead block coverage and realized the
`coverageinfo` query is getting a different MIR compared to the
codegenned MIR, which can sometimes be a problem during mapgen.

I changed that query to use the `InstandeDef` (which includes the
generic parameter substitutions, prosibly specific to const params)
instead of the `DefId` (without unknown/default const substitutions).
    @richkadel
    richkadel committed May 13, 2021
    Configuration menu
    Copy the full SHA
    aed8ef5 View commit details
    Browse the repository at this point in the history