Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slightly change wording in doc comment and fix typo in vec/mod.rs #84294

Merged
merged 1 commit into from
Apr 19, 2021
Merged

Slightly change wording in doc comment and fix typo in vec/mod.rs #84294

merged 1 commit into from
Apr 19, 2021

Conversation

WaffleLapkin
Copy link
Member

Suggested by @pickfire in #82760

@rust-highfive
Copy link
Collaborator

r? @kennytm

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 18, 2021
@jonas-schievink
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 18, 2021

📌 Commit 3ecaf57 has been approved by jonas-schievink

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 18, 2021
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Apr 18, 2021
@GuillaumeGomez
Rollup merge of rust-lang#84294 - WaffleLapkin:patch-2, r=jonas-schie…
cc3d6e5 
…vink

Slightly change wording in doc comment and fix typo in vec/mod.rs

Suggested by `@pickfire` in rust-lang#82760
@GuillaumeGomez GuillaumeGomez mentioned this pull request Apr 18, 2021
Closed
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Apr 18, 2021
@GuillaumeGomez
Rollup merge of rust-lang#84294 - WaffleLapkin:patch-2, r=jonas-schie…
9ef82b6 
…vink

Slightly change wording in doc comment and fix typo in vec/mod.rs

Suggested by ``@pickfire`` in rust-lang#82760
@GuillaumeGomez GuillaumeGomez mentioned this pull request Apr 18, 2021
Closed
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Apr 18, 2021
@GuillaumeGomez
Rollup merge of rust-lang#84294 - WaffleLapkin:patch-2, r=jonas-schie…
8efc394 
…vink

Slightly change wording in doc comment and fix typo in vec/mod.rs

Suggested by ```@pickfire``` in rust-lang#82760
@GuillaumeGomez GuillaumeGomez mentioned this pull request Apr 18, 2021
Closed
@bors
Copy link
Contributor

bors commented Apr 19, 2021

⌛ Testing commit 3ecaf57 with merge c3b3d830f673e7dfb8425b78c67e1578a74e1140...

@rust-log-analyzer
Copy link
Collaborator

The job dist-aarch64-apple failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
      Memory: 14 GB
      Boot ROM Version: VMW71.00V.13989454.B64.1906190538
      Apple ROM Info: [MS_VM_CERT/SHA1/27d66596a61c48dd3dc7216fd715126e33f59ae7]Welcome to the Virtual Machine
      SMC Version (system): 2.8f0
      Serial Number (system): VMSsHXbKZWuT

hw.ncpu: 3
hw.byteorder: 1234
hw.memsize: 15032385536
---
[  8%] Building CXX object Common/CMakeFiles/lldCommon.dir/Args.cpp.o
error: error: Connection to server timed outConnection to server timed out

error: Connection to server timed out
make[2]: *** [Common/CMakeFiles/lldCommon.dir/Args.cpp.o] Error 2
make[2]: *** [lib/Core/CMakeFiles/lldCore.dir/Error.cpp.o] Error 2
make[2]: *** Waiting for unfinished jobs....
make[2]: *** [lib/Core/CMakeFiles/lldCore.dir/DefinedAtom.cpp.o] Error 2
make[1]: *** [Common/CMakeFiles/lldCommon.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
make[1]: *** [lib/Core/CMakeFiles/lldCore.dir/all] Error 2
make: *** [all] Error 2
command did not execute successfully, got: exit code: 2


build script failed, must exit now', /Users/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/cmake-0.1.44/src/lib.rs:885:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
failed to run: /Users/runner/work/rust/rust/build/bootstrap/debug/bootstrap dist --stage 2
Build completed unsuccessfully in 0:39:20

@bors
Copy link
Contributor

bors commented Apr 19, 2021

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 19, 2021
@pickfire
Copy link
Contributor

Seemed like spurious error, need to retry.

@jonas-schievink
Copy link
Contributor

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 19, 2021
@bors
Copy link
Contributor

bors commented Apr 19, 2021

⌛ Testing commit 3ecaf57 with merge 41f0e13...

@bors
Copy link
Contributor

bors commented Apr 19, 2021

☀️ Test successful - checks-actions
Approved by: jonas-schievink
Pushing 41f0e13 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 19, 2021
@bors bors merged commit 41f0e13 into rust-lang:master Apr 19, 2021
@rustbot rustbot added this to the 1.53.0 milestone Apr 19, 2021
@WaffleLapkin WaffleLapkin deleted the patch-2 branch May 13, 2021 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kennytm kennytm

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.53.0
Development

Successfully merging this pull request may close these issues.
8 participants
@WaffleLapkin @rust-highfive @jonas-schievink @bors @rust-log-analyzer @pickfire @kennytm @rustbot