Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: Hide item contents, not items #83337

Merged
merged 16 commits into from
Apr 16, 2021
Merged

Commits on Apr 12, 2021

  1. Configuration menu
    Copy the full SHA
    c96f86d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    71c52ac View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f146b97 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    173cbec View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    256e594 View commit details
    Browse the repository at this point in the history
  6. Update src/librustdoc/html/render/print_item.rs

    Co-authored-by: Joshua Nelson <joshua@yottadb.com>
    Manishearth and Joshua Nelson committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    e2f59f4 View commit details
    Browse the repository at this point in the history
  7. Update src/librustdoc/html/render/print_item.rs

    Co-authored-by: Joshua Nelson <joshua@yottadb.com>
    Manishearth and Joshua Nelson committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    846a4e9 View commit details
    Browse the repository at this point in the history
  8. Improve CSS for "hide contents, not items"

    Introduce a first use of the `<details>` and `<summary>` tags as
    replacements for the JS-built toggles. I think this has the potential to
    replace all the JS toggles and generally clean up the JS, CSS, and HTML.
    
    Split rendering of attributes into two cases: in the case where they are
    rendered as descendents of a `<pre>` tag, where they use indent spaces and
    newlines for formatting, matching their surrounding markup. In the case
    where they are rendered as descendants of a `<code>` tag, they are
    rendered as `<div>`. This let me clean up some fragile CSS that was
    adjusting the margin-left of attributes depending on context.
    
    Remove toggles for attributes. With the ALLOWED_ATTRIBUTES filter, it's
    rare for an item to have more than one attribute, so hiding attributes
    behind a toggle doesn't save any screen space in the common case.
    
    Fix a couple of invocations of `matches!` that didn't compile on my
    machine.
    
    Fix a boolean for the JS `createToggle` call that was causing
    "Expand description" to show up spuriously on already-expanded
    descriptions.
    
    Add JS for auto-hide settings and hide all / show all.
    
    Remove a z-index property and some font color tweaks made unnecessary
    by the <details> toggles.
    
    Add CSS for the <details> toggles.
    jsha authored and Manishearth committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    def144c View commit details
    Browse the repository at this point in the history
  9. Add css classes

    Manishearth committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    8e9882d View commit details
    Browse the repository at this point in the history
  10. should_hide_fields > 12

    Manishearth committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    01afa07 View commit details
    Browse the repository at this point in the history
  11. Add test for item hiding

    Manishearth committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    b40bd5a View commit details
    Browse the repository at this point in the history
  12. Wrap toggle_open()

    Manishearth committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    97cd30d View commit details
    Browse the repository at this point in the history
  13. & -> &&

    Manishearth committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    05d1e72 View commit details
    Browse the repository at this point in the history
  14. Move color to themes

    Manishearth committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    942ed31 View commit details
    Browse the repository at this point in the history
  15. +ignore-tidy-filelength

    Manishearth committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    5c2820b View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2021

  1. Update attribute tests

    Manishearth committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    55b2944 View commit details
    Browse the repository at this point in the history