-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustdoc: Hide item contents, not items #83337
Merged
Merged
Commits on Apr 12, 2021
-
Configuration menu - View commit details
-
Copy full SHA for c96f86d - Browse repository at this point
Copy the full SHA c96f86dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 71c52ac - Browse repository at this point
Copy the full SHA 71c52acView commit details -
Configuration menu - View commit details
-
Copy full SHA for f146b97 - Browse repository at this point
Copy the full SHA f146b97View commit details -
Configuration menu - View commit details
-
Copy full SHA for 173cbec - Browse repository at this point
Copy the full SHA 173cbecView commit details -
Configuration menu - View commit details
-
Copy full SHA for 256e594 - Browse repository at this point
Copy the full SHA 256e594View commit details -
Update src/librustdoc/html/render/print_item.rs
Co-authored-by: Joshua Nelson <joshua@yottadb.com>
Configuration menu - View commit details
-
Copy full SHA for e2f59f4 - Browse repository at this point
Copy the full SHA e2f59f4View commit details -
Update src/librustdoc/html/render/print_item.rs
Co-authored-by: Joshua Nelson <joshua@yottadb.com>
Configuration menu - View commit details
-
Copy full SHA for 846a4e9 - Browse repository at this point
Copy the full SHA 846a4e9View commit details -
Improve CSS for "hide contents, not items"
Introduce a first use of the `<details>` and `<summary>` tags as replacements for the JS-built toggles. I think this has the potential to replace all the JS toggles and generally clean up the JS, CSS, and HTML. Split rendering of attributes into two cases: in the case where they are rendered as descendents of a `<pre>` tag, where they use indent spaces and newlines for formatting, matching their surrounding markup. In the case where they are rendered as descendants of a `<code>` tag, they are rendered as `<div>`. This let me clean up some fragile CSS that was adjusting the margin-left of attributes depending on context. Remove toggles for attributes. With the ALLOWED_ATTRIBUTES filter, it's rare for an item to have more than one attribute, so hiding attributes behind a toggle doesn't save any screen space in the common case. Fix a couple of invocations of `matches!` that didn't compile on my machine. Fix a boolean for the JS `createToggle` call that was causing "Expand description" to show up spuriously on already-expanded descriptions. Add JS for auto-hide settings and hide all / show all. Remove a z-index property and some font color tweaks made unnecessary by the <details> toggles. Add CSS for the <details> toggles.
Configuration menu - View commit details
-
Copy full SHA for def144c - Browse repository at this point
Copy the full SHA def144cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e9882d - Browse repository at this point
Copy the full SHA 8e9882dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 01afa07 - Browse repository at this point
Copy the full SHA 01afa07View commit details -
Configuration menu - View commit details
-
Copy full SHA for b40bd5a - Browse repository at this point
Copy the full SHA b40bd5aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 97cd30d - Browse repository at this point
Copy the full SHA 97cd30dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 05d1e72 - Browse repository at this point
Copy the full SHA 05d1e72View commit details -
Configuration menu - View commit details
-
Copy full SHA for 942ed31 - Browse repository at this point
Copy the full SHA 942ed31View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5c2820b - Browse repository at this point
Copy the full SHA 5c2820bView commit details
Commits on Apr 13, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 55b2944 - Browse repository at this point
Copy the full SHA 55b2944View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.