Parallelize tidy

[the8472]

Split off from #81833

While that PR brings wall time of x.py test tidy down to 0m2.847s adding this one on top should bring it down to 0m1.673s.

r? @Mark-Simulacrum

Previous concerns can be found at #81833 (comment) and #81833 (comment)

[Mark-Simulacrum]

I think I'd be happy to merge with #81833 (comment), presuming that seems reasonable to you. I think for the parallelism in main I'm not too worried, it should continue to be relatively straightforward to add more passes.

[the8472]

@rustbot label -S-waiting-on-author +S-waiting-on-review

[Mark-Simulacrum]

@bors r+ rollup=iffy

Thanks. I think this looks good to me, and we can always back it out if it causes trouble.

[bors]

📌 Commit 5e306f5e0106d9e2862afd4369a88c746c6c5ce6 has been approved by Mark-Simulacrum

[bors]

☔ The latest upstream changes (presumably #82654) made this pull request unmergeable. Please resolve the merge conflicts.

[the8472]

@rustbot label -S-waiting-on-author +S-waiting-on-bors

[the8472]

@Mark-Simulacrum looks like the approval got lost

[shengsheng]

@rustbot label -S-waiting-on-bors +S-waiting-on-review

[Mark-Simulacrum]

@bors r+

[bors]

📌 Commit 45d953d8190b68556af42b5483bbf5bb9f613104 has been approved by Mark-Simulacrum

[JohnTitor]

@bors retry

[Mark-Simulacrum]

@bors retry

[bors]

⌛ Testing commit e312c41435d6a2b701f73102ea6272789319a031 with merge 1d0beb04badf38ce3fec6df02b5c32663571b07d...

[bors]

💔 Test failed - checks-actions

[the8472]

I did forget to update one of the stub functions for windows, that should be fixed now. x.py doesn't have any magic to at least run check for all platforms, does it?

[Mark-Simulacrum]

x.py check --target foo may work without too much effort to cross-compile, but "all platforms" isn't really a well defined set (and I'm not sure if we've pulled away from C / native dependencies enough to not need a linker even for check).

@bors r+

[bors]

📌 Commit 0513ba4 has been approved by Mark-Simulacrum

[the8472]

Nope, fails immediately

$ ./x.py check --target x86_64-pc-windows-msvc
Updating only changed submodules
Submodules updated in 0.02 seconds
    Finished dev [unoptimized + debuginfo] target(s) in 0.13s
thread 'main' panicked at '
cmake does not support Visual Studio generators.

This is likely due to it being an msys/cygwin build of cmake,
rather than the required windows version, built using MinGW
or Visual Studio.

Maybe some wine-based docker build could work.

[Mark-Simulacrum]

I know we run the mingw one on the mingw-check builder (which is linux host), to try to get some coverage.

[bors]

⌛ Testing commit 0513ba4 with merge f98135b...

[bors]

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing f98135b to master...