Query-ify needs_gdb_debug_scripts_section

[Aaron1011]

This ensures that a codegen unit DepNode does not have a direct
dependency on the crate's attributes

[rust-highfive]

r? @ecstatic-morse

(rust-highfive has picked a reviewer for you, use r? to override)

[Aaron1011]

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

[bors]

⌛ Trying commit ecde548133cec4a4a8ca0b1c9ff382abc44cfcd5 with merge a3c8e320ca13e4cc1253c85b7cfbaf98a455560f...

[bors]

☀️ Try build successful - checks-actions
Build commit: a3c8e320ca13e4cc1253c85b7cfbaf98a455560f (a3c8e320ca13e4cc1253c85b7cfbaf98a455560f)

[rust-timer]

Queued a3c8e320ca13e4cc1253c85b7cfbaf98a455560f with parent bc39d4d, future comparison URL.

@rustbot label: +S-waiting-on-perf

[rust-timer]

Finished benchmarking try commit (a3c8e320ca13e4cc1253c85b7cfbaf98a455560f): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

[Aaron1011]

r? @estebank

[bors]

☔ The latest upstream changes (presumably #81660) made this pull request unmergeable. Please resolve the merge conflicts.

[Aaron1011]

@estebank Are there any changes that you'd like me to make?

[Aaron1011]

PR #79519 may have reduced the need for this:

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[bors]

⌛ Trying commit 3667b1d with merge c071c3594f1d95ba283af8252d803e1b74690fe0...

[bors]

☀️ Try build successful - checks-actions
Build commit: c071c3594f1d95ba283af8252d803e1b74690fe0 (c071c3594f1d95ba283af8252d803e1b74690fe0)

[rust-timer]

Queued c071c3594f1d95ba283af8252d803e1b74690fe0 with parent f24ce9b, future comparison URL.

[rust-timer]

Finished benchmarking try commit (c071c3594f1d95ba283af8252d803e1b74690fe0): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

[estebank]

The performance improvements seem to have gone away.

r=me, if you still want to land it

[Dylan-DPC-zz]

@Aaron1011 any updates?

[Aaron1011]

Without any net performance improvement, landing this would probably just be unnecessary churn.