resolve: Scope visiting doesn't need an Ident
#80782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
petrochenkov
commented
Jan 7, 2021
| ) | ||
| | Res::SelfTy(..)), | ||
| ) | Res::SelfTy(..) | ||
| ), |
There was a problem hiding this comment.
| self.r.hygienic_lexical_parent(search_module, &mut span_data.ctxt), | ||
| break | ||
| ); | ||
| ident.span = span_data.span(); |
There was a problem hiding this comment.
This will go away in #80765 which reuses visit_scopes for this logic.
| }; | ||
| ident.span = span_data.span(); |
There was a problem hiding this comment.
This code is not yet refactored to use visit_scopes, but it should also go away eventually.
|
@bors r+ |
|
📌 Commit 3ff866e has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 3ff866e with merge 10b96fdd6c1f290c822c5b49339678e12336368e... |
|
💥 Test timed out |
bors
added
S-waiting-on-review
|
@bors retry |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolution scope visitor (
fn visit_scopes) currently takes anIdentparameter, but it doesn't need a full identifier, or even its span, it only needs theSyntaxContextpart.The
SyntaxContextpart is necessary because scope visitor has to jump to macro definition sites, so it has to be directed by macro expansion information somehow.I think it's clearer to pass only the necessary part.
Yes, usually visiting happens as a part of an identifier resolution, but in cases like collecting traits in scope (#80765) or collecting typo suggestions that's not the case.
r? @matthewjasper