-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 3 pull requests #80024
Merged
Merged
Rollup of 3 pull requests #80024
Commits on Dec 10, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 9cf2516 - Browse repository at this point
Copy the full SHA 9cf2516View commit details
Commits on Dec 11, 2020
-
Configuration menu - View commit details
-
Copy full SHA for d986924 - Browse repository at this point
Copy the full SHA d986924View commit details -
Configuration menu - View commit details
-
Copy full SHA for ebfea62 - Browse repository at this point
Copy the full SHA ebfea62View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9c36491 - Browse repository at this point
Copy the full SHA 9c36491View commit details
Commits on Dec 13, 2020
-
Configuration menu - View commit details
-
Copy full SHA for ec0f1d7 - Browse repository at this point
Copy the full SHA ec0f1d7View commit details
Commits on Dec 14, 2020
-
Rollup merge of rust-lang#79918 - woodruffw-forks:ww/doc-initializer-…
…side-effects, r=dtolnay doc(array,vec): add notes about side effects when empty-initializing Copying some context from a conversation in the Rust discord: * Both `vec![T; 0]` and `[T; 0]` are syntactically valid, and produce empty containers of their respective types * Both *also* have side effects: ```rust fn side_effect() -> String { println!("side effect!"); "foo".into() } fn main() { println!("before!"); let x = vec![side_effect(); 0]; let y = [side_effect(); 0]; println!("{:?}, {:?}", x, y); } ``` produces: ``` before! side effect! side effect! [], [] ``` This PR just adds two small notes to each's documentation, warning users that side effects can occur. I've also submitted a clippy proposal: rust-lang/rust-clippy#6439
Configuration menu - View commit details
-
Copy full SHA for 5d8b2a5 - Browse repository at this point
Copy the full SHA 5d8b2a5View commit details -
Rollup merge of rust-lang#79936 - GuillaumeGomez:mobile-fix-item-name…
…, r=Nemo157,jyn514 Fix item name display on mobile Fixes rust-lang/docs.rs#1200 ![Screenshot_20201211-200931](https://user-images.githubusercontent.com/3050060/101944457-0c06eb00-3bed-11eb-8f63-a4d4fd3cbb56.jpg) ![Screenshot_20201211-195846](https://user-images.githubusercontent.com/3050060/101944459-0d381800-3bed-11eb-91ff-815a2af7ca72.jpg) cc `@jyn514` r? `@Nemo157`
Configuration menu - View commit details
-
Copy full SHA for 63e86a7 - Browse repository at this point
Copy the full SHA 63e86a7View commit details -
Rollup merge of rust-lang#80013 - poliorcetics:rustdoc-test-refactor,…
… r=jyn514 Refactor test_lang_string_parse to make it clearer Follows rust-lang#79454 (comment) A small PR made to refactor a test in rustdoc that was becoming unwieldy. ``@rustbot`` label T-rustdoc r? ``@jyn514``
Configuration menu - View commit details
-
Copy full SHA for 2169094 - Browse repository at this point
Copy the full SHA 2169094View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.