-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes reported bugs in Rust Coverage #79958
Merged
bors
merged 3 commits into
rust-lang:master
from
richkadel:llvm-coverage-counters-2.2.0
Dec 15, 2020
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
59 changes: 59 additions & 0 deletions
59
src/test/run-make-fulldeps/coverage-reports/expected_export_coverage.match_or_pattern.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| { | ||
| "data": [ | ||
| { | ||
| "files": [ | ||
| { | ||
| "filename": "../coverage/match_or_pattern.rs", | ||
| "summary": { | ||
| "functions": { | ||
| "count": 1, | ||
| "covered": 1, | ||
| "percent": 100 | ||
| }, | ||
| "instantiations": { | ||
| "count": 1, | ||
| "covered": 1, | ||
| "percent": 100 | ||
| }, | ||
| "lines": { | ||
| "count": 37, | ||
| "covered": 33, | ||
| "percent": 89.1891891891892 | ||
| }, | ||
| "regions": { | ||
| "count": 25, | ||
| "covered": 17, | ||
| "notcovered": 8, | ||
| "percent": 68 | ||
| } | ||
| } | ||
| } | ||
| ], | ||
| "totals": { | ||
| "functions": { | ||
| "count": 1, | ||
| "covered": 1, | ||
| "percent": 100 | ||
| }, | ||
| "instantiations": { | ||
| "count": 1, | ||
| "covered": 1, | ||
| "percent": 100 | ||
| }, | ||
| "lines": { | ||
| "count": 37, | ||
| "covered": 33, | ||
| "percent": 89.1891891891892 | ||
| }, | ||
| "regions": { | ||
| "count": 25, | ||
| "covered": 17, | ||
| "notcovered": 8, | ||
| "percent": 68 | ||
| } | ||
| } | ||
| } | ||
| ], | ||
| "type": "llvm.coverage.json.export", | ||
| "version": "2.0.1" | ||
| } |
50 changes: 50 additions & 0 deletions
50
src/test/run-make-fulldeps/coverage-reports/expected_show_coverage.match_or_pattern.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| 1| |#![feature(or_patterns)] | ||
| 2| | | ||
| 3| 1|fn main() { | ||
| 4| 1| // Initialize test constants in a way that cannot be determined at compile time, to ensure | ||
| 5| 1| // rustc and LLVM cannot optimize out statements (or coverage counters) downstream from | ||
| 6| 1| // dependent conditions. | ||
| 7| 1| let is_true = std::env::args().len() == 1; | ||
| 8| 1| | ||
| 9| 1| let mut a: u8 = 0; | ||
| 10| 1| let mut b: u8 = 0; | ||
| 11| 1| if is_true { | ||
| 12| 1| a = 2; | ||
| 13| 1| b = 0; | ||
| 14| 1| } | ||
| ^0 | ||
| 15| 1| match (a, b) { | ||
| 16| | // Or patterns generate MIR `SwitchInt` with multiple targets to the same `BasicBlock`. | ||
| 17| | // This test confirms a fix for Issue #79569. | ||
| 18| 0| (0 | 1, 2 | 3) => {} | ||
| 19| 1| _ => {} | ||
| 20| | } | ||
| 21| 1| if is_true { | ||
| 22| 1| a = 0; | ||
| 23| 1| b = 0; | ||
| 24| 1| } | ||
| ^0 | ||
| 25| 1| match (a, b) { | ||
| 26| 0| (0 | 1, 2 | 3) => {} | ||
| 27| 1| _ => {} | ||
| 28| | } | ||
| 29| 1| if is_true { | ||
| 30| 1| a = 2; | ||
| 31| 1| b = 2; | ||
| 32| 1| } | ||
| ^0 | ||
| 33| 1| match (a, b) { | ||
| 34| 0| (0 | 1, 2 | 3) => {} | ||
| 35| 1| _ => {} | ||
| 36| | } | ||
| 37| 1| if is_true { | ||
| 38| 1| a = 0; | ||
| 39| 1| b = 2; | ||
| 40| 1| } | ||
| ^0 | ||
| 41| 1| match (a, b) { | ||
| 42| 1| (0 | 1, 2 | 3) => {} | ||
| 43| 0| _ => {} | ||
| 44| | } | ||
| 45| 1|} | ||
|
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes in the counters file in async.txt are just another example of the non-deterministic ordering of output from
llvm-cov.These 4 lines (from 31-34) moved to line 50 when I added support for multiple
SwitchInttargets to the sameBasicBlock.The other lines moved after I updated
mod.rsto ignore MIR that starts withUnreachable.I don't think these changes should have had any real effect on the existing test results, and they don't except in this one test sample, and only in the debug counters.
The
Makefilebased test does not fail based on differences in counter files. So it's not a problem, but it would be nice to make these more deterministic in the future, perhaps by sorting the entire file before comparing.