Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "linux: try to use libc getrandom to allow interposition" #79389

Closed
wants to merge 1 commit into from
Closed

Revert "linux: try to use libc getrandom to allow interposition" #79389

wants to merge 1 commit into from

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Nov 24, 2020 •
edited
Loading

This measures the performance impact of #78785 (see #79167 (comment)).

  • Revert "Use syscall! for copy_file_range too"
  • Revert "Try weak symbols for all linux syscall! wrappers"
  • Revert "linux: try to use libc getrandom to allow interposition"

cc @cuviper
r? @ghost

@jyn514
Revert "linux: try to use libc getrandom to allow interposition"
452947c 
This measures the performance impact of that PR.

- Revert "Use syscall! for copy_file_range too"
- Revert "Try weak symbols for all linux syscall! wrappers"
- Revert "linux: try to use libc getrandom to allow interposition"
@jyn514
Copy link
Member Author

jyn514 commented Nov 24, 2020

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion

@bors
Copy link
Contributor

bors commented Nov 24, 2020

⌛ Trying commit 452947c with merge ad6794aa17ebda099a8407e9bd2089ee362fe7fb...

@m-ou-se m-ou-se added the S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. label Nov 24, 2020
@bors
Copy link
Contributor

bors commented Nov 24, 2020

☀️ Try build successful - checks-actions
Build commit: ad6794aa17ebda099a8407e9bd2089ee362fe7fb (ad6794aa17ebda099a8407e9bd2089ee362fe7fb)

@rust-timer
Copy link
Collaborator

Queued ad6794aa17ebda099a8407e9bd2089ee362fe7fb with parent 7445993, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (ad6794aa17ebda099a8407e9bd2089ee362fe7fb): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot modify labels: +S-waiting-on-review -S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 25, 2020
@jyn514 jyn514 closed this Nov 25, 2020
@jyn514 jyn514 deleted the measure-weak-perf branch November 25, 2020 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jyn514 @rust-timer @bors @m-ou-se @rustbot