Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustbuild: don't require network for vendoring libtest #79223

Closed
wants to merge 1 commit into from
Closed

rustbuild: don't require network for vendoring libtest #79223

wants to merge 1 commit into from

Conversation

Keruspe
Copy link
Contributor

@Keruspe Keruspe commented Nov 20, 2020

Fixes #79218

@Keruspe
rustbuild: don't require network for vendoring libtest
1232beb 
Fixes rust-lang#79218

Signed-off-by: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>
@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 20, 2020
@Keruspe
Copy link
Contributor Author

Keruspe commented Nov 20, 2020

Hmm, it seems --offline isn't actually offline :(

@Keruspe
Copy link
Contributor Author

Keruspe commented Nov 20, 2020

I have a better fix currently testing, as --offline isn't offline at all, still tries to sync crate.io

@Keruspe
Copy link
Contributor Author

Keruspe commented Nov 20, 2020

So, trying with --locked made the actual error pop up.

cargo vendor --offline doesn't help as it's not cargo vendor that is at fault. it's the Cargo.lock generation.

@Keruspe
Copy link
Contributor Author

Keruspe commented Nov 20, 2020

I'll reopen another PR once I actually get a working solution.

@Keruspe Keruspe closed this Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wangtt185 Wangtt185 Wangtt185 approved these changes

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

x.py dist shouldn’t require network access
4 participants
@Keruspe @rust-highfive @Wangtt185 @Mark-Simulacrum