type is too big -> values of the type are too big #79158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
lcnr
force-pushed
the
lazy-norm-coerce
branch
2 times, most recently
from
64d2f40
to
73f95cf
Compare
oli-obk
reviewed
Nov 18, 2020
|
|
||
| fn main() { | ||
| let _a: Option<<[u16; usize::MAX] as Foo>::Assoc> = None; | ||
| } |
There was a problem hiding this comment.
this needs a trailing newline
|
r=me with nit @bors rollup |
lcnr
force-pushed
the
lazy-norm-coerce
branch
from
73f95cf
to
df2aa08
Compare
|
@bors r=oli-obk |
|
📌 Commit df2aa08b909675e11765a685b83d1aa626e3729e has been approved by |
bors
added
S-waiting-on-bors
lcnr
force-pushed
the
lazy-norm-coerce
branch
from
df2aa08
to
88584d5
Compare
|
@bors r=oli-obk |
|
📌 Commit 88584d5 has been approved by |
m-ou-se
added a commit
to m-ou-se/rust
that referenced
this pull request
Nov 18, 2020
type is too big -> values of the type are too big strictly speaking, `[u8; usize::MAX]` or even `[[[u128; usize::MAX]; usize::MAX]; usize::MAX]` are absolutely fine types as long as you don't try to deal with any values of it. This error message seems to cause some confusion imo, for example in rust-lang#79135 (comment) so I would prefer us to be more precise here. See the added test case which uses one of these types without causing an error. r? `@oli-obk`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 18, 2020
Rollup of 11 pull requests Successful merges: - rust-lang#78361 (Updated the list of white-listed target features for x86) - rust-lang#78785 (linux: try to use libc getrandom to allow interposition) - rust-lang#78999 (stability: More precise location for deprecation lint on macros) - rust-lang#79039 (Tighten the bounds on atomic Ordering in std::sys::unix::weak::Weak) - rust-lang#79079 (Turn top-level comments into module docs in MIR visitor) - rust-lang#79114 (add trailing_zeros and leading_zeros to non zero types) - rust-lang#79131 (Enable AVX512 *epi64 variants by updating stdarch) - rust-lang#79133 (bootstrap: use the same version number for rustc and cargo) - rust-lang#79145 (Fix handling of panic calls) - rust-lang#79151 (Fix typo in `std::io::Write` docs) - rust-lang#79158 (type is too big -> values of the type are too big) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
strictly speaking,
[u8; usize::MAX]or even[[[u128; usize::MAX]; usize::MAX]; usize::MAX]are absolutely fine types as long as you don't try to deal with any values of it.This error message seems to cause some confusion imo, for example in #79135 (comment) so I would prefer us to be more precise here.
See the added test case which uses one of these types without causing an error.
r? @oli-obk