Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor query forcing #78780

Merged
merged 13 commits into from
Sep 11, 2021
Merged

Refactor query forcing #78780

merged 13 commits into from
Sep 11, 2021

Commits on Aug 21, 2021

  1. Configuration menu
    Copy the full SHA
    5e35fad View commit details
    Browse the repository at this point in the history
  2. Only clone key when needed.

    cjgillot committed Aug 21, 2021
    Configuration menu
    Copy the full SHA
    0edc775 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2021

  1. Simplify control flow.

    cjgillot committed Aug 22, 2021
    Configuration menu
    Copy the full SHA
    cd1cb34 View commit details
    Browse the repository at this point in the history
  2. Move assertion inwards.

    `with_taks_impl` is only called from `with_eval_always_task` and
    `with_task` . The former is only used in query invocation, while the
    latter is also used to start the `tcx` and to trigger codegen.
    
    This move should not change significantly the number of calls to this
    assertion.
    cjgillot committed Aug 22, 2021
    Configuration menu
    Copy the full SHA
    c3bf396 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    45d6dec View commit details
    Browse the repository at this point in the history
  4. Make all query forcing go through try_execute_query.

    try_execute_query is now able to centralize the path for query
    get/ensure/force.
    
    try_execute_query now takes the dep_node as a parameter, so it can
    accommodate `force`. This dep_node is an Option to avoid computing it in
    the `get` fast path.
    
    try_execute_query now returns both the result and the dep_node_index to
    allow the caller to handle the dep graph.
    
    The caller is responsible for marking the dependency.
    cjgillot committed Aug 22, 2021
    Configuration menu
    Copy the full SHA
    283a8e1 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    13d4eb9 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    d230400 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    307aaca View commit details
    Browse the repository at this point in the history
  8. Split try_execute_query.

    cjgillot committed Aug 22, 2021
    Configuration menu
    Copy the full SHA
    ef4becd View commit details
    Browse the repository at this point in the history
  9. Remove force_query_with_job.

    cjgillot committed Aug 22, 2021
    Configuration menu
    Copy the full SHA
    f2c8707 View commit details
    Browse the repository at this point in the history
  10. Unify with_task functions.

    Remove with_eval_always_task.
    cjgillot committed Aug 22, 2021
    Configuration menu
    Copy the full SHA
    eeb3c8f View commit details
    Browse the repository at this point in the history
  11. Use variable.

    cjgillot committed Aug 22, 2021
    Configuration menu
    Copy the full SHA
    31330bf View commit details
    Browse the repository at this point in the history