Commits on Oct 20, 2020

1. Sync LLVM submodule if it has been initialized …

   Since having enabled the download-ci-llvm option,
   and having rebased on top of f05b47c,
   I've noticed that I had to update the llvm-project
   submodule manually if it was checked out.
   Orignally, the submodule update logic was
   introduced to reduce the friction for contributors
   to manage the submodules, or in other words, to prevent
   getting PRs that have unwanted submodule rollbacks
   because the contributors didn't run git submodule update.
   
   This commit adds logic to ensure there is no inadvertent
   LLVM submodule rollback in a PR if download-ci-llvm
   (or llvm-config) is enabled. It will detect whether the
   llvm-project submodule is initialized, and if so, update
   it in any case. If it is not initialized, behaviour is
   kept to not do any update/initialization.
   
   An alternative to the chosen implementation would
   be to not pass the --init command line arg to
   `git submodule update` for the src/llvm-project
   submodule. This would show a confusing error message
   however on all builds with an uninitialized repo.
   We could pass the --silent param, but we still want
   it to print something if it is initialized and has
   to update something.
   So we just do a manual check for whether the
   submodule is initialized.

   

   est31 committed Oct 20, 2020
   Configuration menu

   • View commit details
   • Copy full SHA for 5948e62
   • Browse repository at this point

   Copy the full SHA

   5948e62 View commit details

   Browse the repository at this point in the history