Permit ty::Bool in const generics for v0 mangling #77452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
Mark-Simulacrum
force-pushed
the
fix-symbol-v0
branch
from
cfff2a0
to
89fdfe6
Compare
varkor
reviewed
Oct 2, 2020
| @@ -504,6 +504,7 @@ impl Printer<'tcx> for SymbolMangler<'tcx> { | |||
|
|
|||
| match ct.ty.kind() { | |||
| ty::Uint(_) => {} | |||
| ty::Bool => {} | |||
There was a problem hiding this comment.
If this is all that's required, can we also add ty::Char and ty::Int, or do these need special attention?
There was a problem hiding this comment.
ty::Int seems reasonable, though we might want to change mangling to express signed-ness (so you get foo<-1> in perf top or whatever, not foo<255>). I think we do not want to encode char with the bits so I would like to hold off on it for now.
There was a problem hiding this comment.
So both seem harder than just bool, which encoding with 0/1 seems quite reasonable.
eddyb
approved these changes
Oct 2, 2020
|
@bors r+ Btw do you have a matching |
|
📌 Commit 89fdfe6 has been approved by |
bors
added
S-waiting-on-bors
|
No, but I will work on that. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 2, 2020
…as-schievink Rollup of 8 pull requests Successful merges: - rust-lang#75377 (Fix Debug implementations of some of the HashMap and BTreeMap iterator types) - rust-lang#76107 (Write manifest for MAJOR.MINOR channel to enable rustup convenience) - rust-lang#76745 (Move Wrapping<T> ui tests into library) - rust-lang#77182 (Add missing examples for Fd traits) - rust-lang#77251 (Bypass const_item_mutation if const's type has Drop impl) - rust-lang#77264 (Only use LOCAL_{STDOUT,STDERR} when set_{print/panic} is used. ) - rust-lang#77421 (Revert "resolve: Avoid "self-confirming" import resolutions in one more case") - rust-lang#77452 (Permit ty::Bool in const generics for v0 mangling) Failed merges: r? `@ghost`
This was referenced Oct 3, 2020
|
Don't worry about the rustc-demangle support: I'm going to add it along with |
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Oct 22, 2020
Support signed integers and `char` in v0 mangling Likely we want more tests, to check the output is correct too: however, I wasn't sure what kind of test we needed, so I just added one similar to that added in rust-lang#77452 for now. r? @eddyb
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should unbreak using new-symbol-mangling = true in config.toml (once it lands in beta anyway).
Fixes #76365 (well, it will, but seems fine to close as soon as we have support)
r? @eddyb (for mangling) but I'm okay with some other reviewer too :)