Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to environment files to change the environment on GHA #77418

Merged
merged 1 commit into from
Oct 2, 2020

Conversation

pietroalbini
Copy link
Member

This PR switches our CI to use GitHub's new environment files to set environment variables and add items to $PATH, as GitHub plans to disable the old ::set-env and ::add-path log commands due to a security issue.

Our self-hosted runners are on version 2.273.4, so they already have support for this.

r? @Mark-Simulacrum

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 1, 2020
@pietroalbini
Copy link
Member Author

@bors p=1000
@rustbot modify labels: T-infra beta-nominated beta-accepted

@rustbot rustbot added beta-accepted Accepted for backporting to the compiler in the beta channel. beta-nominated Nominated for backporting to the compiler in the beta channel. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Oct 1, 2020
@camelid camelid added the A-github-actions Area: GitHub Actions (GHA) label Oct 1, 2020
@Mark-Simulacrum
Copy link
Member

@bors r+ p=100

@bors
Copy link
Contributor

bors commented Oct 2, 2020

📌 Commit b710f9c has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 2, 2020
@bors
Copy link
Contributor

bors commented Oct 2, 2020

⌛ Testing commit b710f9c with merge a585aae...

@bors
Copy link
Contributor

bors commented Oct 2, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: Mark-Simulacrum
Pushing a585aae to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 2, 2020
@bors bors merged commit a585aae into rust-lang:master Oct 2, 2020
@rustbot rustbot added this to the 1.48.0 milestone Oct 2, 2020
@Mark-Simulacrum Mark-Simulacrum removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Oct 3, 2020
@Mark-Simulacrum Mark-Simulacrum modified the milestones: 1.48.0, 1.47.0 Oct 3, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 3, 2020
…k-Simulacrum

[beta] backports

This backports a number of PRs to beta, not all of which have been approved (yet).

 * Switch to environment files to change the environment on GHA rust-lang#77418
 * cache types during normalization rust-lang#76928
 * Fixing memory exhaustion when formatting short code suggestion rust-lang#76598
 * Issue 72408 nested closures exponential rust-lang#72412

r? `@Mark-Simulacrum`
@pietroalbini pietroalbini deleted the ci-environment-files branch December 23, 2020 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-github-actions Area: GitHub Actions (GHA) beta-accepted Accepted for backporting to the compiler in the beta channel. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants