Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable linkcheck after moving std #74861

Merged
merged 2 commits into from
Jul 28, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/bootstrap/builder/tests.rs
Original file line number Diff line number Diff line change
Expand Up @@ -546,9 +546,7 @@ mod dist {
);
}

//FIXME(mark-i-m): reinstate this test when things are fixed...
//#[test]
#[allow(dead_code)]
#[test]
fn test_docs() {
// Behavior of `x.py test` doing various documentation tests.
let mut config = configure(&[], &[]);
Expand Down
1 change: 1 addition & 0 deletions src/bootstrap/doc.rs
Original file line number Diff line number Diff line change
Expand Up @@ -693,6 +693,7 @@ impl Step for UnstableBookGen {
builder.create_dir(&out);
builder.remove_dir(&out);
let mut cmd = builder.tool_cmd(Tool::UnstableBookGen);
cmd.arg(builder.src.join("library"));
cmd.arg(builder.src.join("src"));
cmd.arg(out);

Expand Down
19 changes: 9 additions & 10 deletions src/bootstrap/test.rs
Original file line number Diff line number Diff line change
Expand Up @@ -106,19 +106,18 @@ impl Step for Linkcheck {
///
/// This tool in `src/tools` will verify the validity of all our links in the
/// documentation to ensure we don't have a bunch of dead ones.
fn run(self, _builder: &Builder<'_>) {
// FIXME(mark-i-m): uncomment this after we fix the links...
// let host = self.host;
fn run(self, builder: &Builder<'_>) {
let host = self.host;

// builder.info(&format!("Linkcheck ({})", host));
builder.info(&format!("Linkcheck ({})", host));

// builder.default_doc(None);
builder.default_doc(None);

// let _time = util::timeit(&builder);
// try_run(
// builder,
// builder.tool_cmd(Tool::Linkchecker).arg(builder.out.join(host.triple).join("doc")),
// );
let _time = util::timeit(&builder);
try_run(
builder,
builder.tool_cmd(Tool::Linkchecker).arg(builder.out.join(host.triple).join("doc")),
);
}

fn should_run(run: ShouldRun<'_>) -> ShouldRun<'_> {
Expand Down
8 changes: 5 additions & 3 deletions src/tools/unstable-book-gen/src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -94,13 +94,15 @@ fn copy_recursive(from: &Path, to: &Path) {
}

fn main() {
let src_path_str = env::args_os().skip(1).next().expect("source path required");
let dest_path_str = env::args_os().skip(2).next().expect("destination path required");
let library_path_str = env::args_os().skip(1).next().expect("library path required");
let src_path_str = env::args_os().skip(2).next().expect("source path required");
let dest_path_str = env::args_os().skip(3).next().expect("destination path required");
let library_path = Path::new(&library_path_str);
let src_path = Path::new(&src_path_str);
let dest_path = Path::new(&dest_path_str);

let lang_features = collect_lang_features(src_path, &mut false);
let lib_features = collect_lib_features(src_path)
let lib_features = collect_lib_features(library_path)
.into_iter()
.filter(|&(ref name, _)| !lang_features.contains_key(name))
.collect();
Expand Down