Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Compare tagged/niche-filling layout and pick the best one" #74611

Merged
merged 1 commit into from
Jul 23, 2020
Merged

Revert "Compare tagged/niche-filling layout and pick the best one" #74611

merged 1 commit into from
Jul 23, 2020

Conversation

Mark-Simulacrum
Copy link
Member

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 22, 2020
@Mark-Simulacrum
Copy link
Member Author

We can re-land this PR at a later point if there's a way to recover the perf regression here, but given the pretty large variety of performance regressions over the last week it seems good to eagerly revert this to be better able to evaluate the new version.

@bors rollup=never

@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Jul 22, 2020
Closed
@eddyb
Copy link
Member

eddyb commented Jul 22, 2020

Oh wow that's definitely much larger than just computing both layouts was (then again I didn't use black_box so maybe LLVM made it seem cheaper than it really is).

@bors r+

@bors
Copy link
Contributor

bors commented Jul 22, 2020

‼️ Invalid head SHA found, retrying: 0000000000000000000000000000000000000000

@bors
Copy link
Contributor

bors commented Jul 22, 2020

📌 Commit 1d68600 has been approved by eddyb

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 22, 2020
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Jul 22, 2020
Merged
@nnethercote
Copy link
Contributor

@bors rollup=never

Due to perf effects.

@bors
Copy link
Contributor

bors commented Jul 22, 2020

⌛ Testing commit 1d68600 with merge f4c6964303040a7712afce36bfe89c3663a032ae...

@bors
Copy link
Contributor

bors commented Jul 22, 2020

💔 Test failed - checks-azure

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 22, 2020
@Mark-Simulacrum
Copy link
Member Author

@bors retry - error inflating zlib

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 22, 2020
@bors
Copy link
Contributor

bors commented Jul 23, 2020

⌛ Testing commit 1d68600 with merge fcac119...

@bors
Copy link
Contributor

bors commented Jul 23, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: eddyb
Pushing fcac119 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 23, 2020
@bors bors merged commit fcac119 into rust-lang:master Jul 23, 2020
@ehuss ehuss mentioned this pull request Jul 23, 2020
Closed
@Mark-Simulacrum Mark-Simulacrum deleted the revert-74069-bad-niche branch July 23, 2020 23:17
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Jul 24, 2020
Closed
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Jul 27, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 11, 2020
@bors
Auto merge of rust-lang#74802 - Mark-Simulacrum:reland-74069, r=nneth…
873fc46 
…ercote

Reland rust-lang#74069

Investigation in rust-lang#74716 has concluded that this PR is indeed not a regression (and in fact the rollup itself is not either).

This reverts the revert in rust-lang#74611.

r? @nnethercote cc @eddyb
@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@eddyb eddyb

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.47.0
Development

Successfully merging this pull request may close these issues.
6 participants
@Mark-Simulacrum @eddyb @bors @nnethercote @cuviper @rust-highfive