Clean up some weird command strings #73315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
hbina
reviewed
Jun 13, 2020
| @@ -248,8 +247,8 @@ fn opts() -> Vec<RustcOptGroup> { | |||
| "e", | |||
| "extend-css", | |||
| "To add some CSS rules with a given file to generate doc with your \ | |||
| own theme. However, your theme might break if the rustdoc's generated HTML \ | |||
| changes, so be careful!", | |||
| own theme. However, your theme might break if the rustdoc's generated HTML \ | |||
There was a problem hiding this comment.
Wouldn't this cause the text to have double space?
There was a problem hiding this comment.
As far as I know the \ above followed by a newline will "eat" all whitespace in the next line(s) until a non-space character, so indenting it more is not an issue.
|
A couple of these look like nice cleanups, but some of the reindentation seems arbitrary, it's surely not rustfmt so why the extra indentation? |
|
I tried to pick the "most common" one. But if you have a preference, I'm completely open to it. |
|
I don't mind, it just felt odd to see them, but if you're balancing them out with other multiline strings elsewhere then that's fine. @bors r+ rollup |
|
📌 Commit 724dfba has been approved by |
bors
added
S-waiting-on-bors
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jun 16, 2020
…, r=kinnison Clean up some weird command strings r? @kinnison
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Jun 17, 2020
…, r=kinnison Clean up some weird command strings r? @kinnison
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Jun 17, 2020
…, r=kinnison Clean up some weird command strings r? @kinnison
tmandry
added a commit
to tmandry/rust
that referenced
this pull request
Jun 17, 2020
…, r=kinnison Clean up some weird command strings r? @kinnison
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
Jun 18, 2020
…, r=kinnison Clean up some weird command strings r? @kinnison
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jun 18, 2020
…, r=kinnison Clean up some weird command strings r? @kinnison
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 19, 2020
…arth Rollup of 17 pull requests Successful merges: - rust-lang#70551 (Make all uses of ty::Error delay a span bug) - rust-lang#71338 (Expand "recursive opaque type" diagnostic) - rust-lang#71976 (Improve diagnostics for `let x += 1`) - rust-lang#72279 (add raw_ref macros) - rust-lang#72628 (Add tests for 'impl Default for [T; N]') - rust-lang#72804 (Further tweak lifetime errors involving `dyn Trait` and `impl Trait` in return position) - rust-lang#72814 (remove visit_terminator_kind from MIR visitor) - rust-lang#72836 (Complete the std::time documentation to warn about the inconsistencies between OS) - rust-lang#72968 (Only highlight doc search results via mouseover if mouse has moved) - rust-lang#73034 (Export `#[inline]` fns with extern indicators) - rust-lang#73315 (Clean up some weird command strings) - rust-lang#73320 (Make new type param suggestion more targetted) - rust-lang#73361 (Tweak "non-primitive cast" error) - rust-lang#73425 (Mention functions pointers in the documentation) - rust-lang#73428 (Fix typo in librustc_ast docs) - rust-lang#73447 (Improve document for `Result::as_deref(_mut)` methods) - rust-lang#73476 (Added tooltip for should_panic code examples) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @kinnison