-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 10 pull requests #73309
Rollup of 10 pull requests #73309
Commits on May 26, 2020
-
Display information about captured variable in
FnMut
errorFixes rust-lang#69446 When we encounter a region error involving an `FnMut` closure, we display a specialized error message. However, we currently do not tell the user which upvar was captured. This makes it difficult to determine the cause of the error, especially when the closure is large. This commit records marks constraints involving closure upvars with `ConstraintCategory::ClosureUpvar`. When we decide to 'blame' a `ConstraintCategory::Return`, we additionall store the captured upvar if we found a `ConstraintCategory::ClosureUpvar` in the path. When generating an error message, we point to relevant spans if we have closure upvar information available. We further customize the message if an `async` closure is being returned, to make it clear that the captured variable is being returned indirectly.
Configuration menu - View commit details
-
Copy full SHA for 9cee22c - Browse repository at this point
Copy the full SHA 9cee22cView commit details
Commits on Jun 2, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 4548eb8 - Browse repository at this point
Copy the full SHA 4548eb8View commit details
Commits on Jun 6, 2020
-
Configuration menu - View commit details
-
Copy full SHA for e9b67d2 - Browse repository at this point
Copy the full SHA e9b67d2View commit details
Commits on Jun 7, 2020
-
Rename "cyclone" to "apple-a7" per changes in upstream LLVM
See: https://reviews.llvm.org/D70779 https://reviews.llvm.org/D70779#C1703593NL568 LLVM 10 merged into master at: rust-lang#67759
Configuration menu - View commit details
-
Copy full SHA for 6f6620b - Browse repository at this point
Copy the full SHA 6f6620bView commit details
Commits on Jun 9, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 687767a - Browse repository at this point
Copy the full SHA 687767aView commit details -
Configuration menu - View commit details
-
Copy full SHA for c91320f - Browse repository at this point
Copy the full SHA c91320fView commit details -
Configuration menu - View commit details
-
Copy full SHA for abf74b9 - Browse repository at this point
Copy the full SHA abf74b9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 50c422e - Browse repository at this point
Copy the full SHA 50c422eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 17951e2 - Browse repository at this point
Copy the full SHA 17951e2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 19bb589 - Browse repository at this point
Copy the full SHA 19bb589View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3cfecde - Browse repository at this point
Copy the full SHA 3cfecdeView commit details -
Configuration menu - View commit details
-
Copy full SHA for bdfb9b1 - Browse repository at this point
Copy the full SHA bdfb9b1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 215de3b - Browse repository at this point
Copy the full SHA 215de3bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 187e105 - Browse repository at this point
Copy the full SHA 187e105View commit details
Commits on Jun 10, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 6145918 - Browse repository at this point
Copy the full SHA 6145918View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2af53e9 - Browse repository at this point
Copy the full SHA 2af53e9View commit details -
compiletest: Add directives to detect sanitizer support
Add needs-sanitizer-{address,leak,memory,thread} directive indicating that test requires target with support for specific sanitizer. This is an addition to the existing needs-sanitizer-support directive indicating that test requires a sanitizer runtime library.
Configuration menu - View commit details
-
Copy full SHA for 975f7df - Browse repository at this point
Copy the full SHA 975f7dfView commit details
Commits on Jun 11, 2020
-
Make
fn_arg_names
returnIdent
instead of symbolAlso, implement this query for the local crate, not just foreign crates.
Configuration menu - View commit details
-
Copy full SHA for 754da88 - Browse repository at this point
Copy the full SHA 754da88View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2c11c35 - Browse repository at this point
Copy the full SHA 2c11c35View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5902b2f - Browse repository at this point
Copy the full SHA 5902b2fView commit details
Commits on Jun 12, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 4646e2d - Browse repository at this point
Copy the full SHA 4646e2dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 57b54c4 - Browse repository at this point
Copy the full SHA 57b54c4View commit details -
Configuration menu - View commit details
-
Copy full SHA for b126f32 - Browse repository at this point
Copy the full SHA b126f32View commit details
Commits on Jun 13, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 249a46f - Browse repository at this point
Copy the full SHA 249a46fView commit details -
Rollup merge of rust-lang#72389 - Aaron1011:feature/move-fn-self-msg,…
… r=nikomatsakis Explain move errors that occur due to method calls involving `self` When calling a method that takes `self` (e.g. `vec.into_iter()`), the method receiver is moved out of. If the method receiver is used again, a move error will be emitted:: ```rust fn main() { let a = vec![true]; a.into_iter(); a; } ``` emits ``` error[E0382]: use of moved value: `a` --> src/main.rs:4:5 | 2 | let a = vec![true]; | - move occurs because `a` has type `std::vec::Vec<bool>`, which does not implement the `Copy` trait 3 | a.into_iter(); | - value moved here 4 | a; | ^ value used here after move ``` However, the error message doesn't make it clear that the move is caused by the call to `into_iter`. This PR adds additional messages to move errors when the move is caused by using a value as the receiver of a `self` method:: ``` error[E0382]: use of moved value: `a` --> vec.rs:4:5 | 2 | let a = vec![true]; | - move occurs because `a` has type `std::vec::Vec<bool>`, which does not implement the `Copy` trait 3 | a.into_iter(); | ------------- value moved due to this method call 4 | a; | ^ value used here after move | note: this function takes `self`, which moves the receiver --> /home/aaron/repos/rust/src/libcore/iter/traits/collect.rs:239:5 | 239 | fn into_iter(self) -> Self::IntoIter; ``` TODO: - [x] Add special handling for `FnOnce/FnMut/Fn` - we probably don't want to point at the unstable trait methods - [x] Consider adding additional context for operations (e.g. `Shr::shr`) when the call was generated using the operator syntax (e.g. `a >> b`) - [x] Consider pointing to the method parent (impl or trait block) in addition to the method itself.
Configuration menu - View commit details
-
Copy full SHA for 756dd36 - Browse repository at this point
Copy the full SHA 756dd36View commit details -
Rollup merge of rust-lang#72598 - Aaron1011:feature/fnmut-capture-spa…
…n, r=nikomatsakis Display information about captured variable in `FnMut` error Fixes rust-lang#69446 When we encounter a region error involving an `FnMut` closure, we display a specialized error message. However, we currently do not tell the user which upvar was captured. This makes it difficult to determine the cause of the error, especially when the closure is large. This commit records marks constraints involving closure upvars with `ConstraintCategory::ClosureUpvar`. When we decide to 'blame' a `ConstraintCategory::Return`, we additionall store the captured upvar if we found a `ConstraintCategory::ClosureUpvar` in the path. When generating an error message, we point to relevant spans if we have closure upvar information available. We further customize the message if an `async` closure is being returned, to make it clear that the captured variable is being returned indirectly.
Configuration menu - View commit details
-
Copy full SHA for 2b763fb - Browse repository at this point
Copy the full SHA 2b763fbView commit details -
Rollup merge of rust-lang#72804 - estebank:opaque-missing-lts-in-fn-2…
…, r=nikomatsakis Further tweak lifetime errors involving `dyn Trait` and `impl Trait` in return position * Suggest substituting `'static` lifetime in impl/dyn `Trait + 'static` instead of `Trait + 'static + '_` * When `'static` is explicit, also suggest constraining argument with it * Reduce verbosity of suggestion message and mention lifetime in label * Tweak output for overlapping required/captured spans * Give these errors an error code Follow up to rust-lang#72543. r? @nikomatsakis
Configuration menu - View commit details
-
Copy full SHA for fb9a119 - Browse repository at this point
Copy the full SHA fb9a119View commit details -
Rollup merge of rust-lang#72932 - poliorcetics:pattern-contains-behav…
…iour, r=hanna-kruppe Clarify the behaviour of Pattern when used with methods like str::contains Fixes rust-lang#45507. I used the previous work by @Emerentius (thanks !), added a paragraph and checked the links (they work for me but I'm not against someone else checking them too).
Configuration menu - View commit details
-
Copy full SHA for 5710667 - Browse repository at this point
Copy the full SHA 5710667View commit details -
Rollup merge of rust-lang#73044 - tmiasko:compiletest-san, r=nikomats…
…akis compiletest: Add directives to detect sanitizer support Add needs-sanitizer-{address,leak,memory,thread} directive indicating that test requires target with support for specific sanitizer. This is an addition to the existing needs-sanitizer-support directive indicating that test requires a sanitizer runtime library. The existing needs-sanitizer-support directive could be incorporated into the new ones, but I decided to retain it, since it enables running sanitizer codegen tests even when building of sanitizer runtime libraries is disabled.
Configuration menu - View commit details
-
Copy full SHA for de144aa - Browse repository at this point
Copy the full SHA de144aaView commit details -
Rollup merge of rust-lang#73065 - Amanieu:tls-fix, r=oli-obk
Fix link error with #[thread_local] introduced by rust-lang#71192 r? @oli-obk
Configuration menu - View commit details
-
Copy full SHA for ff4ed9c - Browse repository at this point
Copy the full SHA ff4ed9cView commit details -
Rollup merge of rust-lang#73086 - trevyn:apple-a7, r=nikic
Rename "cyclone" to "apple-a7" per changes in upstream LLVM It looks like they intended to keep "cyclone" as a legacy option, but removed it from the list of subtarget features. This created a flood of warnings when targeting aarch64-apple-ios, and probably also created incorrectly optimized artifacts. See: https://reviews.llvm.org/D70779 https://reviews.llvm.org/D70779#C1703593NL568 LLVM 10 merged into master at: rust-lang#67759
Configuration menu - View commit details
-
Copy full SHA for 826276e - Browse repository at this point
Copy the full SHA 826276eView commit details -
Rollup merge of rust-lang#73267 - ehuss:cargotest-this-cargo, r=Mark-…
…Simulacrum Use the built cargo for cargotest. cargotest was using the beta (bootstrap) cargo. This changes it so that it will use the locally built cargo. This is intended to provide a sort of smoke test to ensure Cargo is functional. This *shouldn't* have any real impact on the CI build time. The cargotest job also happens to run cargo's testsuite, so it should already be building cargo. Note: This will fail until rust-lang#73266 is merged.
Configuration menu - View commit details
-
Copy full SHA for 605c75a - Browse repository at this point
Copy the full SHA 605c75aView commit details -
Rollup merge of rust-lang#73290 - LeSeulArtichaut:patch-1, r=Dylan-DPC
Fix links when pinging notification groups I think a blank line is necessary for the link to be applied. Not sure who to assign, r? @Dylan-DPC
Configuration menu - View commit details
-
Copy full SHA for 7643837 - Browse repository at this point
Copy the full SHA 7643837View commit details -
Rollup merge of rust-lang#73308 - yerke:fix-pretty-asm-rs-test-for-aa…
…rch64, r=Amanieu pretty/asm.rs should only be tested for x86_64 and not AArch64 pretty/asm.rs should only be tested for x86_64 and not AArch64 closes rust-lang#73134 r? @Amanieu
Configuration menu - View commit details
-
Copy full SHA for 6700a13 - Browse repository at this point
Copy the full SHA 6700a13View commit details