Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 6 pull requests #72877

Closed
wants to merge 25 commits into from
Closed

Commits on May 30, 2020

  1. Return early to avoid ICE

    JohnTitor committed May 30, 2020
    Configuration menu
    Copy the full SHA
    7750357 View commit details
    Browse the repository at this point in the history
  2. [AVR] Add AVR platform support

    shepmaster authored and dylanmckay committed May 30, 2020
    Configuration menu
    Copy the full SHA
    2d4b09a View commit details
    Browse the repository at this point in the history
  3. [AVR] Fix debug printing of function pointers

    This commit fixes debug printing of function pointers on AVR. AVR does
    not support `addrspacecast` instructions, and so this patch modifies
    libcore so that a `ptrtoint` IR instruction is used and the address
    space cast is avoided.
    dylanmckay committed May 30, 2020
    Configuration menu
    Copy the full SHA
    a42bf5a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    208adf9 View commit details
    Browse the repository at this point in the history
  5. [AVR] Raise and link to a tracking issue for the avr-interrupt call…

    …ing convention
    
    Also fix the order of the feature gate to fix the tidy errors.
    dylanmckay committed May 30, 2020
    Configuration menu
    Copy the full SHA
    94a94d7 View commit details
    Browse the repository at this point in the history
  6. [AVR] Re-bless the UI tests

    Patch generated with `./x.py test --stage 1 src/test/ui/feature-gates --bless`.
    dylanmckay committed May 30, 2020
    Configuration menu
    Copy the full SHA
    717268c View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    737c342 View commit details
    Browse the repository at this point in the history
  8. [AVR] Re-bless the 'test/ui/symbol-names' tests

    Adding a new ABI changes the hashes of all previous ABIs.
    
    Fix suggested by @shepmaster in
    rust-lang#69478 (comment).
    dylanmckay committed May 30, 2020
    Configuration menu
    Copy the full SHA
    94ece5e View commit details
    Browse the repository at this point in the history
  9. [AVR] Remove AVR-specific logic from libstd

    It is not possible to compile libstd for AVR anyway.
    dylanmckay committed May 30, 2020
    Configuration menu
    Copy the full SHA
    cd890ff View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    6260bc4 View commit details
    Browse the repository at this point in the history
  11. [AVR] Update ABI type classification logic to match the the AVR-Clang…

    … ABI
    
    This patch brings the AVR calling convention argument classification
    logic in line with AVR Clang's behaviour.
    
    AVR-Clang currently uses the `clang::DefaultABIInfo` ABI implementation.
    This calling convention promotes all aggregates to indirect, no matter their
    size.
    
    It is also unnecessary to perform any integer width extension for AVR as
    the minimum argument size matches the minimum describable size of
    abi::Primitive::Int - 8 bits.
    
    At some point in the future, an AVR-GCC compatible argument
    classification implementation should be adopted in both Clang and Rust.
    dylanmckay committed May 30, 2020
    Configuration menu
    Copy the full SHA
    491bf8c View commit details
    Browse the repository at this point in the history

Commits on May 31, 2020

  1. Configuration menu
    Copy the full SHA
    f6dfbbb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c209040 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5707838 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e07e424 View commit details
    Browse the repository at this point in the history
  5. more checks for SwitchInt

    RalfJung committed May 31, 2020
    Configuration menu
    Copy the full SHA
    9a4bdbf View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    f793c0b View commit details
    Browse the repository at this point in the history
  7. Make SourceMap available for early debug-printing of Spans

    Normally, we debug-print `Spans` using the `SourceMap` retrieved from
    the global `TyCtxt`. However, we fall back to printing out the `Span`'s
    raw fields (instead of a file and line number) when we try to print a
    `Span` before a `TyCtxt` is available. This makes debugging early phases
    of the compile, such as parsing, much more difficult.
    
    This commit stores a `SourceMap` in `rustc_span::GlOBALS` as a fallback.
    When a `TyCtxt` is not available, we try to retrieve one from `GLOBALS`
    - only if this is not available do we fall back to the raw field output.
    
    I'm not sure how to write a test for this - however, this can be
    verified locally by setting `RUSTC_LOG="rustc_parse=debug"`, and
    verifying that the output contains filenames and line numbers.
    Aaron1011 committed May 31, 2020
    Configuration menu
    Copy the full SHA
    717fd66 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2020

  1. Configuration menu
    Copy the full SHA
    aa5d29f View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#69478 - avr-rust:avr-support-upstream, r=jo…

    …nas-schievink
    
    Enable AVR as a Tier 3 target upstream
    
    Tracking issue: rust-lang#44052.
    
    Things intentionally left out of the initial upstream:
    
    * The `target_cpu` flag
    
    I have made the cleanup suggestions by @jplatte and @jplatte in avr-rust@043550d.
    
    Anybody feel free to give the branch a test and see how it fares, or make suggestions on the code patch itself.
    RalfJung committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    f019526 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#72618 - Aaron1011:feature/early-sourcemap, …

    …r=petrochenkov
    
    Make `SourceMap` available for early debug-printing of `Span`s
    
    Normally, we debug-print `Spans` using the `SourceMap` retrieved from
    the global `TyCtxt`. However, we fall back to printing out the `Span`'s
    raw fields (instead of a file and line number) when we try to print a
    `Span` before a `TyCtxt` is available. This makes debugging early phases
    of the compile, such as parsing, much more difficult.
    
    This commit stores a `SourceMap` in `rustc_span::GlOBALS` as a fallback.
    When a `TyCtxt` is not available, we try to retrieve one from `GLOBALS`
    - only if this is not available do we fall back to the raw field output.
    
    I'm not sure how to write a test for this - however, this can be
    verified locally by setting `RUSTC_LOG="rustc_parse=debug"`, and
    verifying that the output contains filenames and line numbers.
    RalfJung committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    54ca0f2 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#72740 - estebank:recursive-indirection, r=m…

    …atthewjasper
    
    On recursive ADT, provide indirection structured suggestion
    RalfJung committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    ceb26de View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#72775 - JohnTitor:await-sugg, r=estebank

    Return early to avoid ICE
    
    Fixes rust-lang#72766
    RalfJung committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    11c0fbb View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#72779 - RalfJung:miri, r=oli-obk

    bump Miri, update for cargo-miri being a separate project
    
    r? @oli-obk
    
    Fixes rust-lang#72801
    RalfJung committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    412910e View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#72810 - RalfJung:mir-terminate-sanity, r=jo…

    …nas-schievink
    
    validate basic sanity for TerminatorKind
    
    r? @jonas-schievink
    
    This mainly checks that all `BasicBlock` actually exist. On top of that, it checks that `Call` actually calls something of `FnPtr`/`FnDef` type, and `Assert` has to work on a `bool`. Also `SwitchInt` cannot have an empty target list.
    RalfJung committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    6e916b7 View commit details
    Browse the repository at this point in the history