Allow using Self:: in doc
#71289
Merged
Allow using Self:: in doc
#71289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnTitor
added
the
S-waiting-on-review
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
We do not allow merge commits, kindly rebase and re-commit the change :) |
tesuji
reviewed
Apr 19, 2020
thank you and done |
|
After a discussion with @xliiv, I got a better understanding of why they were using /// Text
/// [Link][Self::foo]
///
/// ```
/// // We are inside a trait implementation
/// let x = &array[foo][Self::x];
/// ```
I thought about two solutions to handle this:
Now that I think about it, when you declare a trait or even a struct, I think that |
This makes sense more to me, so the solution would be to
this should just work now AFAIK (see #70802) @GuillaumeGomez if you can hint me where is the right place to store |
|
Btw, this example data |
|
TODO: check fields too thanks to @GuillaumeGomez |
|
@xliiv we do not allow merge commits. can you rebase instead? thanks |
ghost
changed the title
Self:: in doc of methods Self:: in doc of methods
@Dylan-DPC |
|
I understand, but it is easier fixing it now with lesser commits than when you have more commits to rebase :D |
Dylan-DPC-zz
changed the title
Self:: in doc of methods Self:: in doc of methods
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
Blocked by #72173 |
ghost
marked this pull request as ready for review
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
Please ping me once #72173 is merged (and please rebase at that time so the CI can pass too!) so I can review with everything ready. :) |
ghost
commented
May 15, 2020
@GuillaumeGomez done and ready for review :) |
tesuji
reviewed
May 15, 2020
ghost
mentioned this pull request
|
My question has been answered, therefore we can move forward. Thanks a lot for implementing it! @bors: r+ |
|
📌 Commit 94cf2c69dba94a74b0847749595f522a8a73e95b has been approved by |
bors
added
S-waiting-on-bors
|
@bors rollup |
Also it could be replaced with |
GuillaumeGomez
approved these changes
May 22, 2020
|
@bors: r+ |
|
📌 Commit fc0675b has been approved by |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 23, 2020
Rollup of 7 pull requests Successful merges: - rust-lang#71289 (Allow using `Self::` in doc) - rust-lang#72375 (Improve E0599 explanation) - rust-lang#72385 (Add some teams to prioritization exclude_labels) - rust-lang#72395 (Allow rust-highfive to label issues it creates.) - rust-lang#72453 (Add flag to open docs: x.py doc --open) - rust-lang#72459 (Add core::future::IntoFuture) - rust-lang#72461 (Clean up E0600 explanation) Failed merges: r? @ghost
This was referenced May 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #70802