Got rid of repetitions (such as rustc_ast::ast::) in librustc_ast #71199

Dylan-DPC-zz · 2020-04-16T13:56:42Z

Rework of #70621

credit to @Lezzz for the original pr :)

rust-highfive · 2020-04-16T14:05:57Z

The job mingw-check of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2020-04-16T13:57:20.8893715Z ========================== Starting Command Output ===========================
2020-04-16T13:57:20.8896610Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/1200255b-5a41-485a-8904-fcb320c8cf1c.sh
2020-04-16T13:57:20.8896854Z 
2020-04-16T13:57:20.8900483Z ##[section]Finishing: Disable git automatic line ending conversion
2020-04-16T13:57:20.8918980Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/71199/merge to s
2020-04-16T13:57:20.8921998Z Task         : Get sources
2020-04-16T13:57:20.8922293Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-04-16T13:57:20.8922562Z Version      : 1.0.0
2020-04-16T13:57:20.8922748Z Author       : Microsoft
---
2020-04-16T13:57:21.8965960Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-04-16T13:57:21.8970852Z ##[command]git config gc.auto 0
2020-04-16T13:57:21.8974080Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-04-16T13:57:21.8977032Z ##[command]git config --get-all http.proxy
2020-04-16T13:57:21.8982743Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/71199/merge:refs/remotes/pull/71199/merge
---
2020-04-16T14:01:01.5767074Z  ---> 78ad2f4d4aca
2020-04-16T14:01:01.5767360Z Step 6/7 : ENV RUN_CHECK_WITH_PARALLEL_QUERIES 1
2020-04-16T14:01:01.5770607Z  ---> Using cache
2020-04-16T14:01:01.5771771Z  ---> 4d2dc61c4d00
2020-04-16T14:01:01.5775479Z Step 7/7 : ENV SCRIPT python3 ../x.py test src/tools/expand-yaml-anchors &&            python3 ../x.py check --target=i686-pc-windows-gnu --host=i686-pc-windows-gnu &&            python3 ../x.py build --stage 0 src/tools/build-manifest &&            python3 ../x.py test --stage 0 src/tools/compiletest &&            python3 ../x.py test src/tools/tidy &&            /scripts/validate-toolstate.sh
2020-04-16T14:01:01.5777271Z  ---> 776b6266a8b7
2020-04-16T14:01:01.5858992Z Successfully built 776b6266a8b7
2020-04-16T14:01:01.5905522Z Successfully tagged rust-ci:latest
2020-04-16T14:01:01.6203241Z Built container sha256:776b6266a8b7d63e2d3c2b5a784dbf521184a904fb10bf818c6b5c7e1ab74d4a
2020-04-16T14:01:01.6203241Z Built container sha256:776b6266a8b7d63e2d3c2b5a784dbf521184a904fb10bf818c6b5c7e1ab74d4a
2020-04-16T14:01:01.6219969Z Looks like docker image is the same as before, not uploading
2020-04-16T14:01:09.6754127Z [CI_JOB_NAME=mingw-check]
2020-04-16T14:01:09.6987198Z [CI_JOB_NAME=mingw-check]
2020-04-16T14:01:09.7018670Z == clock drift check ==
2020-04-16T14:01:09.7028948Z   local time: Thu Apr 16 14:01:09 UTC 2020
2020-04-16T14:01:09.8825355Z   network time: Thu, 16 Apr 2020 14:01:09 GMT
2020-04-16T14:01:09.8852043Z Starting sccache server...
2020-04-16T14:01:09.9969010Z configure: processing command line
2020-04-16T14:01:09.9969360Z configure: 
2020-04-16T14:01:09.9970382Z configure: rust.parallel-compiler := True
---
2020-04-16T14:04:44.4151290Z 
2020-04-16T14:04:44.4151704Z To learn more, run the command again with --verbose.
2020-04-16T14:04:44.4167828Z warning: build failed, waiting for other jobs to finish...
2020-04-16T14:04:44.7568475Z error: build failed
2020-04-16T14:04:44.7593430Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "check" "--target" "x86_64-unknown-linux-gnu" "-Zbinary-dep-depinfo" "-j" "2" "--release" "--color" "always" "--features" " llvm" "--manifest-path" "/checkout/src/rustc/Cargo.toml" "--message-format" "json-render-diagnostics"
2020-04-16T14:04:44.7600475Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap check
2020-04-16T14:04:44.7600802Z Build completed unsuccessfully in 0:03:34
2020-04-16T14:04:44.7704273Z == clock drift check ==
2020-04-16T14:04:44.7704273Z == clock drift check ==
2020-04-16T14:04:44.7725993Z   local time: Thu Apr 16 14:04:44 UTC 2020
2020-04-16T14:04:44.8672792Z   network time: Thu, 16 Apr 2020 14:04:44 GMT
2020-04-16T14:04:45.6224178Z 
2020-04-16T14:04:45.6224178Z 
2020-04-16T14:04:45.6295386Z ##[error]Bash exited with code '1'.
2020-04-16T14:04:45.6308780Z ##[section]Finishing: Run build
2020-04-16T14:04:45.6350260Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/71199/merge to s
2020-04-16T14:04:45.6354923Z Task         : Get sources
2020-04-16T14:04:45.6355209Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-04-16T14:04:45.6355469Z Version      : 1.0.0
2020-04-16T14:04:45.6355673Z Author       : Microsoft
2020-04-16T14:04:45.6355673Z Author       : Microsoft
2020-04-16T14:04:45.6355967Z Help         : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
2020-04-16T14:04:45.6356298Z ==============================================================================
2020-04-16T14:04:45.9555379Z Cleaning any cached credential from repository: rust-lang/rust (GitHub)
2020-04-16T14:04:45.9601765Z ##[section]Finishing: Checkout rust-lang/rust@refs/pull/71199/merge to s
2020-04-16T14:04:45.9689365Z Cleaning up task key
2020-04-16T14:04:45.9691535Z Start cleaning up orphan processes.
2020-04-16T14:04:45.9868608Z Terminate orphan process: pid (3584) (python)
2020-04-16T14:04:46.0019359Z ##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

eddyb · 2020-04-16T17:47:52Z

r? @petrochenkov (who wasn't that keen on this, as per #70621 (comment) - I don't want to just override that)

(but also, CI doesn't pass)

Dylan-DPC-zz · 2020-04-16T17:57:26Z

Yes i'm aware, investigating the failure (which seems odd)

petrochenkov · 2020-04-16T18:04:02Z

Yeah, I just don't like a bunch of names existing in the crate root - some from the AST proper, some are just modules from the rustc_ast crate.
So if you import e.g. use rustc_ast::* you get things like mut_visit or util in scope as well, despite them not being AST structures.

I don't think we have other crates organized like this? Usually crate root modules are not very populated.

petrochenkov · 2020-04-16T18:05:32Z

Sigh, we already have rustc_hir that does pub use hir::*; from its root.

Dylan-DPC-zz · 2020-04-16T18:06:32Z

Ye as I was doing these changes, I saw a similar pattern with hir

petrochenkov · 2020-04-16T18:08:54Z

r? @eddyb who wanted to do this, I won't stand in the way.

Dylan-DPC-zz · 2020-04-16T18:17:59Z

@bors try

bors · 2020-04-16T18:18:18Z

⌛ Trying commit 17a5e3e8f514a947945ded2c7652d670401f4238 with merge b5d8c557b2ae4fb6157c4b0d05d15e8ca0fe39ca...

bors · 2020-04-16T19:09:24Z

💔 Test failed - checks-azure

bors · 2020-04-24T12:33:59Z

☔ The latest upstream changes (presumably #70820) made this pull request unmergeable. Please resolve the merge conflicts.

rust-highfive · 2020-04-27T08:18:57Z

Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2020-04-27T07:38:49.7666488Z ========================== Starting Command Output ===========================
2020-04-27T07:38:49.7669269Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/a0b7b02e-9124-43a1-8431-8eb1c54abbab.sh
2020-04-27T07:38:49.7669553Z 
2020-04-27T07:38:49.7674265Z ##[section]Finishing: Disable git automatic line ending conversion
2020-04-27T07:38:49.7695814Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/71199/merge to s
2020-04-27T07:38:49.7699397Z Task         : Get sources
2020-04-27T07:38:49.7699743Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-04-27T07:38:49.7700064Z Version      : 1.0.0
2020-04-27T07:38:49.7700282Z Author       : Microsoft
---
2020-04-27T07:38:50.7805583Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-04-27T07:38:50.7810458Z ##[command]git config gc.auto 0
2020-04-27T07:38:50.7813974Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-04-27T07:38:50.7817190Z ##[command]git config --get-all http.proxy
2020-04-27T07:38:50.7823051Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/71199/merge:refs/remotes/pull/71199/merge
---
2020-04-27T07:41:04.7580840Z  ---> f7353ccad5b1
2020-04-27T07:41:04.7581242Z Step 6/7 : ENV RUN_CHECK_WITH_PARALLEL_QUERIES 1
2020-04-27T07:41:04.7586268Z  ---> Using cache
2020-04-27T07:41:04.7586947Z  ---> ed38efbaa060
2020-04-27T07:41:04.7588275Z Step 7/7 : ENV SCRIPT python3 ../x.py test src/tools/expand-yaml-anchors &&            python3 ../x.py check --target=i686-pc-windows-gnu --host=i686-pc-windows-gnu &&            python3 ../x.py build --stage 0 src/tools/build-manifest &&            python3 ../x.py test --stage 0 src/tools/compiletest &&            python3 ../x.py test src/tools/tidy &&            /scripts/validate-toolstate.sh
2020-04-27T07:41:04.7596891Z  ---> c5008ef7ae8e
2020-04-27T07:41:04.7659692Z Successfully built c5008ef7ae8e
2020-04-27T07:41:04.7698118Z Successfully tagged rust-ci:latest
2020-04-27T07:41:04.7972505Z Built container sha256:c5008ef7ae8e94d7ef502e3cef26e61208e14ebdb36913f3a8bb86291bd6430b
2020-04-27T07:41:04.7972505Z Built container sha256:c5008ef7ae8e94d7ef502e3cef26e61208e14ebdb36913f3a8bb86291bd6430b
2020-04-27T07:41:04.7987263Z Looks like docker image is the same as before, not uploading
2020-04-27T07:41:12.7582922Z [CI_JOB_NAME=mingw-check]
2020-04-27T07:41:12.7791690Z [CI_JOB_NAME=mingw-check]
2020-04-27T07:41:12.7815703Z == clock drift check ==
2020-04-27T07:41:12.7825294Z   local time: Mon Apr 27 07:41:12 UTC 2020
2020-04-27T07:41:13.0656145Z   network time: Mon, 27 Apr 2020 07:41:13 GMT
2020-04-27T07:41:13.0677250Z Starting sccache server...
2020-04-27T07:41:13.1734287Z configure: processing command line
2020-04-27T07:41:13.1734929Z configure: 
2020-04-27T07:41:13.1735892Z configure: rust.parallel-compiler := True
---
2020-04-27T07:43:13.8200824Z     Checking unicode-width v0.1.6
2020-04-27T07:43:13.8931038Z     Checking getopts v0.2.21
2020-04-27T07:43:15.8222361Z     Checking test v0.0.0 (/checkout/src/libtest)
2020-04-27T07:43:16.4462990Z     Finished release [optimized] target(s) in 27.64s
2020-04-27T07:43:16.4469729Z {"reason":"build-finished","success":true}
2020-04-27T07:43:16.9900831Z     Checking cfg-if v0.1.10
2020-04-27T07:43:16.9912300Z    Compiling libc v0.2.69
2020-04-27T07:43:17.0301061Z    Compiling semver-parser v0.7.0
2020-04-27T07:43:17.8055454Z     Checking lazy_static v1.4.0
---
2020-04-27T07:44:43.9075922Z     Checking rustc_feature v0.0.0 (/checkout/src/librustc_feature)
2020-04-27T07:44:44.0949719Z     Checking fmt_macros v0.0.0 (/checkout/src/libfmt_macros)
2020-04-27T07:44:44.2764698Z     Checking rustc_ast_pretty v0.0.0 (/checkout/src/librustc_ast_pretty)
2020-04-27T07:44:44.2779081Z     Checking rustc_hir v0.0.0 (/checkout/src/librustc_hir)
2020-04-27T07:44:44.8371273Z     Checking rustc_query_system v0.0.0 (/checkout/src/librustc_query_system)
2020-04-27T07:44:46.9293048Z     Checking rustc_attr v0.0.0 (/checkout/src/librustc_attr)
2020-04-27T07:44:47.3781668Z     Checking rustc_parse v0.0.0 (/checkout/src/librustc_parse)
2020-04-27T07:44:49.1910859Z     Checking rustc_hir_pretty v0.0.0 (/checkout/src/librustc_hir_pretty)
2020-04-27T07:44:49.5909006Z     Checking rustc_ast_lowering v0.0.0 (/checkout/src/librustc_ast_lowering)
---
2020-04-27T07:45:19.6868441Z     Checking rustc_mir_build v0.0.0 (/checkout/src/librustc_mir_build)
2020-04-27T07:45:25.1203350Z     Checking rustc_plugin_impl v0.0.0 (/checkout/src/librustc_plugin_impl)
2020-04-27T07:45:25.2740761Z     Checking rustc_privacy v0.0.0 (/checkout/src/librustc_privacy)
2020-04-27T07:45:32.6145062Z     Checking rustc-main v0.0.0 (/checkout/src/rustc)
2020-04-27T07:45:32.6956675Z  {"reason":"build-finished","success":true}
2020-04-27T07:45:32.7446193Z Checking rustdoc artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-04-27T07:45:32.9640501Z     Checking cfg-if v0.1.10
2020-04-27T07:45:32.9644884Z    Compiling libc v0.2.69
2020-04-27T07:45:32.9972506Z    Compiling semver-parser v0.7.0
---
2020-04-27T07:45:56.6990042Z    Compiling serde_derive v1.0.81
2020-04-27T07:46:19.7534612Z     Checking serde_json v1.0.40
2020-04-27T07:46:20.8734888Z     Checking rustdoc v0.0.0 (/checkout/src/librustdoc)
2020-04-27T07:46:25.0724229Z     Checking rustdoc-tool v0.0.0 (/checkout/src/tools/rustdoc)
2020-04-27T07:46:25.1696988Z {"reason":"build-finished","success":true}
2020-04-27T07:46:25.1852726Z Build completed successfully in 0:05:11
2020-04-27T07:46:25.4290297Z configure: processing command line
2020-04-27T07:46:25.4290605Z configure: 
2020-04-27T07:46:25.4291508Z configure: dist.missing-tools   := True
---
2020-04-27T07:46:25.4297081Z configure: build.cargo-native-static := True
2020-04-27T07:46:25.4297555Z configure: rust.channel         := nightly
2020-04-27T07:46:25.4298014Z configure: llvm.ccache          := sccache
2020-04-27T07:46:25.4298634Z configure: build.locked-deps    := True
2020-04-27T07:46:25.4299409Z configure: build.configure-args := ['--enable-sccache', '--disable-manage-submodu ...
2020-04-27T07:46:25.4300259Z configure: writing `config.toml` in current directory
2020-04-27T07:46:25.4300654Z configure: 
2020-04-27T07:46:25.4301222Z configure: run `python /checkout/x.py --help`
2020-04-27T07:46:25.4301613Z configure: 
---
2020-04-27T07:47:50.4741190Z Hugepagesize:       2048 kB
2020-04-27T07:47:50.4741391Z DirectMap4k:      149440 kB
2020-04-27T07:47:50.4741703Z DirectMap2M:     2996224 kB
2020-04-27T07:47:50.4741899Z DirectMap1G:     6291456 kB
2020-04-27T07:47:50.4805761Z + python3 ../x.py test src/tools/expand-yaml-anchors
2020-04-27T07:47:51.8573021Z Ensuring the YAML anchors in the GitHub Actions config were expanded
2020-04-27T07:47:51.8573021Z Ensuring the YAML anchors in the GitHub Actions config were expanded
2020-04-27T07:47:51.8580793Z Building stage0 tool expand-yaml-anchors (x86_64-unknown-linux-gnu)
2020-04-27T07:47:52.0909092Z    Compiling unicode-xid v0.2.0
2020-04-27T07:47:52.2087679Z    Compiling syn v1.0.11
2020-04-27T07:47:52.9622797Z    Compiling linked-hash-map v0.5.2
2020-04-27T07:47:53.0081368Z    Compiling lazy_static v1.4.0
2020-04-27T07:47:53.0081368Z    Compiling lazy_static v1.4.0
2020-04-27T07:47:53.1642507Z    Compiling yaml-rust v0.4.3
2020-04-27T07:47:57.1013120Z    Compiling quote v1.0.2
2020-04-27T07:48:09.5875280Z    Compiling thiserror-impl v1.0.5
2020-04-27T07:48:14.1331905Z    Compiling thiserror v1.0.5
2020-04-27T07:48:14.1882536Z    Compiling yaml-merge-keys v0.4.0
2020-04-27T07:48:15.2438094Z    Compiling expand-yaml-anchors v0.1.0 (/checkout/src/tools/expand-yaml-anchors)
2020-04-27T07:48:16.7798408Z     Finished release [optimized] target(s) in 24.91s
2020-04-27T07:48:16.7799116Z {"reason":"build-finished","success":true}
2020-04-27T07:48:17.6203889Z + python3 ../x.py check --target=i686-pc-windows-gnu --host=i686-pc-windows-gnu
2020-04-27T07:48:17.8902191Z     Finished dev [unoptimized] target(s) in 0.18s
2020-04-27T07:48:18.9510781Z Checking rustdoc artifacts (x86_64-unknown-linux-gnu -> i686-pc-windows-gnu)
2020-04-27T07:48:18.9529469Z Checking std artifacts (x86_64-unknown-linux-gnu -> i686-pc-windows-gnu)
---
2020-04-27T07:48:40.3980955Z     Checking proc_macro v0.0.0 (/checkout/src/libproc_macro)
2020-04-27T07:48:40.6292630Z     Checking unicode-width v0.1.6
2020-04-27T07:48:40.7020399Z     Checking getopts v0.2.21
2020-04-27T07:48:42.5842086Z     Checking test v0.0.0 (/checkout/src/libtest)
2020-04-27T07:48:43.1910777Z {"reason":"build-finished","success":true}
2020-04-27T07:48:43.2052198Z Checking compiler artifacts (x86_64-unknown-linux-gnu -> i686-pc-windows-gnu)
2020-04-27T07:48:43.7517800Z     Checking cfg-if v0.1.10
2020-04-27T07:48:43.7518470Z    Compiling winapi-i686-pc-windows-gnu v0.4.0
2020-04-27T07:48:43.7867979Z    Compiling semver-parser v0.7.0
---
2020-04-27T07:50:13.0121476Z     Checking rustc_feature v0.0.0 (/checkout/src/librustc_feature)
2020-04-27T07:50:13.1526094Z     Checking fmt_macros v0.0.0 (/checkout/src/libfmt_macros)
2020-04-27T07:50:13.3450459Z     Checking rustc_ast_pretty v0.0.0 (/checkout/src/librustc_ast_pretty)
2020-04-27T07:50:13.4011735Z     Checking rustc_hir v0.0.0 (/checkout/src/librustc_hir)
2020-04-27T07:50:13.9272376Z     Checking rustc_query_system v0.0.0 (/checkout/src/librustc_query_system)
2020-04-27T07:50:15.9781709Z     Checking rustc_attr v0.0.0 (/checkout/src/librustc_attr)
2020-04-27T07:50:16.4463121Z     Checking rustc_parse v0.0.0 (/checkout/src/librustc_parse)
2020-04-27T07:50:18.3486313Z     Checking rustc_hir_pretty v0.0.0 (/checkout/src/librustc_hir_pretty)
2020-04-27T07:50:18.7386735Z     Checking rustc_ast_lowering v0.0.0 (/checkout/src/librustc_ast_lowering)
---
2020-04-27T07:50:53.8259694Z     Checking rustc_plugin_impl v0.0.0 (/checkout/src/librustc_plugin_impl)
2020-04-27T07:50:55.5196032Z     Checking rustc_privacy v0.0.0 (/checkout/src/librustc_privacy)
2020-04-27T07:50:58.2972831Z     Checking rustc-main v0.0.0 (/checkout/src/rustc)
2020-04-27T07:50:58.3776768Z     Finished release [optimized] target(s) in 2m 15s
2020-04-27T07:50:58.3783682Z {"reason":"build-finished","success":true}
2020-04-27T07:50:58.6740530Z     Checking cfg-if v0.1.10
2020-04-27T07:50:58.6751355Z    Compiling semver-parser v0.7.0
2020-04-27T07:50:58.7105107Z    Compiling proc-macro2 v0.4.30
2020-04-27T07:50:59.5686807Z    Compiling unicode-xid v0.1.0
---
2020-04-27T07:51:47.6911620Z     Checking serde_json v1.0.40
2020-04-27T07:51:48.8103866Z     Checking rustdoc v0.0.0 (/checkout/src/librustdoc)
2020-04-27T07:51:52.9626710Z     Checking rustdoc-tool v0.0.0 (/checkout/src/tools/rustdoc)
2020-04-27T07:51:53.0572333Z     Finished release [optimized] target(s) in 54.62s
2020-04-27T07:51:53.0573730Z {"reason":"build-finished","success":true}
2020-04-27T07:51:53.0859029Z + python3 ../x.py build --stage 0 src/tools/build-manifest
2020-04-27T07:51:53.3543313Z     Finished dev [unoptimized] target(s) in 0.18s
2020-04-27T07:51:54.4086913Z Building stage0 tool build-manifest (x86_64-unknown-linux-gnu)
2020-04-27T07:51:54.5845897Z    Compiling proc-macro2 v0.4.30
---
2020-04-27T07:52:32.5889288Z    Compiling toml v0.5.3
2020-04-27T07:52:33.1299498Z    Compiling serde_json v1.0.40
2020-04-27T07:52:39.4541743Z    Compiling build-manifest v0.1.0 (/checkout/src/tools/build-manifest)
2020-04-27T07:52:43.4190031Z     Finished release [optimized] target(s) in 49.01s
2020-04-27T07:52:43.4196892Z {"reason":"build-finished","success":true}
2020-04-27T07:52:43.4369909Z + python3 ../x.py test --stage 0 src/tools/compiletest
2020-04-27T07:52:43.7135026Z     Finished dev [unoptimized] target(s) in 0.19s
2020-04-27T07:52:44.9707378Z    Compiling log v0.4.8
2020-04-27T07:52:44.9707973Z    Compiling memchr v2.3.2
---
2020-04-27T07:53:28.9438907Z    Compiling semver v0.9.0
2020-04-27T07:53:30.3951814Z    Compiling cargo_metadata v0.9.1
2020-04-27T07:53:33.6528894Z    Compiling tidy v0.1.0 (/checkout/src/tools/tidy)
2020-04-27T07:53:43.4536638Z     Finished release [optimized] target(s) in 22.03s
2020-04-27T07:53:43.4537208Z {"reason":"build-finished","success":true}
2020-04-27T07:53:50.7811973Z * 596 error codes
2020-04-27T07:53:50.7812781Z * highest error code: E0753
2020-04-27T07:53:51.1241199Z * 283 features
2020-04-27T07:53:53.7498175Z Checking which error codes lack tests...
---
2020-04-27T07:53:56.3182191Z skip untracked path cpu-usage.csv during rustfmt invocations
2020-04-27T07:53:56.3187059Z skip untracked path src/doc/book/ during rustfmt invocations
2020-04-27T07:53:56.3190374Z skip untracked path src/doc/rust-by-example/ during rustfmt invocations
2020-04-27T07:53:56.3193338Z skip untracked path src/llvm-project/ during rustfmt invocations
2020-04-27T07:53:58.6750236Z Diff in /checkout/src/librustc_mir/transform/mod.rs at line 123:
2020-04-27T07:53:58.6751448Z  /// type `T`.
2020-04-27T07:53:58.6752948Z  pub fn default_name<T: ?Sized>() -> Cow<'static, str> {
2020-04-27T07:53:58.6753979Z      let name = ::std::any::type_name::<T>();
2020-04-27T07:53:58.6755472Z -    if let Some(tail) = name.rfind(':') {
2020-04-27T07:53:58.6756202Z -        Cow::from(&name[tail + 1..])
2020-04-27T07:53:58.6757092Z -        Cow::from(name)
2020-04-27T07:53:58.6757559Z -    }
2020-04-27T07:53:58.6757559Z -    }
2020-04-27T07:53:58.6758185Z +    if let Some(tail) = name.rfind(':') { Cow::from(&name[tail + 1..]) } else { Cow::from(name) }
2020-04-27T07:53:58.6759490Z  
2020-04-27T07:53:58.6760913Z  /// A streamlined trait that you can implement to create a pass; the
2020-04-27T07:53:58.6760913Z  /// A streamlined trait that you can implement to create a pass; the
2020-04-27T07:53:58.6762069Z Running `"/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/rustfmt" "--config-path" "/checkout" "--edition" "2018" "--unstable-features" "--skip-children" "--check" "/checkout/src/librustc_mir/transform/mod.rs"` failed.
2020-04-27T07:53:58.6763054Z If you're running `tidy`, try again with `--bless` flag. Or, you just want to format code, run `./x.py fmt` instead.
2020-04-27T07:53:58.6774490Z Build completed unsuccessfully in 0:00:38
2020-04-27T07:53:58.6870451Z == clock drift check ==
2020-04-27T07:53:58.6882705Z   local time: Mon Apr 27 07:53:58 UTC 2020
2020-04-27T07:53:58.6882705Z   local time: Mon Apr 27 07:53:58 UTC 2020
2020-04-27T07:53:58.9707402Z   network time: Mon, 27 Apr 2020 07:53:58 GMT
2020-04-27T07:54:00.4899387Z 
2020-04-27T07:54:00.4899387Z 
2020-04-27T07:54:00.4960823Z ##[error]Bash exited with code '1'.
2020-04-27T07:54:00.4972933Z ##[section]Finishing: Run build
2020-04-27T07:54:00.5028902Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/71199/merge to s
2020-04-27T07:54:00.5033646Z Task         : Get sources
2020-04-27T07:54:00.5033979Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-04-27T07:54:00.5034266Z Version      : 1.0.0
2020-04-27T07:54:00.5034476Z Author       : Microsoft
2020-04-27T07:54:00.5034476Z Author       : Microsoft
2020-04-27T07:54:00.5034815Z Help         : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
2020-04-27T07:54:00.5035180Z ==============================================================================
2020-04-27T07:54:00.8063679Z Cleaning any cached credential from repository: rust-lang/rust (GitHub)
2020-04-27T07:54:00.8106095Z ##[section]Finishing: Checkout rust-lang/rust@refs/pull/71199/merge to s
2020-04-27T07:54:00.8190892Z Cleaning up task key
2020-04-27T07:54:00.8192055Z Start cleaning up orphan processes.
2020-04-27T07:54:00.8353686Z Terminate orphan process: pid (4122) (python)
2020-04-27T07:54:00.8583843Z ##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

rust-highfive · 2020-04-27T09:44:45Z

Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2020-04-27T08:59:18.5767199Z ========================== Starting Command Output ===========================
2020-04-27T08:59:18.5769587Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/054788df-a1a7-4807-a43c-aff14e9483de.sh
2020-04-27T08:59:18.5769830Z 
2020-04-27T08:59:18.5773968Z ##[section]Finishing: Disable git automatic line ending conversion
2020-04-27T08:59:18.5791493Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/71199/merge to s
2020-04-27T08:59:18.5794624Z Task         : Get sources
2020-04-27T08:59:18.5794880Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-04-27T08:59:18.5795129Z Version      : 1.0.0
2020-04-27T08:59:18.5795298Z Author       : Microsoft
---
2020-04-27T08:59:19.5733312Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-04-27T08:59:19.5739846Z ##[command]git config gc.auto 0
2020-04-27T08:59:19.5744278Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-04-27T08:59:19.5748635Z ##[command]git config --get-all http.proxy
2020-04-27T08:59:19.5756597Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/71199/merge:refs/remotes/pull/71199/merge
---
2020-04-27T09:01:37.4661447Z  ---> cb2676f08729
2020-04-27T09:01:37.4662791Z Step 5/8 : ENV RUST_CONFIGURE_ARGS       --build=x86_64-unknown-linux-gnu       --llvm-root=/usr/lib/llvm-8       --enable-llvm-link-shared       --set rust.thin-lto-import-instr-limit=10
2020-04-27T09:01:37.4669847Z  ---> Using cache
2020-04-27T09:01:37.4670165Z  ---> df25ce111862
2020-04-27T09:01:37.4671024Z Step 6/8 : ENV SCRIPT python2.7 ../x.py test --exclude src/tools/tidy &&            python2.7 ../x.py test src/test/mir-opt --pass=build                                   --target=armv5te-unknown-linux-gnueabi &&            python2.7 ../x.py test src/tools/tidy
2020-04-27T09:01:37.4676403Z  ---> 599b9ac96b27
2020-04-27T09:01:37.4676616Z Step 7/8 : ENV NO_DEBUG_ASSERTIONS=1
2020-04-27T09:01:37.4681049Z  ---> Using cache
2020-04-27T09:01:37.4681388Z  ---> 091087e35a36
---
2020-04-27T09:01:37.5027892Z Looks like docker image is the same as before, not uploading
2020-04-27T09:01:44.0272569Z [CI_JOB_NAME=x86_64-gnu-llvm-8]
2020-04-27T09:01:44.0567905Z [CI_JOB_NAME=x86_64-gnu-llvm-8]
2020-04-27T09:01:44.0598426Z == clock drift check ==
2020-04-27T09:01:44.0609342Z   local time: Mon Apr 27 09:01:44 UTC 2020
2020-04-27T09:01:44.3537453Z   network time: Mon, 27 Apr 2020 09:01:44 GMT
2020-04-27T09:01:44.3563954Z Starting sccache server...
2020-04-27T09:01:44.4390294Z configure: processing command line
2020-04-27T09:01:44.4390531Z configure: 
2020-04-27T09:01:44.4391369Z configure: rust.dist-src        := False
---
2020-04-27T09:03:59.9405334Z    Compiling proc_macro v0.0.0 (/checkout/src/libproc_macro)
2020-04-27T09:04:03.4735566Z    Compiling unicode-width v0.1.6
2020-04-27T09:04:03.5557704Z    Compiling getopts v0.2.21
2020-04-27T09:04:12.9294795Z    Compiling test v0.0.0 (/checkout/src/libtest)
2020-04-27T09:04:20.4301559Z {"reason":"build-finished","success":true}
2020-04-27T09:04:20.4419698Z Copying stage0 std from stage0 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
2020-04-27T09:04:20.4534380Z Building stage0 compiler artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-04-27T09:04:20.9922720Z    Compiling cfg-if v0.1.10
2020-04-27T09:04:20.9923616Z    Compiling libc v0.2.69
---
2020-04-27T09:06:37.5695091Z    Compiling rustc_feature v0.0.0 (/checkout/src/librustc_feature)
2020-04-27T09:06:38.8442614Z    Compiling fmt_macros v0.0.0 (/checkout/src/libfmt_macros)
2020-04-27T09:06:40.2529375Z    Compiling rustc_ast_pretty v0.0.0 (/checkout/src/librustc_ast_pretty)
2020-04-27T09:06:41.3004952Z    Compiling rustc_hir v0.0.0 (/checkout/src/librustc_hir)
2020-04-27T09:06:49.1362144Z    Compiling rustc_query_system v0.0.0 (/checkout/src/librustc_query_system)
2020-04-27T09:06:51.4814637Z    Compiling rustc_hir_pretty v0.0.0 (/checkout/src/librustc_hir_pretty)
2020-04-27T09:06:55.4615443Z    Compiling rustc_attr v0.0.0 (/checkout/src/librustc_attr)
2020-04-27T09:06:59.2375028Z    Compiling rustc_parse v0.0.0 (/checkout/src/librustc_parse)
2020-04-27T09:07:07.4363089Z    Compiling rustc_ast_lowering v0.0.0 (/checkout/src/librustc_ast_lowering)
---
2020-04-27T09:21:02.9159936Z    Compiling rustc_privacy v0.0.0 (/checkout/src/librustc_privacy)
2020-04-27T09:21:09.9166641Z    Compiling rustc_plugin_impl v0.0.0 (/checkout/src/librustc_plugin_impl)
2020-04-27T09:23:22.3555754Z    Compiling rustc-main v0.0.0 (/checkout/src/rustc)
2020-04-27T09:23:22.9239379Z     Finished release [optimized] target(s) in 19m 02s
2020-04-27T09:23:22.9239946Z {"reason":"build-finished","success":true}
2020-04-27T09:23:22.9725347Z Assembling stage1 compiler (x86_64-unknown-linux-gnu)
2020-04-27T09:23:22.9745316Z Building stage1 std artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-04-27T09:23:23.2409929Z    Compiling cc v1.0.50
2020-04-27T09:23:23.2410718Z    Compiling core v0.0.0 (/checkout/src/libcore)
2020-04-27T09:23:23.2410718Z    Compiling core v0.0.0 (/checkout/src/libcore)
2020-04-27T09:23:26.5791657Z error: use of deprecated item 'asm': the syntax of asm! will change soon, use llvm_asm! to avoid breakage
2020-04-27T09:23:26.5792877Z   --> src/libcore/../stdarch/crates/core_arch/src/x86/eflags.rs:33:5
2020-04-27T09:23:26.5793556Z    |
2020-04-27T09:23:26.5794299Z 33 |     asm!("pushfq; popq $0" : "=r"(eflags) : : : "volatile");
2020-04-27T09:23:26.5795310Z    |     ^^^ help: replace the use of the deprecated item: `llvm_asm`
2020-04-27T09:23:26.5829746Z    = note: `-D deprecated` implied by `-D warnings`
2020-04-27T09:23:26.5829937Z 
2020-04-27T09:23:26.5829937Z 
2020-04-27T09:23:26.5830370Z error: use of deprecated item 'asm': the syntax of asm! will change soon, use llvm_asm! to avoid breakage
2020-04-27T09:23:26.5830908Z   --> src/libcore/../stdarch/crates/core_arch/src/x86/eflags.rs:64:5
2020-04-27T09:23:26.5831393Z    |
2020-04-27T09:23:26.5831889Z 64 |     asm!("pushq $0; popfq" : : "r"(eflags) : "cc", "flags" : "volatile");
2020-04-27T09:23:26.5832567Z    |     ^^^ help: replace the use of the deprecated item: `llvm_asm`
2020-04-27T09:23:26.5839895Z 
2020-04-27T09:23:26.5841685Z error: use of deprecated item 'asm': the syntax of asm! will change soon, use llvm_asm! to avoid breakage
2020-04-27T09:23:26.5842406Z   --> src/libcore/../stdarch/crates/core_arch/src/x86/cpuid.rs:68:9
2020-04-27T09:23:26.5843033Z    |
2020-04-27T09:23:26.5843557Z 68 |         asm!("cpuid"
2020-04-27T09:23:26.5844390Z    |         ^^^ help: replace the use of the deprecated item: `llvm_asm`
2020-04-27T09:23:26.5844789Z 
2020-04-27T09:23:26.5845855Z error: use of deprecated item 'asm': the syntax of asm! will change soon, use llvm_asm! to avoid breakage
2020-04-27T09:23:26.5846599Z   --> src/libcore/../stdarch/crates/core_arch/src/x86/xsave.rs:90:5
2020-04-27T09:23:26.5847100Z    |
2020-04-27T09:23:26.5847784Z 90 |     asm!("xgetbv" : "={eax}"(eax), "={edx}"(edx) : "{ecx}"(xcr_no));
2020-04-27T09:23:26.5848818Z    |     ^^^ help: replace the use of the deprecated item: `llvm_asm`
2020-04-27T09:23:26.5849206Z 
2020-04-27T09:23:26.5849833Z error: use of deprecated item 'asm': the syntax of asm! will change soon, use llvm_asm! to avoid breakage
2020-04-27T09:23:26.5850559Z   --> src/libcore/../stdarch/crates/core_arch/src/x86/bt.rs:10:5
2020-04-27T09:23:26.5851039Z    |
2020-04-27T09:23:26.5851640Z 10 |     asm!("btl $2, $1\n\tsetc ${0:b}"
2020-04-27T09:23:26.5852510Z    |     ^^^ help: replace the use of the deprecated item: `llvm_asm`
2020-04-27T09:23:26.5852897Z 
2020-04-27T09:23:26.5896771Z error: use of deprecated item 'asm': the syntax of asm! will change soon, use llvm_asm! to avoid breakage
2020-04-27T09:23:26.5897697Z   --> src/libcore/../stdarch/crates/core_arch/src/x86/bt.rs:23:5
2020-04-27T09:23:26.5898190Z    |
2020-04-27T09:23:26.5898758Z 23 |     asm!("btsl $2, $1\n\tsetc ${0:b}"
2020-04-27T09:23:26.5899581Z    |     ^^^ help: replace the use of the deprecated item: `llvm_asm`
2020-04-27T09:23:26.5899957Z 
2020-04-27T09:23:26.5900518Z error: use of deprecated item 'asm': the syntax of asm! will change soon, use llvm_asm! to avoid breakage
2020-04-27T09:23:26.5901344Z   --> src/libcore/../stdarch/crates/core_arch/src/x86/bt.rs:36:5
2020-04-27T09:23:26.5901803Z    |
2020-04-27T09:23:26.5902343Z 36 |     asm!("btrl $2, $1\n\tsetc ${0:b}"
2020-04-27T09:23:26.5903151Z    |     ^^^ help: replace the use of the deprecated item: `llvm_asm`
2020-04-27T09:23:26.5903528Z 
2020-04-27T09:23:26.5904148Z error: use of deprecated item 'asm': the syntax of asm! will change soon, use llvm_asm! to avoid breakage
2020-04-27T09:23:26.5904914Z   --> src/libcore/../stdarch/crates/core_arch/src/x86/bt.rs:49:5
2020-04-27T09:23:26.5905318Z    |
2020-04-27T09:23:26.5905787Z 49 |     asm!("btcl $2, $1\n\tsetc ${0:b}"
2020-04-27T09:23:26.5906495Z    |     ^^^ help: replace the use of the deprecated item: `llvm_asm`
2020-04-27T09:23:26.5906819Z 
2020-04-27T09:23:26.5907303Z error: use of deprecated item 'asm': the syntax of asm! will change soon, use llvm_asm! to avoid breakage
2020-04-27T09:23:26.5907892Z   --> src/libcore/../stdarch/crates/core_arch/src/x86_64/bt.rs:10:5
2020-04-27T09:23:26.5908297Z    |
2020-04-27T09:23:26.5908767Z 10 |     asm!("btq $2, $1\n\tsetc ${0:b}"
2020-04-27T09:23:26.5909469Z    |     ^^^ help: replace the use of the deprecated item: `llvm_asm`
2020-04-27T09:23:26.5909976Z 
2020-04-27T09:23:26.5910535Z error: use of deprecated item 'asm': the syntax of asm! will change soon, use llvm_asm! to avoid breakage
2020-04-27T09:23:26.5911426Z   --> src/libcore/../stdarch/crates/core_arch/src/x86_64/bt.rs:23:5
2020-04-27T09:23:26.5911929Z    |
2020-04-27T09:23:26.5912508Z 23 |     asm!("btsq $2, $1\n\tsetc ${0:b}"
2020-04-27T09:23:26.5913380Z    |     ^^^ help: replace the use of the deprecated item: `llvm_asm`
2020-04-27T09:23:26.5913785Z 
2020-04-27T09:23:26.5915294Z error: use of deprecated item 'asm': the syntax of asm! will change soon, use llvm_asm! to avoid breakage
2020-04-27T09:23:26.5916032Z   --> src/libcore/../stdarch/crates/core_arch/src/x86_64/bt.rs:36:5
2020-04-27T09:23:26.5916535Z    |
2020-04-27T09:23:26.5917123Z 36 |     asm!("btrq $2, $1\n\tsetc ${0:b}"
2020-04-27T09:23:26.5917990Z    |     ^^^ help: replace the use of the deprecated item: `llvm_asm`
2020-04-27T09:23:26.5918390Z 
2020-04-27T09:23:26.5918990Z error: use of deprecated item 'asm': the syntax of asm! will change soon, use llvm_asm! to avoid breakage
2020-04-27T09:23:26.5919724Z   --> src/libcore/../stdarch/crates/core_arch/src/x86_64/bt.rs:49:5
2020-04-27T09:23:26.5920225Z    |
2020-04-27T09:23:26.5920805Z 49 |     asm!("btcq $2, $1\n\tsetc ${0:b}"
2020-04-27T09:23:26.5921690Z    |     ^^^ help: replace the use of the deprecated item: `llvm_asm`
2020-04-27T09:23:28.0769794Z    Compiling libc v0.2.69
2020-04-27T09:23:28.6027050Z    Compiling autocfg v0.1.7
2020-04-27T09:23:29.7099597Z    Compiling std v0.0.0 (/checkout/src/libstd)
2020-04-27T09:23:30.0554431Z    Compiling compiler_builtins v0.1.27
---
2020-04-27T09:23:34.1709467Z error: could not compile `core`.
2020-04-27T09:23:34.1709973Z 
2020-04-27T09:23:34.1710951Z To learn more, run the command again with --verbose.
2020-04-27T09:23:34.1711501Z warning: build failed, waiting for other jobs to finish...
2020-04-27T09:23:38.3548297Z {"reason":"build-finished","success":false}
2020-04-27T09:23:38.3638774Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "build" "--target" "x86_64-unknown-linux-gnu" "-Zbinary-dep-depinfo" "-j" "2" "--release" "--locked" "--color" "always" "--features" "panic-unwind backtrace compiler-builtins-c" "--manifest-path" "/checkout/src/libtest/Cargo.toml" "--message-format" "json-render-diagnostics"
2020-04-27T09:23:38.3639636Z expected success, got: exit code: 101
2020-04-27T09:23:38.3651716Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test --exclude src/tools/tidy
2020-04-27T09:23:38.3652109Z Build completed unsuccessfully in 0:20:14
2020-04-27T09:23:38.3652109Z Build completed unsuccessfully in 0:20:14
2020-04-27T09:23:38.3704351Z == clock drift check ==
2020-04-27T09:23:38.3730270Z   local time: Mon Apr 27 09:23:38 UTC 2020
2020-04-27T09:23:38.6716985Z   network time: Mon, 27 Apr 2020 09:23:38 GMT
2020-04-27T09:23:40.3037001Z 
2020-04-27T09:23:40.3037001Z 
2020-04-27T09:23:40.3098242Z ##[error]Bash exited with code '1'.
2020-04-27T09:23:40.3111731Z ##[section]Finishing: Run build
2020-04-27T09:23:40.3159572Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/71199/merge to s
2020-04-27T09:23:40.3164255Z Task         : Get sources
2020-04-27T09:23:40.3164634Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-04-27T09:23:40.3165063Z Version      : 1.0.0
2020-04-27T09:23:40.3165255Z Author       : Microsoft
2020-04-27T09:23:40.3165255Z Author       : Microsoft
2020-04-27T09:23:40.3165551Z Help         : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
2020-04-27T09:23:40.3165998Z ==============================================================================
2020-04-27T09:23:40.6222678Z Cleaning any cached credential from repository: rust-lang/rust (GitHub)
2020-04-27T09:23:40.6265218Z ##[section]Finishing: Checkout rust-lang/rust@refs/pull/71199/merge to s
2020-04-27T09:23:40.6359549Z Cleaning up task key
2020-04-27T09:23:40.6361256Z Start cleaning up orphan processes.
2020-04-27T09:23:40.6555526Z Terminate orphan process: pid (4045) (python)
2020-04-27T09:23:40.6706880Z ##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

bors · 2020-04-28T08:20:43Z

☔ The latest upstream changes (presumably #71292) made this pull request unmergeable. Please resolve the merge conflicts.

crlf0710 · 2020-05-15T10:55:00Z

There's a merge conflict now, needs a rebase.

Dylan-DPC-zz · 2020-08-01T14:03:28Z

Gonna close it as it's not important and rework it some other time.

@Dylan-DPC

rust_ast::ast => rustc_ast Rework of rust-lang#71199 which is a rework rust-lang#70621 Still working on this but just made the PR to track progress r? @Dylan-DPC

@Dylan-DPC

rust_ast::ast => rustc_ast Rework of rust-lang#71199 which is a rework rust-lang#70621 Still working on this but just made the PR to track progress r? @Dylan-DPC

rust-highfive assigned eddyb Apr 16, 2020

Dylan-DPC-zz added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 16, 2020

Dylan-DPC-zz mentioned this pull request Apr 16, 2020

Got rid of repetitions (such as rustc_ast::ast::) in librustc_ast. #70621

Closed

rust-highfive assigned petrochenkov and unassigned eddyb Apr 16, 2020

rust-highfive assigned eddyb and unassigned petrochenkov Apr 16, 2020

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 16, 2020

crlf0710 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 24, 2020

ryzokuken force-pushed the refactor/repetitions branch from 7ed48d2 to 1e1a163 Compare April 27, 2020 07:38

rust_ast::ast => rustc_ast

102756b

ryzokuken force-pushed the refactor/repetitions branch from 9eee4ee to 102756b Compare April 27, 2020 17:57

joelpalmer removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label May 7, 2020

joelpalmer added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label May 7, 2020

joelpalmer added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 26, 2020

Elinvynia added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 3, 2020

Elinvynia added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 25, 2020

Muirrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 16, 2020

Muirrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 30, 2020

Dylan-DPC-zz closed this Aug 1, 2020

JulianKnodt mentioned this pull request Aug 3, 2020

rust_ast::ast => rustc_ast #75120

Merged

Dylan-DPC-zz deleted the refactor/repetitions branch August 4, 2020 00:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Got rid of repetitions (such as rustc_ast::ast::) in librustc_ast #71199

Got rid of repetitions (such as rustc_ast::ast::) in librustc_ast #71199

Dylan-DPC-zz commented Apr 16, 2020 •

edited

Loading

rust-highfive commented Apr 16, 2020

eddyb commented Apr 16, 2020

Dylan-DPC-zz commented Apr 16, 2020

petrochenkov commented Apr 16, 2020

petrochenkov commented Apr 16, 2020

Dylan-DPC-zz commented Apr 16, 2020

petrochenkov commented Apr 16, 2020

Dylan-DPC-zz commented Apr 16, 2020

bors commented Apr 16, 2020

bors commented Apr 16, 2020

bors commented Apr 24, 2020

rust-highfive commented Apr 27, 2020

rust-highfive commented Apr 27, 2020

bors commented Apr 28, 2020

crlf0710 commented May 15, 2020

Dylan-DPC-zz commented Aug 1, 2020

Got rid of repetitions (such as rustc_ast::ast::) in librustc_ast #71199

Got rid of repetitions (such as rustc_ast::ast::) in librustc_ast #71199

Conversation

Dylan-DPC-zz commented Apr 16, 2020 • edited Loading

rust-highfive commented Apr 16, 2020

eddyb commented Apr 16, 2020

Dylan-DPC-zz commented Apr 16, 2020

petrochenkov commented Apr 16, 2020

petrochenkov commented Apr 16, 2020

Dylan-DPC-zz commented Apr 16, 2020

petrochenkov commented Apr 16, 2020

Dylan-DPC-zz commented Apr 16, 2020

bors commented Apr 16, 2020

bors commented Apr 16, 2020

bors commented Apr 24, 2020

rust-highfive commented Apr 27, 2020

rust-highfive commented Apr 27, 2020

bors commented Apr 28, 2020

crlf0710 commented May 15, 2020

Dylan-DPC-zz commented Aug 1, 2020

Dylan-DPC-zz commented Apr 16, 2020 •

edited

Loading