Disable try_reserve tests on Android #70958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
Hm, intriguing. I am inclined to land this as android is a tier 2 target and such. I do wonder if a more complete fix is to not call realloc on android (or at least older androids). |
|
In fact, since this is one of the major blockers for our GHA migration, I'm going to @bors r+ it -- cc @pietroalbini. It would be good to post this PR on the internals thread as well, I think, so that folks interested there get a notification. |
|
📌 Commit 7060a9e has been approved by |
|
🌲 The tree is currently closed for pull requests below priority 10, this pull request will be tested once the tree is reopened |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 9, 2020
Rollup of 5 pull requests Successful merges: - rust-lang#70897 (bump Miri) - rust-lang#70900 (Update cargo) - rust-lang#70902 (Update Clippy) - rust-lang#70939 (Add two const generics regression tests) - rust-lang#70958 (Disable try_reserve tests on Android) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
reallocwith large sizes seems to be broken on older Android versions that use dlmalloc as the default allocator. This is not an issue for modern Android versions that use jemalloc.Fixes #55861