Rollup of 5 pull requests #70884
Merged
Rollup of 5 pull requests #70884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears to codegen slightly more efficiently with `split_at` taking two slices at once, rather than slicing across different calls.
It can try to keep its allocation by converting the inner `Box` to `Vec`, using `clone_into` on the bytes, then convert back to `Box`.
Despite OS differences, they're all just `Vec<u8>` inside, so we can just forward `clone_into` calls to that optimized implementation.
Small tweaks in ToOwned::clone_into - `<[T]>::clone_into` is slightly more optimized. - `CStr::clone_into` is new, letting it reuse its allocation. - `OsStr::clone_into` now forwards to the underlying slice/`Vec`.
Miri leak check: memory reachable through globals is not leaked Also make Miri memory dump prettier by sharing more code with MIR dumping, and fix a bug where the Miri memory dump would print some allocations twice. r? @oli-obk Miri PR: rust-lang/miri#1301
…nits, r=alexcrichton Keep codegen units unmerged when building compiler builtins Make it possible to control how mono items are partitioned into code generation units, when compiling the compiler builtins, by retaining the original partitioning. Helps with rust-lang#48625, rust-lang#61063, rust-lang#67960, rust-lang#70489. r? @alexcrichton
…tolnay Use assoc int submodules Bumping some submodules to the commits their masters currently point at. The main point of this is to get the associated integer/float constant documentation updates that were recently merged to them: * rust-lang/nomicon#207 * rust-lang/rust-by-example#1327 * rust-lang/stdarch#848 But for some, a few more changes slipped by that happened to be in the master branch of these submodules. r? @dtolnay
…=dtolnay Don't import integer and float modules, use assoc consts 2 Follow up to rust-lang#70777. I missed quite a lot of places. Partially because I wanted to keep the size of the last PR down, and partially because my regexes were not good enough :) r? @dtolnay
|
@bors r+ rollup=never p=5 |
|
@Dylan-DPC: 🔑 Insufficient privileges: Not in reviewers |
|
@bors r+ rollup=never p=5 |
|
@Dylan-DPC: 🔑 Insufficient privileges: Not in reviewers |
|
@Dylan-DPC: 🔑 Insufficient privileges: not in try users |
|
@bors r+ rollup=never p=5 In the meantime... |
|
@Mark-Simulacrum: 🔑 Insufficient privileges: Not in reviewers |
|
@Mark-Simulacrum: 🔑 Insufficient privileges: not in try users |
|
@bors r+ rollup=never p=5 |
|
📌 Commit 89d661f has been approved by |
bors
added
the
S-waiting-on-bors
|
ah the lucky one :D |
|
☀️ Test successful - checks-azure |
|
📣 Toolstate changed by #70884! Tested on commit 42abbd8. 💔 miri on windows: test-pass → build-fail (cc @oli-obk @eddyb @RalfJung). |
rust-highfive
added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Apr 7, 2020
Tested on commit rust-lang/rust@42abbd8. Direct link to PR: <rust-lang/rust#70884> 💔 miri on windows: test-pass → build-fail (cc @oli-obk @eddyb @RalfJung). 💔 miri on linux: test-pass → build-fail (cc @oli-obk @eddyb @RalfJung). 🎉 nomicon on windows: test-fail → test-pass (cc @Gankra @frewsxcv). 🎉 nomicon on linux: test-fail → test-pass (cc @Gankra @frewsxcv).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
Failed merges:
r? @ghost