-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 10 pull requests #70275
Rollup of 10 pull requests #70275
Commits on Jan 10, 2020
-
Ammend Rc/Arc::from_raw() docs regarding unsafety
Constructing an Rc/Arc is unsafe even if the wrapped `T` is never dereferenced.
Configuration menu - View commit details
-
Copy full SHA for becebf3 - Browse repository at this point
Copy the full SHA becebf3View commit details
Commits on Jan 28, 2020
-
Configuration menu - View commit details
-
Copy full SHA for b4c96a9 - Browse repository at this point
Copy the full SHA b4c96a9View commit details
Commits on Feb 7, 2020
-
Make rc::RcBox and sync::ArcInner repr(C)
Future-proof these types in case rustc reorders the inner fields. As per discussion in PR rust-lang#68099.
Configuration menu - View commit details
-
Copy full SHA for 586c7e3 - Browse repository at this point
Copy the full SHA 586c7e3View commit details
Commits on Mar 20, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 6f6fe38 - Browse repository at this point
Copy the full SHA 6f6fe38View commit details
Commits on Mar 21, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 4d30b92 - Browse repository at this point
Copy the full SHA 4d30b92View commit details -
Configuration menu - View commit details
-
Copy full SHA for a9c2378 - Browse repository at this point
Copy the full SHA a9c2378View commit details -
Configuration menu - View commit details
-
Copy full SHA for 54e103b - Browse repository at this point
Copy the full SHA 54e103bView commit details -
use let instead of match for matches with single bindings (clippy::ma…
…tch_single_binding)
Configuration menu - View commit details
-
Copy full SHA for 1dcbdbd - Browse repository at this point
Copy the full SHA 1dcbdbdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5566a1c - Browse repository at this point
Copy the full SHA 5566a1cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3b4c2f6 - Browse repository at this point
Copy the full SHA 3b4c2f6View commit details -
Return NonZeroU64 from ThreadId::as_u64.
As discussed in rust-lang#67939, this allows turning Option<ThreadId> into Option<NonZeroU64> which can then be stored inside an AtomicU64.
Thomas Bächler committedMar 21, 2020 Configuration menu - View commit details
-
Copy full SHA for c8140a8 - Browse repository at this point
Copy the full SHA c8140a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for a6692b7 - Browse repository at this point
Copy the full SHA a6692b7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 47e9775 - Browse repository at this point
Copy the full SHA 47e9775View commit details -
Configuration menu - View commit details
-
Copy full SHA for e45fdcf - Browse repository at this point
Copy the full SHA e45fdcfView commit details -
Configuration menu - View commit details
-
Copy full SHA for c746d93 - Browse repository at this point
Copy the full SHA c746d93View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3f42104 - Browse repository at this point
Copy the full SHA 3f42104View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3599fd3 - Browse repository at this point
Copy the full SHA 3599fd3View commit details -
don't create variable bindings just to return the bound value immedia…
…tely (clippy::let_and_return)
Configuration menu - View commit details
-
Copy full SHA for 74d68ea - Browse repository at this point
Copy the full SHA 74d68eaView commit details
Commits on Mar 22, 2020
-
Configuration menu - View commit details
-
Copy full SHA for bdd07f9 - Browse repository at this point
Copy the full SHA bdd07f9View commit details -
Rollup merge of rust-lang#68099 - lukaslueg:into_raw_unsafe, r=LukasK…
…albertodt Amend Rc/Arc::from_raw() docs regarding unsafety [This](https://stackoverflow.com/questions/59671647/is-it-safe-to-clone-a-type-erased-arc-via-raw-pointer) question on SO boils down to "is it safe to `::from_raw()` a `Rc<T>`/`Arc<T>` using a dummy `T` even if `T` is never dereferenced via the new `Rc`/`Arc`?". It almost never is. This PR amends the docs of `from_raw()` regarding this point.
Configuration menu - View commit details
-
Copy full SHA for 0bc5fc9 - Browse repository at this point
Copy the full SHA 0bc5fc9View commit details -
Rollup merge of rust-lang#70172 - eddyb:retokenize-external-src, r=pe…
…trochenkov parse/lexer: support `StringReader::retokenize` called on external files. This ~~should theoretically~~ fixes rust-lang#69933, ~~but I'm not sure what the best way to test it is~~. **EDIT**: see rust-lang#69933 (comment). r? @petrochenkov cc @Xanewok @staktrace
Configuration menu - View commit details
-
Copy full SHA for 9890d9a - Browse repository at this point
Copy the full SHA 9890d9aView commit details -
Rollup merge of rust-lang#70209 - Centril:recover-quant-closure, r=pe…
…trochenkov parser: recover on `for<'a> |...| body` closures When encountering `for` and `<` is 1 token ahead, interpret this as an explicitly quantified generic closure and recover, rather than attempting to parse a `for` loop. This provides both improved diagnostics as well as an insurance policy for the ability to use this as the syntax for generic closures in the future. As requested by r? @eddyb
Configuration menu - View commit details
-
Copy full SHA for ea44d71 - Browse repository at this point
Copy the full SHA ea44d71View commit details -
Rollup merge of rust-lang#70223 - lcnr:issue70167, r=eddyb
fix type of const params in associated types. fixes rust-lang#66906 fixes rust-lang#70167 r? @eddyb
Configuration menu - View commit details
-
Copy full SHA for 3c8f8b6 - Browse repository at this point
Copy the full SHA 3c8f8b6View commit details -
Rollup merge of rust-lang#70229 - matthiaskrgr:cl3ppy, r=Mark-Simulacrum
more clippy fixes * remove unused unit values (clippy::unused_unit) * make some let-if-bindings more idiomatic (clippy::useless_let_if_seq) * clarify when we pass () to functions (clippy::unit_arg) * don't redundantly repeat field names (clippy::redundant_field_names) * remove redundant returns (clippy::needless_return) * use let instead of match for matches with single bindings (clippy::match_single_binding) * don't convert results to options just for matching (clippy::if_let_some_result)
Configuration menu - View commit details
-
Copy full SHA for e58fec0 - Browse repository at this point
Copy the full SHA e58fec0View commit details -
Rollup merge of rust-lang#70240 - brain0:thread_id, r=Mark-Simulacrum
Return NonZeroU64 from ThreadId::as_u64. As discussed in rust-lang#67939, this allows turning Option<ThreadId> into Option<NonZeroU64> which can then be stored inside an AtomicU64.
Configuration menu - View commit details
-
Copy full SHA for c882b10 - Browse repository at this point
Copy the full SHA c882b10View commit details -
Rollup merge of rust-lang#70250 - jplatte:patch-1, r=Centril
Remove wrong entry from RELEASES.md resolves rust-lang#70247
Configuration menu - View commit details
-
Copy full SHA for bc3dad1 - Browse repository at this point
Copy the full SHA bc3dad1View commit details -
Rollup merge of rust-lang#70253 - jplatte:patch-2, r=Mark-Simulacrum
Remove another wrong entry from RELEASES.md The entry is under 1.11.0, but the feature is only available since 1.12.0 (for which an identical entry exists). ![Screenshot_2020-03-22 Support `cfg_attr` on `path` attributes by jseyfried · Pull Request rust-lang#34546 · rust-lang rust](https://user-images.githubusercontent.com/951129/77238862-85c8f580-6bd4-11ea-8d31-77e2994a4b5a.png)
Configuration menu - View commit details
-
Copy full SHA for e5d3476 - Browse repository at this point
Copy the full SHA e5d3476View commit details -
Rollup merge of rust-lang#70254 - matthiaskrgr:cl4ppy, r=Centril
couple more clippy fixes (let_and_return, if_same_then_else) * summarize if-else-code with identical blocks (clippy::if_same_then_else) * don't create variable bindings just to return the bound value immediately (clippy::let_and_return)
Configuration menu - View commit details
-
Copy full SHA for 8fe8bad - Browse repository at this point
Copy the full SHA 8fe8badView commit details -
Rollup merge of rust-lang#70266 - petrochenkov:prochead, r=varkor
proc_macro_harness: Use item header spans for errors Addresses rust-lang#70233 (comment).
Configuration menu - View commit details
-
Copy full SHA for 69c0bcd - Browse repository at this point
Copy the full SHA 69c0bcdView commit details