Add GitHub Actions configuration #70190
Conversation
rust-highfive
added
the
S-waiting-on-review
There was a problem hiding this comment.
Generally looks good to me, though I'm not a fan of duplicating the Azure and GitHub CI configs into two separate files, it looks like they're similar enough that's it's not too much trouble to change both.
Could you make sure that the Azure file has a header asking folks to update the GHA file as well? (I don't think I saw one but might have missed it).
| env: | ||
| CI_JOB_NAME: "${{ matrix.name }}" | ||
| SCCACHE_BUCKET: rust-lang-gha-caches | ||
| TOOLSTATE_REPO: "https://github.com/pietroalbini/rust-toolstate" |
There was a problem hiding this comment.
I presume we'll be updating these to point at correct locations when we decide to switch over, roughly speaking?
|
Let's see if it works correctly with try builds. @bors try |
|
⌛ Trying commit a080702fc7582d0c172934112cb9abd2ddb5f7f0 with merge 1bc752e5fdcdf5def64f3228d18e8ae24b1ff36c... |
|
☀️ Try build successful - checks-azure |
|
Ok I need to configure security credentials on the separate organization. |
|
Configured the secrets and added the header to the Azure Pipelines configuration telling contributors to keep GitHub Actions in sync. This is now ready for review @Mark-Simulacrum Let's try this again to make sure the secrets work: |
|
⌛ Trying commit a757a10296032c50e2c589e4eb517ea98d9c7adf with merge 2c50982ca6bf408d009a6da76bc697d25a0d8c37... |
|
☀️ Try build successful - checks-azure |
|
Seems fine to me. As we've discussed previously I'm not really happy with the duplication here but it seems unavoidable (and likely quite temporary) so I'm not too opposed to it. r=me when ready. |
|
Let's do this then! 🎉 @bors r=Mark-Simulacrum rollup |
|
📌 Commit a757a10296032c50e2c589e4eb517ea98d9c7adf has been approved by |
bors
added
S-waiting-on-bors
|
@bors rollup=maybe |
|
@bors rollup This is safe to rollup. |
|
☔ The latest upstream changes (presumably #69894) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
There will be a need to symlink the Linux build directory in the future as well, so let's make the script name generic.
On Azure Pipeliones, the C: filesystem is huge with a lot of free space,
while D: is small. By default builds happened in D:, so we added a
script to symlink the big directories to C:, granting us more space.
Filesystem Size Used Avail Use%
C: 256G 143G 114G 56%
D: 14G 2.0G 13G 15%
On GitHub Actions instead C: is almost full, and we have a lot of free
space on D:, where the build happens.
Filesystem Size Used Avail Use%
C: 128G 114G 15G 89%
D: 56G 4.8G 52G 9%
This commit stops creating the symlink on GitHub Actions, fixing the out
of disk space errors we were seeing on some Windows builders.
The /mnt mount point has 53GB of free disk space at the time of writing this commit, so this moves the build there to avoid running out of disk space during builds.
Moving just the `obj` directory created problems with mountpoints and Docker containers, so this tries to symlink the parent directory.
This will inform contributors tweaking the Azure Pipelines configuration that they also need to tweak the GitHub Actions setup.
|
@bors r=Mark-Simulacrum p=1 rollup- |
|
📌 Commit 45910e7 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-azure |
jyn514
added
T-infra
|
@pietroalbini @Mark-Simulacrum hi here! I'd like to know whether |
|
It's not a self-hosted builder, is a sponsored private pool GitHub is maintaining for us. |
|
@pietroalbini thank you! |
Remove VCVARS_BAT This environment variable is no longer used. It was used in the original Azure Pipelines configuration (rust-lang#60777). When GitHub Actions were added (rust-lang#70190), it was no longer used, and I suspect it was just an oversight while transitioning the configuration.
Remove VCVARS_BAT This environment variable is no longer used. It was used in the original Azure Pipelines configuration (rust-lang#60777). When GitHub Actions were added (rust-lang#70190), it was no longer used, and I suspect it was just an oversight while transitioning the configuration.
This PR adds the GitHub Actions configuration to the rust-lang/rust repository. The configuration will be run in parallel with Azure Pipelines until the evaluation finishes: the infrastructure team will then decide whether to switch.
Since GitHub Actions doesn't currently have any way to include pieces of configuration, this also adds the
src/tools/expand-yaml-anchorstool, which serves as a sort of templating system. Otherwise the configuration is a mostly straight port from the Azure Pipelines configuration (thanks to all the PRs opened in the past).There are still a few small things I need to fix before we can land this, but it's mostly complete and ready for an initial review.
r? @Mark-Simulacrum