Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: use python from the correct path #70116

Merged
merged 1 commit into from
Mar 19, 2020
Merged

ci: use python from the correct path #70116

merged 1 commit into from
Mar 19, 2020

Conversation

pietroalbini
Copy link
Member

Apparently the old path we were using for Python 2 on Windows was not documented, and eventually got removed. This switches our CI to use the correct path.

See #70112 (comment) for the actual failure.

@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 18, 2020
@pietroalbini
Copy link
Member Author

@bors try

@bors
Copy link
Contributor

bors commented Mar 18, 2020

⌛ Trying commit e958ccf3e89ca82f598e5db35c1754e404977d18 with merge 95992c163b7300535652916cf07b3f1e764c9e13...

Mark-Simulacrum
Mark-Simulacrum approved these changes Mar 18, 2020
View reviewed changes
Copy link
Member

@Mark-Simulacrum Mark-Simulacrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me when ready

src/ci/scripts/install-msys2-packages.sh Outdated
cp C:/Python27amd64/python.exe C:/Python27amd64/python2.7.exe
ciCommandAddPath "C:\\Python27amd64"
ls C:/hostedtoolcache/windows/Python/2.7.17/python.exe
cp C:/hostedtoolcache/windows/Python/2.7.17/python.exe C:/hostedtoolcache/windows/Python/2.7.17/python2.7.exe
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't say that this directory name exactly inspires confidence :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh, at least it's somewhat documented.

@rust-highfive
Copy link
Collaborator

Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

@pietroalbini
Copy link
Member Author

@bors try

@bors
Copy link
Contributor

bors commented Mar 18, 2020

⌛ Trying commit 389b4a8e2351e795c32113f92401b923f38e2789 with merge 53f6756b58da4fd288d3994309ce95ef5343063e...

@rust-highfive
Copy link
Collaborator

Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

@bors
Copy link
Contributor

bors commented Mar 18, 2020

💔 Test failed - checks-azure

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 18, 2020
@pietroalbini
Copy link
Member Author

@bors try

@bors
Copy link
Contributor

bors commented Mar 18, 2020

⌛ Trying commit 3c2c4f1701704e1cfdd06e960553d67dac4c4e8b with merge 5434638a2d9607ecbb9be95a4c6f905f8f536b79...

@pietroalbini
Copy link
Member Author

Ok this works now 🎉

@bors r=Mark-Simulacrum p=1000

@bors
Copy link
Contributor

bors commented Mar 18, 2020

📌 Commit 679e14837946f272d163c0c3c1dd825ab683a517 has been approved by Mark-Simulacrum

@bors
Copy link
Contributor

bors commented Mar 18, 2020

🌲 The tree is currently closed for pull requests below priority 5, this pull request will be tested once the tree is reopened

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 18, 2020
@bors
Copy link
Contributor

bors commented Mar 18, 2020

⌛ Testing commit 679e14837946f272d163c0c3c1dd825ab683a517 with merge 6a305af9cf7511487b83085a8db359f9e754a440...

@rust-highfive
Copy link
Collaborator

The job i686-gnu of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
2020-03-18T18:39:39.0976656Z [RUSTC-TIMING] tidy test:false 0.715
2020-03-18T18:39:39.1040467Z     Finished release [optimized] target(s) in 1m 40s
2020-03-18T18:39:39.1088269Z [TIMING] ToolBuild { compiler: Compiler { stage: 0, host: "i686-unknown-linux-gnu" }, target: "i686-unknown-linux-gnu", tool: "tidy", path: "src/tools/tidy", mode: ToolBootstrap, is_optional_tool: false, source_type: InTree, extra_features: [] } -- 100.917
2020-03-18T18:39:39.1089074Z tidy check
2020-03-18T18:39:39.8705603Z tidy error: /checkout/src/ci/scripts/install-msys2-packages.sh:16: line longer than 100 chars
2020-03-18T18:39:43.0141977Z Found 489 error codes
2020-03-18T18:39:43.0142779Z Found 0 error codes with no tests
2020-03-18T18:39:43.0143193Z Done!
2020-03-18T18:39:43.0143535Z some tidy checks failed
2020-03-18T18:39:43.0143535Z some tidy checks failed
2020-03-18T18:39:43.0143965Z 
2020-03-18T18:39:43.0144241Z 
2020-03-18T18:39:43.0145824Z command did not execute successfully: "/checkout/obj/build/i686-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/i686-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor"
2020-03-18T18:39:43.0147110Z 
2020-03-18T18:39:43.0147353Z 
2020-03-18T18:39:43.0148498Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test --exclude src/bootstrap --exclude src/test/rustdoc-js --exclude src/tools/error_index_generator --exclude src/tools/linkchecker
2020-03-18T18:39:43.0149346Z Build completed unsuccessfully in 0:01:54
2020-03-18T18:39:43.0149346Z Build completed unsuccessfully in 0:01:54
2020-03-18T18:39:43.0149805Z == clock drift check ==
2020-03-18T18:39:43.0150261Z   local time: Wed Mar 18 18:39:42 UTC 2020
2020-03-18T18:39:43.0150783Z   network time: Wed, 18 Mar 2020 18:39:42 GMT
2020-03-18T18:39:43.2714926Z == end clock drift check ==
2020-03-18T18:39:43.2958938Z 
2020-03-18T18:39:43.3002923Z ##[error]Bash exited with code '1'.
2020-03-18T18:39:43.3078269Z ##[section]Starting: Checkout rust-lang/rust@auto to s
2020-03-18T18:39:43.3083777Z ==============================================================================
2020-03-18T18:39:43.3084239Z Task         : Get sources
2020-03-18T18:39:43.3084688Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

@bors
Copy link
Contributor

bors commented Mar 18, 2020

💔 Test failed - checks-azure

@bors bors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 18, 2020
@bors bors added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 18, 2020
@pietroalbini
ci: use python from the correct path
779e592 
Apparently the old path we were using for Python 2 on Windows was not
documented, and eventually got removed. This switches our CI to use the
correct path.
@pietroalbini
Copy link
Member Author

Fixed tidy.

@bors r=Mark-Simulacrum p=1

@bors
Copy link
Contributor

bors commented Mar 18, 2020

📌 Commit 779e592 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 18, 2020
@bors
Copy link
Contributor

bors commented Mar 18, 2020

⌛ Testing commit 779e592 with merge add58520c194e8658888efdf1ffc4f81fb5af833...

@pietroalbini pietroalbini mentioned this pull request Mar 18, 2020
Merged
bors added a commit that referenced this pull request Mar 18, 2020
@bors
Auto merge of #70118 - pietroalbini:rollup-pgjc90i, r=pietroalbini
631dd9e 
Rollup of 2 pull requests

Successful merges:

 - #70112 (Rollup of 10 pull requests)
 - #70116 (ci: use python from the correct path)

Failed merges:

r? @ghost
@pietroalbini
Copy link
Member Author

@bors retry

Yield priority.

bors added a commit that referenced this pull request Mar 19, 2020
@bors
Auto merge of #70118 - pietroalbini:rollup-pgjc90i, r=pietroalbini
57e1da5 
Rollup of 2 pull requests

Successful merges:

 - #70112 (Rollup of 10 pull requests)
 - #70116 (ci: use python from the correct path)

Failed merges:

r? @ghost
@bors bors merged commit 94ed071 into rust-lang:master Mar 19, 2020
@pietroalbini pietroalbini deleted the ci-fix-windows-python-path branch March 19, 2020 10:25
@pietroalbini pietroalbini added beta-accepted Accepted for backporting to the compiler in the beta channel. beta-nominated Nominated for backporting to the compiler in the beta channel. stable-nominated Nominated for backporting to the compiler in the stable channel. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Mar 19, 2020
@Mark-Simulacrum Mark-Simulacrum added the stable-accepted Accepted for backporting to the compiler in the stable channel. label Mar 20, 2020
@Mark-Simulacrum
Copy link
Member

(Accepting for stable backport as intrinsically required for any stable release, but obviously not going to produce one just because of this).

@SimonSapin SimonSapin mentioned this pull request Mar 20, 2020
Closed
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Mar 21, 2020
Merged
@Mark-Simulacrum Mark-Simulacrum removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Mar 21, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 22, 2020
@bors
Auto merge of rust-lang#70244 - Mark-Simulacrum:beta-next, r=Mark-Sim…
1eaaee9 
…ulacrum

[beta] backport rollup

This backports:
* can_begin_literal_maybe_minus: `true` on `"-"? lit` NTs. rust-lang#70058
* ci: use python from the correct path rust-lang#70116
* Update stdarch submodule rust-lang#70151 (superseding and closing rust-lang#70221)
* Beta: Update cargo, clippy rust-lang#70105 (also closing that beta-targeted PR)

It also switches the bootstrap compiler to download from static.rust-lang.org from dev-static.rust-lang.org.
@cuviper
Copy link
Member

cuviper commented May 1, 2020

Clearing stable-nominated -- we never did a point release for 1.42, and #70244 went into 1.43.

@cuviper cuviper removed the stable-nominated Nominated for backporting to the compiler in the stable channel. label May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mark-Simulacrum Mark-Simulacrum Mark-Simulacrum approved these changes

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. stable-accepted Accepted for backporting to the compiler in the stable channel. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pietroalbini @rust-highfive @bors @Mark-Simulacrum @cuviper