Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delay_span_bug when codegen cannot select obligation #69614

Merged
merged 1 commit into from
Mar 6, 2020
Merged

delay_span_bug when codegen cannot select obligation #69614

merged 1 commit into from
Mar 6, 2020

Conversation

estebank
Copy link
Contributor

@estebank estebank commented Mar 1, 2020

Fix #69602, introduced in #60126 by letting the compiler continue past
type checking after encountering errors.

@estebank
delay_span_bug when codegen cannot select obligation
7b6f5ed 
Fix rust-lang#69602, introduced in rust-lang#60126 by letting the compiler continue past
type checking after encountering errors.
@rust-highfive
Copy link
Collaborator

r? @davidtwco

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 1, 2020
@davidtwco
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Mar 2, 2020

📌 Commit 7b6f5ed has been approved by davidtwco

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 2, 2020
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Mar 5, 2020
@JohnTitor
Rollup merge of rust-lang#69614 - estebank:ice-age, r=davidtwco
e067bf4 
`delay_span_bug` when codegen cannot select obligation

Fix rust-lang#69602, introduced in rust-lang#60126 by letting the compiler continue past
type checking after encountering errors.
@JohnTitor JohnTitor mentioned this pull request Mar 5, 2020
Closed
bors added a commit that referenced this pull request Mar 5, 2020
@bors
Auto merge of #69724 - JohnTitor:rollup-vv7w65h, r=JohnTitor
f6c22f0 
Rollup of 10 pull requests

Successful merges:

 - #69520 (Make error message clearer about creating new module)
 - #69589 (ast: `Mac`/`Macro` -> `MacCall`)
 - #69614 (`delay_span_bug` when codegen cannot select obligation)
 - #69641 (Update books)
 - #69674 (Rename DefKind::Method and TraitItemKind::Method )
 - #69697 (Add explanation for E0380)
 - #69698 (Use associated constants of integer types)
 - #69705 (Toolstate: remove redundant beta-week check.)
 - #69711 (Update macros.rs: fix documentation typo.)
 - #69713 (more clippy cleanups)

Failed merges:

r? @ghost
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Mar 5, 2020
@JohnTitor
Rollup merge of rust-lang#69614 - estebank:ice-age, r=davidtwco
273c5b2 
`delay_span_bug` when codegen cannot select obligation

Fix rust-lang#69602, introduced in rust-lang#60126 by letting the compiler continue past
type checking after encountering errors.
@JohnTitor JohnTitor mentioned this pull request Mar 5, 2020
Closed
@bors
Copy link
Contributor

bors commented Mar 6, 2020

⌛ Testing commit 7b6f5ed with merge 865b44a...

@pietroalbini
Copy link
Member

@bors treeclosed=1000 msys2/MSYS2-packages#1884

@eddyb
Copy link
Member

eddyb commented Mar 6, 2020 •
edited
Loading

@estebank Wouldn't it be simpler to just not run any codegen if there are errors?
Codegen can take quite a while and I don't see any point in doing it.
(Not to mention that we should never emit artifacts that are wrong even if we can codegen)

@bors bors mentioned this pull request Mar 6, 2020
Merged
@bors
Copy link
Contributor

bors commented Mar 6, 2020

☀️ Test successful - checks-azure
Approved by: davidtwco
Pushing 865b44a to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 6, 2020
@bors bors merged commit 865b44a into rust-lang:master Mar 6, 2020
@bors bors mentioned this pull request Mar 6, 2020
Merged
@estebank
Copy link
Contributor Author

estebank commented Mar 6, 2020

@eddyb that's fair, but from my cursory look we do have errors that were being elided before. The fewer iterations people need to fix their code, the better. That being said, we could stop after lifetime checking instead.

@eddyb
Copy link
Member

eddyb commented Mar 6, 2020 •
edited
Loading

@estebank Codegen should be separate from the rest of the compilation, in rustc_interface, but I suppose you should talk to @Zoxc since I'm not too familiar with the new system.

I agree on continuing after typeck, and we can continue after all the checks, as long as we don't let codegen start (which is strictly a waste of time).

@estebank estebank mentioned this pull request Mar 6, 2020
Open
@estebank estebank deleted the ice-age branch November 9, 2023 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtwco davidtwco davidtwco approved these changes

Assignees

@davidtwco davidtwco

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
6 participants
@estebank @rust-highfive @davidtwco @bors @pietroalbini @eddyb