Adjust Miri value visitor, and doc-comment layout components #69257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
RalfJung
force-pushed
the
layout-visitor
branch
from
834b640
to
be34533
Compare
RalfJung
force-pushed
the
layout-visitor
branch
from
be34533
to
bd979ed
Compare
oli-obk
approved these changes
Feb 19, 2020
|
r? @eddyb for the rest |
eddyb
reviewed
Feb 26, 2020
eddyb
reviewed
Feb 26, 2020
eddyb
reviewed
Feb 26, 2020
eddyb
reviewed
Feb 26, 2020
eddyb
reviewed
Feb 26, 2020
eddyb
reviewed
Feb 26, 2020
eddyb
reviewed
Feb 26, 2020
eddyb
reviewed
Feb 26, 2020
eddyb
reviewed
Feb 26, 2020
eddyb
reviewed
Feb 26, 2020
eddyb
reviewed
Feb 26, 2020
This comment has been minimized.
This comment has been minimized.
RalfJung
force-pushed
the
layout-visitor
branch
from
3492188
to
12054dc
Compare
RalfJung
commented
Feb 26, 2020
eddyb
approved these changes
Mar 2, 2020
|
@bors r+ |
|
📌 Commit 12054dc has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-azure |
rust-highfive
added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Mar 2, 2020
Tested on commit rust-lang/rust@c839a7b. Direct link to PR: <rust-lang/rust#69257> 💔 rls on linux: test-pass → test-fail (cc @Xanewok).
bors
added a commit
to rust-lang/miri
that referenced
this pull request
Mar 2, 2020
adjust for rustc changes The Miri side of rust-lang/rust#69257
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized that I still didn't have quite the right intuition for how our
LayoutDetailswork, so I had to adjust the Miri value visitor to the things I understood better now. I also added some doc-comments toLayoutDetailsas a hopefully canonical place to note such things.The main visitor change is that we first look at all the fields (according to
FieldPlacement), and then check the variants and handleMultipleappropriately. I did not quite realize how orthogonal "fields" and "variants" are.I also moved the check for the scalar ABI to after checking all the fields; this leads to better (more type-driven) error messages.
And it looks like we can finally remove that magic hack for
ty::Generator. :Dr? @oli-obk for the Miri/visitor changes and @eddyb for the layout docs
The Miri PR is at: rust-lang/miri#1178