Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: Buffer stderr when writing json errors/warnings #69227

Merged
merged 2 commits into from
Feb 29, 2020
Merged

perf: Buffer stderr when writing json errors/warnings #69227

merged 2 commits into from
Feb 29, 2020

Commits on Feb 17, 2020

  1. perf: Buffer stderr when writing json errors/warnings 

    Since `stderr` is unbuffered, writing out json messages actually take up
about ~10%/0.1s of the runtime of the `inflate` benchmark.

cc rust-lang#64413
    Markus Westerlind committed Feb 17, 2020
    Configuration menu
    Copy the full SHA
    7ac4154 View commit details
    Browse the repository at this point in the history

  2. Ensure diagnostics are printed in the correct order 

    Even when buffered. Ideally we would flush only when the emitter is
done, but that requires larger changes. This gives most of the benefit
of buffering in any case.
    Markus Westerlind committed Feb 17, 2020
    Configuration menu
    Copy the full SHA
    ee064be View commit details
    Browse the repository at this point in the history