Do not ICE on multipart suggestions touching multiple files #68530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When encountering a multipart suggestion with spans belonging to different contexts, skip that suggestion.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
Depending on the beta cut-off, this might need backporting to beta. |
estebank
added
beta-nominated
|
@bors r+ |
|
📌 Commit b626202 has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Jan 25, 2020
Do not ICE on multipart suggestions touching multiple files When encountering a multipart suggestion with spans belonging to different contexts, skip that suggestion. Fix rust-lang#68449. Similar to rust-lang#68256.
|
☀️ Test successful - checks-azure |
|
Would be good to have had a test here =) Seems like a subtle bug we would want to be able to test for |
|
discussed at T-compiler triage meeting. approved for beta backport. |
pnkfelix
added
the
beta-accepted
|
This appears to already be in beta? At least cherry-picking the commit here gives me an empty commit. Denominating. |
Mark-Simulacrum
removed
beta-accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When encountering a multipart suggestion with spans belonging to
different contexts, skip that suggestion.
Fix #68449. Similar to #68256.