Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize the debug_map_key_value feature #68200

Merged
merged 1 commit into from
Jan 28, 2020
Merged

Stabilize the debug_map_key_value feature #68200

merged 1 commit into from
Jan 28, 2020

Conversation

KodrAus
Copy link
Contributor

@KodrAus KodrAus commented Jan 14, 2020

RFC: rust-lang/rfcs#2696
Tracking issue: #62482

Stabilizes the debug_map_key_value feature, which covers:

impl<'a, 'b> DebugMap<'a, 'b> {
    pub fn key(&mut self, key: &dyn fmt::Debug) -> &mut DebugMap<'a, 'b> {}
    pub fn value(&mut self, value: &dyn fmt::Debug) -> &mut DebugMap<'a, 'b> {}
}

These methods are small and self-contained, and are used as the basis for the existing DebugMap::entry method, so have been used in the wild for the last 6 months or so.

@KodrAus KodrAus added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. relnotes Marks issues that should be documented in the release notes of the next release. labels Jan 14, 2020
@rust-highfive
Copy link
Collaborator

r? @kennytm

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 14, 2020
@KodrAus
Copy link
Contributor Author

KodrAus commented Jan 14, 2020

@rfcbot fcp merge

@rfcbot
Copy link

rfcbot commented Jan 14, 2020 •
edited by dtolnay
Loading

Team member @KodrAus has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Jan 14, 2020
@JohnTitor JohnTitor added S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 14, 2020
@rust-highfive rust-highfive assigned KodrAus and unassigned kennytm Jan 14, 2020
@kennytm
Copy link
Member

kennytm commented Jan 14, 2020

r? @alexcrichton

@jonas-schievink jonas-schievink added this to the 1.42 milestone Jan 14, 2020
@rfcbot rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Jan 14, 2020
@rfcbot
Copy link

rfcbot commented Jan 14, 2020

🔔 This is now entering its final comment period, as per the review above. 🔔

@bors
Copy link
Contributor

bors commented Jan 17, 2020

☔ The latest upstream changes (presumably #66716) made this pull request unmergeable. Please resolve the merge conflicts.

@rfcbot rfcbot added the finished-final-comment-period The final comment period is finished for this PR / Issue. label Jan 24, 2020
@rfcbot
Copy link

rfcbot commented Jan 24, 2020

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

The RFC will be merged soon.

@rfcbot rfcbot removed the final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. label Jan 24, 2020
@alexcrichton
Copy link
Member

r=me with a rebase!

@KodrAus
Copy link
Contributor Author

KodrAus commented Jan 28, 2020

@bors r=alexcrichton rollup

@bors
Copy link
Contributor

bors commented Jan 28, 2020

📌 Commit 2c07a62 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). labels Jan 28, 2020
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Jan 28, 2020
@JohnTitor
Rollup merge of rust-lang#68200 - KodrAus:stabilize/debug_map_key_val…
5c42ffe 
…ue, r=alexcrichton

Stabilize the debug_map_key_value feature

RFC: rust-lang/rfcs#2696
Tracking issue: rust-lang#62482

Stabilizes the `debug_map_key_value` feature, which covers:

```rust
impl<'a, 'b> DebugMap<'a, 'b> {
    pub fn key(&mut self, key: &dyn fmt::Debug) -> &mut DebugMap<'a, 'b> {}
    pub fn value(&mut self, value: &dyn fmt::Debug) -> &mut DebugMap<'a, 'b> {}
}
```

These methods are small and self-contained, and are used as the basis for the existing `DebugMap::entry` method, so have been used in the wild for the last 6 months or so.
@JohnTitor JohnTitor mentioned this pull request Jan 28, 2020
Merged
bors added a commit that referenced this pull request Jan 28, 2020
@bors
Auto merge of #68587 - JohnTitor:rollup-fz45xwc, r=JohnTitor
67fae22 
Rollup of 11 pull requests

Successful merges:

 - #68200 (Stabilize the debug_map_key_value feature)
 - #68383 (Clean up E0205 explanation)
 - #68412 (Clean up E0207 explanation)
 - #68454 (clean up E0214 explanation)
 - #68482 (clean up error codes explanation)
 - #68563 (Don't call `tcx.fn_sig` on closures)
 - #68570 (Bump LLVM submodule to fix LLVM assertion failure in MSP430 interrupt generation.)
 - #68571 (check_match: extract common logic)
 - #68573 (Clean up E0262 explanation)
 - #68575 (Disable the testcase for Vxworks.)
 - #68581 (Add support for icebreakers-cleanup-crew commands)

Failed merges:

r? @ghost
@bors bors merged commit 2c07a62 into rust-lang:master Jan 28, 2020
@KodrAus KodrAus mentioned this pull request Jul 22, 2020
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.42
Development

Successfully merging this pull request may close these issues.
8 participants
@KodrAus @rust-highfive @rfcbot @kennytm @bors @alexcrichton @jonas-schievink @JohnTitor