Rollup of 7 pull requests #68158
Closed
Rollup of 7 pull requests #68158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clippy needs it
…s̶dataflow, r=ecstatic-morse Document more use cases of dataflow r? @ecstatic-morse
rustdoc: improve stability mark arrows ### current  ### new  ### new dark 
Clean up some diagnostics by making them more consistent In general: - Diagnostic should start with a lowercase letter. - Diagnostics should not end with a full stop. - Ellipses contain three dots. - Backticks should encode Rust code. I also reworded a couple of messages to make them read more clearly. It might be sensible to create a style guide for diagnostics, so these informal conventions are written down somewhere, after which we could audit the existing diagnostics. r? @Centril
Specify units for test timeout environment variables I think it is not obvious (I got it from reading libtest sources), so it is worth mentioning in docs.
…ities, r=Centril restore some rustc_parse visibilities for rustfmt In rust-lang@c189565 some visibilities were reduced on the parse mod (which now resides in the rustc_parse crate) as part of some refactoring and splitting up of libsyntax. However, rustfmt needs access to a few of those items that are no longer visible. This restores the visibility on those items rustfmt depends on. rust-lang/rustfmt#3903 (comment) rust-lang/rustfmt#4009 cc @topecongiro
…t, r=Centril Expose `context::CheckLintNameResult` Clippy needs it r? @Centril
…lan-DPC Clean up E0186 explanation r? @Dylan-DPC
|
@bors r+ rollup=never p=7 |
|
📌 Commit 30d7419 has been approved by |
bors
added
the
S-waiting-on-bors
|
⌛ Testing commit 30d7419 with merge 24127dc5d2ab9f6e92f2affff50cf643c2ec748a... |
|
💔 Test failed - checks-azure |
bors
added
S-waiting-on-review
|
Failing spuriously. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
context::CheckLintNameResult#68145 (Exposecontext::CheckLintNameResult)Failed merges:
r? @ghost