Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustpkg: extern mod inference #6807

Closed
wants to merge 5 commits into from
Closed

rustpkg: extern mod inference #6807

wants to merge 5 commits into from

Commits on Jun 2, 2013

  1. rustc: Improve astconv error message

    @catamorphism
    catamorphism committed Jun 2, 2013
    Configuration menu
    Copy the full SHA
    231aea6 View commit details
    Browse the repository at this point in the history

  2. syntax: Add an each_view_item method on traits

    @catamorphism
    catamorphism committed Jun 2, 2013
    Configuration menu
    Copy the full SHA
    760c71d View commit details
    Browse the repository at this point in the history

  3. rustc: Call str::is_empty

    @catamorphism
    catamorphism committed Jun 2, 2013
    Configuration menu
    Copy the full SHA
    341678b View commit details
    Browse the repository at this point in the history

  4. rustc/rusti/rustpkg: Infer packages from extern mod directives 

    This commit won't be quite as useful until I implement RUST_PATH and
until we change `extern mod` to take a general string instead of
an identifier (rust-lang#5682 and rust-lang#6407).

With that said, now if you're using rustpkg and a program contains:

extern mod foo;

rustpkg will attempt to search for `foo`, so that you don't have to
provide a -L directory explicitly. In addition, rustpkg will
actually try to build and install `foo`, unless it's already
installed (specifically, I tested that `extern mod extra;` would
not cause it to try to find source for `extra` and compile it
again).

This is as per rust-lang#5681.

Incidentally, I changed some driver code to infer the link name
from the crate link_meta attributes. If that change isn't ok, say
something. Also, I changed the addl_lib_search_paths field in the
session options to be an @mut ~[Path] so that it can be modified
after expansion but before later phases.
    @catamorphism
    catamorphism committed Jun 2, 2013
    Configuration menu
    Copy the full SHA
    c120464 View commit details
    Browse the repository at this point in the history

  5. testsuite: Add an xfailed test case for the new extern mod syntax

    @catamorphism
    catamorphism committed Jun 2, 2013
    5 Configuration menu
    Copy the full SHA
    60126e9 View commit details
    Browse the repository at this point in the history