Nix reexports from rustc_span in syntax
#67786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
bors
added
the
S-waiting-on-author
|
@bors r+ |
|
📌 Commit 059bdee2a99f46cadd33c8fb2c76a172b65e48fa has been approved by |
bors
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
bors
added
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@bors r=petrochenkov |
|
📌 Commit 6e4ea14 has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jan 4, 2020
Nix reexports from `rustc_span` in `syntax`
Remove reexports `syntax::{source_map, symbol, edition}` and use `rustc_span` paths directly.
r? @petrochenkov
bors
added a commit
that referenced
this pull request
Jan 4, 2020
Rollup of 8 pull requests Successful merges: - #66913 (Suggest calling method when first argument is `self`) - #67531 (no longer promote non-pattern const functions) - #67773 (Add a test for #37333) - #67786 (Nix reexports from `rustc_span` in `syntax`) - #67789 (Cleanup linkchecker whitelist) - #67810 (Implement uncommon_codepoints lint.) - #67835 (tweak wording of mismatched delimiter errors) - #67845 (Also remove const-hack for abs) Failed merges: r? @ghost
phansch
added a commit
to phansch/rust-clippy
that referenced
this pull request
Jan 4, 2020
Specifically caused by rust-lang/rust#67786
phansch
added a commit
to phansch/rust-clippy
that referenced
this pull request
Jan 4, 2020
Specifically caused by rust-lang/rust#67786
bors
added a commit
to rust-lang/rust-clippy
that referenced
this pull request
Jan 4, 2020
Rustup to rust-lang/rust#67853 Specifically caused by rust-lang/rust#67786 changelog: none
Xanewok
added a commit
to rust-lang/rls
that referenced
this pull request
Jan 4, 2020
calebcartwright
added a commit
to calebcartwright/rustfmt
that referenced
this pull request
Jan 16, 2020
syntax_pos was renamed to rustc_span rust-lang/rust#67707 and modules like `symbol` and `source_map` are no longer re-exported in libsyanx so we also need to consume them directly from the rustc_span crate rust-lang/rust#67786
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Apr 18, 2020
Move `MapInPlace` to rustc_data_structures Follow-up of rust-lang#67786, it fits the purpose of rustc_data_structures. r? @petrochenkov
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Apr 18, 2020
Move `MapInPlace` to rustc_data_structures Follow-up of rust-lang#67786, it fits the purpose of rustc_data_structures. r? @petrochenkov
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Apr 18, 2020
Move `MapInPlace` to rustc_data_structures Follow-up of rust-lang#67786, it fits the purpose of rustc_data_structures. r? @petrochenkov
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove reexports
syntax::{source_map, symbol, edition}and userustc_spanpaths directly.r? @petrochenkov