Cleanup pattern type checking, fix diagnostics bugs (+ improvements) #67730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing wording was inappropriate for e.g.
`if let Ok(_) = expr { .. }`. The diagnostic would
leak the fact that we desugar to a `match`.
TODO: The type is wrong and will be fixed in later commits.
Current name is too specific for incoming changes.
when type checking `<pat>`.
rust-highfive
added
the
S-waiting-on-review
Centril
commented
Dec 30, 2019
| @@ -8,7 +8,7 @@ error[E0308]: mismatched types | |||
| --> $DIR/exclusive_range_pattern_syntax_collision.rs:5:13 | |||
| | | |||
| LL | match [5..4, 99..105, 43..44] { | |||
| | ----------------------- this match expression has type `std::ops::Range<{integer}>` | |||
| | ----------------------- this expression has type `[std::ops::Range<{integer}>; 3]` | |||
There was a problem hiding this comment.
Here is the bug fix (it was saying that the array expression was in fact of a range type).
| @@ -0,0 +1,49 @@ | |||
| error[E0308]: mismatched types | |||
There was a problem hiding this comment.
The improvements (and in the other new tests).
estebank
approved these changes
Dec 31, 2019
|
@bors r=estebank |
|
📌 Commit 63dc0e4 has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Dec 31, 2019
Cleanup pattern type checking, fix diagnostics bugs (+ improvements) r? @estebank
bors
added a commit
that referenced
this pull request
Dec 31, 2019
Rollup of 6 pull requests Successful merges: - #67574 (Extract `rustc_ast_lowering` crate from `rustc`) - #67685 (Constify Result) - #67702 (Add symbol normalization for proc_macro_server.) - #67730 (Cleanup pattern type checking, fix diagnostics bugs (+ improvements)) - #67744 (parser: reduce diversity in error handling mechanisms) - #67748 (Use function attribute "frame-pointer" instead of "no-frame-pointer-elim") Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @estebank