tidy: Enforce formatting rather than just check it if --bless is specified
#67701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ rollup |
|
📌 Commit 5b80a99 has been approved by |
bors
added
S-waiting-on-bors
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Dec 30, 2019
…lacrum tidy: Enforce formatting rather than just check it if `--bless` is specified Ensuring the "tidy"-ness currently requires running `rustfmt` twice: ```sh ./x.py fmt && ./x.py test tidy ``` , once to actually format code and the second time as a part of tidy to check that the code is formatted. Running `rustfmt` is slow, so we don't want to run it twice. With this PR tidy enforces the formatting rather than just checks it if `--bless` was passed to it: ```sh ./x.py test tidy --bless ``` r? @Mark-Simulacrum
bors
added a commit
that referenced
this pull request
Dec 30, 2019
Rollup of 10 pull requests Successful merges: - #64273 (Stabilize attribute macros on inline modules) - #67287 (typeck: note other end-point when checking range pats) - #67564 (docs: Iterator adapters have unspecified results after a panic) - #67622 (Some keyword documentation.) - #67657 (Clean up const-hack PRs now that const if / match exist.) - #67677 (resolve: Minor cleanup of duplicate macro reexports) - #67687 (Do not ICE on lifetime error involving closures) - #67698 (Move reachable_set and diagnostic_items to librustc_passes.) - #67701 (tidy: Enforce formatting rather than just check it if `--bless` is specified) - #67715 (Typo fix) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensuring the "tidy"-ness currently requires running
rustfmttwice:, once to actually format code and the second time as a part of tidy to check that the code is formatted.
Running
rustfmtis slow, so we don't want to run it twice.With this PR tidy enforces the formatting rather than just checks it if
--blesswas passed to it:./x.py test tidy --blessr? @Mark-Simulacrum