Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add long error explanation for E0578 #65471

Merged
merged 2 commits into from
Nov 1, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 28 additions & 1 deletion src/librustc_resolve/error_codes.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1850,6 +1850,34 @@ fn main() {}
```
"##,

E0578: r##"
A module cannot be found and therefore, the visibility cannot be determined.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comma here is odd. Either 'therefore' is an optional part of the sentence in which case it needs a comma before as well as after, or it's not optional and the comma is unnecessary.

e.g.

A module cannot be found and, therefore, the visibility cannot be determined.

vs.

A module cannot be found and therefore the visibility cannot be determined.


Erroneous code example:

```compile_fail,E0578,edition2018
foo!();

pub (in ::Sea) struct Shark; // error!

fn main() {}
```

Because of the call to the `foo` macro, the compiler guesses that the missing
module could be inside it and fails because the macro definition cannot be
found.

To fix this error, please be sure that the module is in scope:

```edition2018
pub mod Sea {
pub (in crate::Sea) struct Shark;
}

fn main() {}
```
"##,

E0603: r##"
A private item was used outside its scope.

Expand Down Expand Up @@ -2017,5 +2045,4 @@ fn main() {}
// E0427, merged into 530
// E0467, removed
// E0470, removed
E0578,
}
1 change: 1 addition & 0 deletions src/test/ui/resolve/visibility-indeterminate.stderr
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,4 @@ LL | foo!();

error: aborting due to 2 previous errors

For more information about this error, try `rustc --explain E0578`.