Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use span label instead of note in unreachable lint #64669

Merged
merged 2 commits into from
Sep 22, 2019
Merged

Use span label instead of note in unreachable lint #64669

merged 2 commits into from
Sep 22, 2019

Conversation

estebank
Copy link
Contributor

Fix #64636.

@rust-highfive
Copy link
Collaborator

r? @varkor

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 21, 2019
Centril
Centril reviewed Sep 21, 2019
View reviewed changes
Copy link
Contributor

@Centril Centril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with suggestions applied.

src/test/ui/lint/unreachable-async-fn.rs Outdated Show resolved Hide resolved
src/test/ui/lint/unreachable-async-fn.rs Show resolved Hide resolved
src/test/ui/lint/unreachable-async-fn.rs Show resolved Hide resolved
@Centril
Copy link
Contributor

Centril commented Sep 21, 2019

r? @Centril

@rust-highfive rust-highfive assigned Centril and unassigned varkor Sep 21, 2019
@Centril
Copy link
Contributor

Centril commented Sep 21, 2019

@bors p=2

@estebank
Copy link
Contributor Author

@bors r=Centril

@bors
Copy link
Contributor

bors commented Sep 21, 2019

📌 Commit 9991d54 has been approved by Centril

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 21, 2019
@bors
Copy link
Contributor

bors commented Sep 22, 2019

⌛ Testing commit 9991d54 with merge 4ff32c0...

bors added a commit that referenced this pull request Sep 22, 2019
@bors
Auto merge of #64669 - estebank:unreachable, r=Centril
4ff32c0 
Use span label instead of note in unreachable lint

Fix #64636.
@bors
Copy link
Contributor

bors commented Sep 22, 2019

☀️ Test successful - checks-azure
Approved by: Centril
Pushing 4ff32c0 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 22, 2019
@bors bors merged commit 9991d54 into rust-lang:master Sep 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Centril Centril Centril left review comments

Assignees

@Centril Centril

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

async functions with unimplemented!() are marked as unreachable
5 participants
@estebank @rust-highfive @Centril @bors @varkor