-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 10 pull requests #64647
Rollup of 10 pull requests #64647
Commits on Sep 13, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 612ef5f - Browse repository at this point
Copy the full SHA 612ef5fView commit details -
Configuration menu - View commit details
-
Copy full SHA for e69d1b6 - Browse repository at this point
Copy the full SHA e69d1b6View commit details
Commits on Sep 14, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 6e5ada4 - Browse repository at this point
Copy the full SHA 6e5ada4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7217591 - Browse repository at this point
Copy the full SHA 7217591View commit details
Commits on Sep 16, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 194d357 - Browse repository at this point
Copy the full SHA 194d357View commit details
Commits on Sep 17, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 3f004a1 - Browse repository at this point
Copy the full SHA 3f004a1View commit details
Commits on Sep 18, 2019
-
Configuration menu - View commit details
-
Copy full SHA for a9c38d9 - Browse repository at this point
Copy the full SHA a9c38d9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 31b3012 - Browse repository at this point
Copy the full SHA 31b3012View commit details
Commits on Sep 19, 2019
-
rustbuild: Turn down compression on exe installers
The Windows dist builders are the slowest builders right now, and the distribution phase of them is enormously slow clocking in at around 20 minutes to build all the related installers. This commit starts to optimize these by turning down the compression level in the `exe` installers. These aren't super heavily used so there's no great need for them to be so ultra-compressed, so let's dial back the compression parameters to get closer to the rest of our xz archives. This brings the installer in line with the gz tarball installer locally, and also brings the compression settings on par with the rest of our xz installers.
Configuration menu - View commit details
-
Copy full SHA for 8112f71 - Browse repository at this point
Copy the full SHA 8112f71View commit details -
factor out pluralisation remains after rust-lang#64280
gaolei committedSep 19, 2019 Configuration menu - View commit details
-
Copy full SHA for 1ab5593 - Browse repository at this point
Copy the full SHA 1ab5593View commit details -
rustbuild: Turn down compression on msi installers
This is the same as rust-lang#64615 except applied to our MSI installers. The same fix is applied effectively bringing these installers in line with the gz tarball installers, which are about 3x faster to produce locally and likely much faster to produce on CI.
Configuration menu - View commit details
-
Copy full SHA for fde8cfe - Browse repository at this point
Copy the full SHA fde8cfeView commit details -
rustbuild: Improve output of
dist
step* Pass `/Q` to `iscc` on Windows to supress the thousands of lines of output about compressing documentation. * Print out what's happening before long steps * Use `timeit` to print out timing information for long-running installer assemblies.
Configuration menu - View commit details
-
Copy full SHA for 255dd3f - Browse repository at this point
Copy the full SHA 255dd3fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3db2c13 - Browse repository at this point
Copy the full SHA 3db2c13View commit details
Commits on Sep 20, 2019
-
remove the extra comma after the match arm
This would follow the same coding style as all the other match arms in this file.
guanqun committedSep 20, 2019 Configuration menu - View commit details
-
Copy full SHA for c3140ba - Browse repository at this point
Copy the full SHA c3140baView commit details -
Exempt extern "Rust" from improper_ctypes
It should be fine for Rust ABIs to involve any Rust type.
Configuration menu - View commit details
-
Copy full SHA for 9f374da - Browse repository at this point
Copy the full SHA 9f374daView commit details
Commits on Sep 21, 2019
-
Rollup merge of rust-lang#64047 - timvermeulen:cmp_min_max_by, r=cuviper
Add `cmp::{min_by, min_by_key, max_by, max_by_key}` This adds the following functions to `core::cmp`: - `min_by` - `min_by_key` - `max_by` - `max_by_key` `min_by` and `max_by` are somewhat trivial to implement, but not entirely because `min_by` returns the first value in case the two are equal (and `max_by` the second). `min` and `max` can be implemented in terms of `min_by` and `max_by`, but not as easily the other way around. To give an example of why I think these functions could be useful: the `Iterator::{min_by, min_by_key, max_by, max_by_key}` methods all currently hard-code the behavior mentioned above which is an ever so small duplication of logic. If we delegate them to `cmp::{min_by, max_by}` methods instead, we get the correct behavior for free. (edit: this is now included in the PR) I added `min_by_key` / `max_by_key` for consistency's sake but I wouldn't mind removing them. I don't have a particular use case in mind for them, and `min_by` / `max_by` seem to be more useful. Tracking issue: rust-lang#64460
Configuration menu - View commit details
-
Copy full SHA for 14e672c - Browse repository at this point
Copy the full SHA 14e672cView commit details -
Rollup merge of rust-lang#64136 - crgl:doc-from-parser-lhs, r=Centril
Document From trait for LhsExpr in parser Add doc for From trait for converting P<Expr> and Option<ThinVec<Attribute>> to LhsExpr As part of issue rust-lang#51430 (cc @skade). Both of these should just be moving an address and setting a discriminant in an enum. The main thing I'm not sure about is whether it's worth documenting the branch in the From<Option<ThinVec<Attribute>>. As far as I can tell it doesn't seem like it is optimized away (although if the discriminant happened to work out you could just copy the pointer and the discriminant which might be cheaper, but that's not guaranteed). So it seems like if it's being called often, it's doubling the number of possible branch mispredictions on this Option, which could be a significant cost. Let me know if there's anything that needs fixing and I'll get to it as soon as possible!
Configuration menu - View commit details
-
Copy full SHA for 73da248 - Browse repository at this point
Copy the full SHA 73da248View commit details -
Rollup merge of rust-lang#64342 - glorv:master, r=varkor
factor out pluralisation remains after rust-lang#64280 there are two case that doesn't not match the original macro pattern at [here](https://github.com/rust-lang/rust/blob/master/src/librustc_lint/unused.rs#L146) and [here](https://github.com/rust-lang/rust/blob/master/src/libsyntax/parse/diagnostics.rs#L539) as the provided param is already a bool or the check condition is not `x != 1`, so I change the macro accept a boolean expr instead of number to fit all the cases. @Centril please review Fixes rust-lang#64238.
Configuration menu - View commit details
-
Copy full SHA for b9412b0 - Browse repository at this point
Copy the full SHA b9412b0View commit details -
Rollup merge of rust-lang#64546 - weiznich:bugfix/rfc-2451-rerebalanc…
…e-tests, r=nikomatsakis Bugfix/rfc 2451 rerebalance tests r? @nikomatsakis Fixes rust-lang#64412 Depends/Contains on rust-lang#64414 cc rust-lang#55437 and rust-lang#63599
Configuration menu - View commit details
-
Copy full SHA for 4ca6a8d - Browse repository at this point
Copy the full SHA 4ca6a8dView commit details -
Rollup merge of rust-lang#64615 - alexcrichton:smaller-exe, r=Mark-Si…
…mulacrum rustbuild: Turn down compression on exe installers The Windows dist builders are the slowest builders right now, and the distribution phase of them is enormously slow clocking in at around 20 minutes to build all the related installers. This commit starts to optimize these by turning down the compression level in the `exe` installers. These aren't super heavily used so there's no great need for them to be so ultra-compressed, so let's dial back the compression parameters to get closer to the rest of our xz archives. This brings the installer in line with the gz tarball installer locally, and also brings the compression settings on par with the rest of our xz installers.
Configuration menu - View commit details
-
Copy full SHA for 6b642fd - Browse repository at this point
Copy the full SHA 6b642fdView commit details -
Rollup merge of rust-lang#64617 - alexcrichton:smaller-msi, r=Mark-Si…
…mulacrum rustbuild: Turn down compression on msi installers This is the same as rust-lang#64615 except applied to our MSI installers. The same fix is applied effectively bringing these installers in line with the gz tarball installers, which are about 3x faster to produce locally and likely much faster to produce on CI.
Configuration menu - View commit details
-
Copy full SHA for 8965cb7 - Browse repository at this point
Copy the full SHA 8965cb7View commit details -
Rollup merge of rust-lang#64618 - alexcrichton:improve-dist-output, r…
…=Mark-Simulacrum rustbuild: Improve output of `dist` step * Pass `/Q` to `iscc` on Windows to supress the thousands of lines of output about compressing documentation. * Print out what's happening before long steps * Use `timeit` to print out timing information for long-running installer assemblies. * Try to scope output of `Dist ...` to not also encompass actual build steps
Configuration menu - View commit details
-
Copy full SHA for a5c7e68 - Browse repository at this point
Copy the full SHA a5c7e68View commit details -
Rollup merge of rust-lang#64621 - XAMPPRocky:relnotes, r=Mark-Simulacrum
Add Compatibility Notes to RELEASES.md for 1.38.0 ### [Rendered](https://github.com/XAMPPRocky/rust/blob/relnotes/RELEASES.md) r? @Mark-Simulacrum
Configuration menu - View commit details
-
Copy full SHA for 558f84c - Browse repository at this point
Copy the full SHA 558f84cView commit details -
Rollup merge of rust-lang#64632 - guanqun:patch-1, r=jonas-schievink
remove the extra comma after the match arm This would follow the same coding style as all the other match arms in this file.
Configuration menu - View commit details
-
Copy full SHA for 8ac0864 - Browse repository at this point
Copy the full SHA 8ac0864View commit details -
Rollup merge of rust-lang#64641 - cuviper:extern-rust-ctypes, r=estebank
Exempt extern "Rust" from improper_ctypes It should be fine for Rust ABIs to involve any Rust type. Fixes rust-lang#64593.
Configuration menu - View commit details
-
Copy full SHA for 4cef643 - Browse repository at this point
Copy the full SHA 4cef643View commit details