Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #63962. Hint about missing tuple parentheses in patterns #64619

Merged
merged 1 commit into from
Sep 22, 2019
Merged

Fixes #63962. Hint about missing tuple parentheses in patterns #64619

merged 1 commit into from
Sep 22, 2019

Conversation

sam09
Copy link
Contributor

@sam09 sam09 commented Sep 19, 2019

No description provided.

@rust-highfive
Copy link
Collaborator

r? @matthewjasper

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 19, 2019
@Centril
Copy link
Contributor

Centril commented Sep 19, 2019

r? @Centril

Centril
Centril suggested changes Sep 19, 2019
View reviewed changes
Copy link
Contributor

@Centril Centril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Here are some ways to improve things.

src/librustc_typeck/check/pat.rs Outdated Show resolved Hide resolved
src/librustc_typeck/check/pat.rs Outdated Show resolved Hide resolved
src/librustc_typeck/check/pat.rs Outdated Show resolved Hide resolved
src/librustc_typeck/check/pat.rs Outdated Show resolved Hide resolved
@Centril Centril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 19, 2019
@sam09
Copy link
Contributor Author

sam09 commented Sep 20, 2019

@estebank @Centril Updated the commit.

Also thanks a lot for the review 😄

@rust-highfive

This comment has been minimized.

Sign in to view
@estebank
Copy link
Contributor

r=me once green

@sam09 sam09 force-pushed the fix-63962 branch 2 times, most recently from 8b1a0ea to 66298d9 Compare September 21, 2019 07:07
@sam09
Copy link
Contributor Author

sam09 commented Sep 21, 2019

r? @estebank

@rust-highfive rust-highfive assigned estebank and unassigned Centril Sep 21, 2019
@Centril
Copy link
Contributor

Centril commented Sep 21, 2019

Thanks! @bors r=Centril,estebank

@bors
Copy link
Contributor

bors commented Sep 21, 2019

📌 Commit 66298d97a4f11b78ccbead79b6fd00be4b1f2156 has been approved by Centril,estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 21, 2019
@Centril Centril mentioned this pull request Sep 21, 2019
Closed
@Centril
Copy link
Contributor

Centril commented Sep 21, 2019

@sam09 Can you please fixup the second commit into the first?

@sam09
Copy link
Contributor Author

sam09 commented Sep 21, 2019

@sam09 Can you please fixup the second commit into the first?

Done

@Centril
Copy link
Contributor

Centril commented Sep 21, 2019

@bors r+

@bors
Copy link
Contributor

bors commented Sep 21, 2019

📌 Commit a2a57bc has been approved by Centril

Centril added a commit to Centril/rust that referenced this pull request Sep 21, 2019
@Centril
Rollup merge of rust-lang#64619 - sam09:fix-63962, r=Centril
b21ec22 
Fixes rust-lang#63962. Hint about missing tuple parentheses in patterns
@Centril Centril mentioned this pull request Sep 21, 2019
Merged
bors added a commit that referenced this pull request Sep 22, 2019
@bors
Auto merge of #64666 - Centril:rollup-tp98vlr, r=Centril
ef906d0 
Rollup of 9 pull requests

Successful merges:

 - #63907 (Add explanation to type mismatch involving type params and assoc types)
 - #64615 (rustbuild: Turn down compression on exe installers)
 - #64617 (rustbuild: Turn down compression on msi installers)
 - #64618 (rustbuild: Improve output of `dist` step)
 - #64619 (Fixes #63962. Hint about missing tuple parentheses in patterns)
 - #64634 (Update to LLVM 9.0.0)
 - #64635 (Allow using fn pointers in const fn with unleash miri)
 - #64660 (unify errors for tuple/struct variants)
 - #64664 (fully remove AstBuilder)

Failed merges:

r? @ghost
@bors bors merged commit a2a57bc into rust-lang:master Sep 22, 2019
@Centril Centril mentioned this pull request Sep 24, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estebank estebank estebank approved these changes

@Centril Centril Centril requested changes

Assignees

@estebank estebank

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sam09 @rust-highfive @Centril @estebank @bors @matthewjasper