Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize dropck #64595

Merged
merged 2 commits into from
Oct 17, 2019
Merged

Optimize dropck #64595

merged 2 commits into from
Oct 17, 2019

Commits on Oct 12, 2019

  1. Make trivial dropck outlives a query 

    This allows caching some recursive types and getting to an error much
more quickly.
    @Mark-Simulacrum
    Mark-Simulacrum committed Oct 12, 2019
    Configuration menu
    Copy the full SHA
    62fba55 View commit details
    Browse the repository at this point in the history

  2. Keep allocated vectors during dropck 

    Previously we'd frequently throw away vectors which is bad for
performance
    @Mark-Simulacrum
    Mark-Simulacrum committed Oct 12, 2019
    Configuration menu
    Copy the full SHA
    8de7fd8 View commit details
    Browse the repository at this point in the history